Skip to content

Avoid using data classes in the API #984

@3flex

Description

@3flex

I noticed that the API makes liberal use of Kotlin data classes. This is discouraged for libraries:

I suggest removing data classes from the public API. If any of those classes still require equals, hashCode and toString implementations the Poko compiler plugin can generate those by adding a simple annotation to classes that require it.

I would be happy to work on a PR for this but given it would be a breaking change I'm not sure if this should be parked until a possible v2 release or if it could be done as part of v1.6.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions