Porcelain add() does not work relative paths, or a directory on Windows

[MattSable]

porcelain.add() only works if the filepaths are absolute paths. You cannot specify a directory either, you must pass a list of files. I would expect

porcelain.add(repo, repo.path)

should stage all files in the repo. Instead, nothing gets staged.

[jelmer]

On Tue, Nov 07, 2017 at 06:59:51PM +0000, Matt wrote: porcelain.add() only works if the filepaths are absolute paths. You cannot specify a directory either, you must pass a list of files. I would expect `porcelain.add(repo, repo.path)` should stage all files in the repo. Instead, nothing gets staged.

This is very likely Windows-specific. Unfortunately I don't have access to Windows, but pull requests to fix this on Windows would be great.

[derSeddy]

This has nothing to do with windows.
A quick look into the code shows that directories are simply not supported and that file paths are assumed to be relative to the current python working dir.
This code will fail if working dir is different than repo dir:

repo = porcelain.open_repo(repo_dir)
status = porcelain.status(repo)
porcelain.add(repo, status.unstaged + status.untracked)

This code is a working alternative:

repo = porcelain.open_repo(repo_dir)
status = porcelain.status(repo)
repo.stage(status.unstaged + status.untracked)