Skip to content

Config for validation.enabled not be applied correctly #151

@BMartinos

Description

@BMartinos

Current behaviour:
The resource validation is being applied whether the config value is set to 'true' or 'false'

Expected behaviour
Setting the validation.enabled value to 'false' should disable the resource validation

Bug solution
https://github.com/jembi/hearth/blob/master/lib/server.js#L70

if (!config.getConf('validation:enabled')) {

The places where this config is being checked needs to be updated to check the string value coming back from the config. At the moment, the conditions are assuming these are Booleans and evaluate to true for both string values ('true' / 'false')

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions