chore(STONEINTG-1189): annotate PLR when component missing

This fixes a silent failure where the Build PipelineRun would stall if
the appstudio.openshift.io/component label was incorrect, not found,
or missing entirely.

Changes:
* Added logic to catch 'Component Not Found' errors during loader.
* Added logic to catch cases where the component label is nil.
* In both cases, the PipelineRun is now annotated with
  test.appstudio.openshift.io/create-snapshot-status='failed'.
* Ensured Finalizer is removed if component is not found, allowing
  resource deletion.

Testing:
* Added unit tests in buildpipeline_controller_test.go covering
  both scenarios.

Generated-by: Cursor

Signed-off-by: jcullina <[email protected]>

Author: jencull

internal/controller/buildpipeline/buildpipeline_controller.go

@@ -18,6 +18,7 @@ package buildpipeline
 
 import (
 	"context"
+	"fmt"
 
 	"github.com/konflux-ci/integration-service/cache"
 	"k8s.io/client-go/util/retry"
@@ -86,6 +87,11 @@ func (r *Reconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Resu
 		return err
 	})
 	if err != nil {
+		// Annotate the PipelineRun with the error before handling it
+		tknErr := tekton.AnnotateBuildPipelineRunWithCreateSnapshotAnnotation(ctx, pipelineRun, r.Client, err)
+		if tknErr != nil {
+			return ctrl.Result{}, tknErr
+		}
 		if errors.IsNotFound(err) {
 			// Use retry logic to handle etcd timeouts when removing finalizer
 			err = retry.RetryOnConflict(retry.DefaultRetry, func() error {
@@ -105,6 +111,11 @@ func (r *Reconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Resu
 		// if both component and error are nil then the component label for the pipeline did not exist
 		// in this case we should stop reconciliation
 		logger.Info("Failed to  get component for build pipeline - component label does not exist", "name", pipelineRun.Name, "namespace", pipelineRun.Namespace)
+		componentErr := fmt.Errorf("component label does not exist on pipelineRun %s/%s", pipelineRun.Namespace, pipelineRun.Name)
+		tknErr := tekton.AnnotateBuildPipelineRunWithCreateSnapshotAnnotation(ctx, pipelineRun, r.Client, componentErr)
+		if tknErr != nil {
+			return ctrl.Result{}, tknErr
+		}
 		return ctrl.Result{}, nil
 	}
 

internal/controller/buildpipeline/buildpipeline_controller_test.go

@@ -17,6 +17,7 @@ limitations under the License.
 package buildpipeline
 
 import (
+	"encoding/json"
 	"reflect"
 	"time"
 
@@ -297,7 +298,17 @@ var _ = Describe("PipelineController", func() {
 				Namespace: buildPipelineRun.Namespace,
 				Name:      buildPipelineRun.Name,
 			}, buildPipelineRun)
-			return err == nil && !controllerutil.ContainsFinalizer(buildPipelineRun, helpers.IntegrationPipelineRunFinalizer)
+			if err != nil {
+				return false
+			}
+			// Verify the annotation is set
+			if annotation, ok := buildPipelineRun.Annotations[helpers.CreateSnapshotAnnotationName]; ok {
+				var info map[string]string
+				if err := json.Unmarshal([]byte(annotation), &info); err == nil {
+					return info["status"] == "failed" && !controllerutil.ContainsFinalizer(buildPipelineRun, helpers.IntegrationPipelineRunFinalizer)
+				}
+			}
+			return false
 		}, time.Second*20).Should(BeTrue())
 	})
 
@@ -371,7 +382,25 @@ var _ = Describe("PipelineController", func() {
 			result, err := pipelineReconciler.Reconcile(ctx, reqNoComponent)
 			Expect(reflect.TypeOf(result)).To(Equal(reflect.TypeOf(reconcile.Result{})))
 			Expect(err).ToNot(HaveOccurred())
-		})
 
+			// Verify the annotation is set when component is nil
+			Eventually(func() bool {
+				err := k8sClient.Get(ctx, types.NamespacedName{
+					Namespace: buildPipelineRunNoComponent.Namespace,
+					Name:      buildPipelineRunNoComponent.Name,
+				}, buildPipelineRunNoComponent)
+				if err != nil {
+					return false
+				}
+				if annotation, ok := buildPipelineRunNoComponent.Annotations[helpers.CreateSnapshotAnnotationName]; ok {
+					var info map[string]string
+					if err := json.Unmarshal([]byte(annotation), &info); err == nil {
+						return info["status"] == "failed" &&
+							info["message"] == "Failed to create snapshot. Error: component label does not exist on pipelineRun default/pipelinerun-sample-no-component"
+					}
+				}
+				return false
+			}, time.Second*20).Should(BeTrue())
+		})
 	})
 })