Issue redirections errors

[lemeurherve]

Reproduction steps

Non migrated issue redirections:

1. Check https://issue-redirect.jenkins.io/issue/10000 redirection
2. Check https://issue-redirect.jenkins.io/issue/JENKINS-10000 redirection
3. Check https://issue-redirect.jenkins.io/JENKINS-10000 redirection
4. Check https://issue-redirect.jenkins.io/browse/JENKINS-10000 redirection

Migrated issue redirections:
5. Check https://issue-redirect.jenkins.io/issue/1 redirection
6. Check https://issue-redirect.jenkins.io/issue/JENKINS-1 redirection
7. Check https://issue-redirect.jenkins.io/JENKINS-1 redirection
8. Check https://issue-redirect.jenkins.io/browse/JENKINS-1 redirection

INFRA migrated issue redirections:
9. Check https://issue-redirect.jenkins.io/issue/INFRA-123 redirection
10. Check https://issue-redirect.jenkins.io/browse/INFRA-123 redirection
11. Check https://issue-redirect.jenkins.io/INFRA-123 redirection

Expected Results

All links redirect to https://issues.jenkins.io/browse/JENKINS-10000 for JENKINS-1000 (not migrated)
All links redirect to https://github.com/jenkinsci/jenkins/issues/13336 for JENKINS-1 (migrated from JENKINS project)
All links redirect to https://github.com/jenkins-infra/helpdesk/issues/167 for INFRA-123 (migrated from INFRA project)

Actual Results

1. redirects to https://issues.jenkins.io/browse/JENKINS-10000
2. wrongly redirects to https://issues.jenkins.io/browse/JENKINS-JENKINS-10000
3. returns a 404 error
4. returns a 404 error
5. redirects to https://github.com/jenkinsci/jenkins/issues/13336
6. wrongly redirects to https://issues.jenkins.io/browse/JENKINS-JENKINS-1
7. redirects to https://github.com/jenkinsci/jenkins/issues/13336
8. redirects to https://github.com/jenkinsci/jenkins/issues/13336
9. wrongly redirects to https://issues.jenkins.io/browse/JENKINS-INFRA-123
10. redirects to https://github.com/jenkins-infra/helpdesk/issues/167
11. redirects to https://github.com/jenkins-infra/helpdesk/issues/167

Anything else?

No response

[lemeurherve]

Still some redirection errors, fix incoming.

2. Check https://issue-redirect.jenkins.io/issue/JENKINS-10000 redirection
3. Check https://issue-redirect.jenkins.io/JENKINS-10000 redirection
4. Check https://issue-redirect.jenkins.io/browse/JENKINS-10000 redirection

2. wrongly redirects to https://issues.jenkins.io/browse/JENKINS-JENKINS-10000
3. returns a 404 error
4. returns a 404 error

[lemeurherve]

Finally got the time to look at it again, it tooks me far too long and some helpful rubberducking with @dduportal to realise that this default conf is overriden with https://github.com/jenkins-infra/helm-charts/tree/main/charts/nginx-website in the deployed service 🤦

I've checked again #12, it was already properly fixing all errors, it was just never taken in account cf jenkins-infra/kubernetes-management#7292

Fix incoming

[dduportal]

Finally got the time to look at it again, it tooks me far too long and some helpful rubberducking with @dduportal to realise that this default conf is overriden with https://github.com/jenkins-infra/helm-charts/tree/main/charts/nginx-website in the deployed service 🤦

I've checked again #12, it was already properly fixing all errors, it was just never taken in account cf jenkins-infra/kubernetes-management#7292

Fix incoming

PR jenkins-infra/kubernetes-management#7413 deployed, i'll let you check on your side

As an improvement (once your fix is verified) to avoid maintaining 2 copies of the rewrites, I would suggest to:

• Move the rewrites out of https://github.com/jenkins-infra/docker-issue-redirect/blob/main/docker/default.conf into a rewrite.conf file embeded in the container image so it would be the same in production.
  • Note: should be stored somewhere else than /etc/nginx/conf.d otherwise it would be overridden by the helm chart configuration mount. I suggest /etc/nginx/includes like the jira-to-github config.
• Then the container image default.conf would only have to include the file, like

  docker-issue-redirect/docker/default.conf

  Line 13 in 7d22e75

  include includes/jira-to-github-redirects.conf;

  • And of course the same in the default.conf in production: https://github.com/jenkins-infra/kubernetes-management/blob/6eaa98f0fedbe280e25b6afbdb26788aa374df37/config/publick8s_issue-redirect-jenkins-io.yaml#L59

[lemeurherve]

Still some redirection errors, fix incoming.

2. Check https://issue-redirect.jenkins.io/issue/JENKINS-10000 redirection
3. Check https://issue-redirect.jenkins.io/JENKINS-10000 redirection
4. Check https://issue-redirect.jenkins.io/browse/JENKINS-10000 redirection

2. wrongly redirects to https://issues.jenkins.io/browse/JENKINS-JENKINS-10000
3. returns a 404 error
4. returns a 404 error

After restarting the pods on publick8s, I confirm that those redirections are now properly working, as all others mentioned in the issue body.