-
-
Notifications
You must be signed in to change notification settings - Fork 2
Open
Labels
enhancementNew feature or requestNew feature or request
Description
What feature do you want to see added?
From #11 (comment):
As an improvement [...] to avoid maintaining 2 copies of the rewrites, I would suggest to:
- Move the rewrites out of https://github.com/jenkins-infra/docker-issue-redirect/blob/main/docker/default.conf into a
rewrite.conffile embeded in the container image so it would be the same in production.
- Note: should be stored somewhere else than
/etc/nginx/conf.dotherwise it would be overridden by the helm chart configuration mount. I suggest/etc/nginx/includeslike the jira-to-github config.- Then the container image
default.confwould only have to include the file, likedocker-issue-redirect/docker/default.conf
Line 13 in 7d22e75
include includes/jira-to-github-redirects.conf;
- And of course the same in the
default.confin production: https://github.com/jenkins-infra/kubernetes-management/blob/6eaa98f0fedbe280e25b6afbdb26788aa374df37/config/publick8s_issue-redirect-jenkins-io.yaml#L59
Upstream changes
No response
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request