Adapt to GitHub issues migration for core (#46)

Author: timja

Makefile

@@ -7,9 +7,14 @@ docker:
 	docker build -t $(IMAGE):$(TAG) .
 
 run: docker
-	docker-compose up --build
+	docker-compose up --build -d
 
 # when run with 'make run', makes sure that it responds correctly
 run-test:
-	curl -v 'http://localhost:8085/rate/submit.php?version=1.234&rating=0&issue=80386' 2>&1
+	curl -v 'http://localhost:8085/rate/submit.php?version=2.536&rating=0&issue=80386' 2>&1
+	curl -v 'http://localhost:8085/rate/submit.php?version=2.536&rating=0&issue=https://github.com/jenkinsci/jenkins/issues/20615#issuecomment-3572009192' 2>&1
+	curl -v 'http://localhost:8085/rate/submit.php?version=2.536&rating=0&issue=https://github.com/jenkinsci/jenkins/issues/20616#issue-3659905060' 2>&1
+	curl -v 'http://localhost:8085/rate/submit.php?version=2.536&rating=0&issue=https://github.com/jenkinsci/jenkins/issues/20620/#issue-3659905060' 2>&1
+	curl -v 'http://localhost:8085/rate/submit.php?version=2.536&rating=0&issue=https://github.com/jenkinsci/jenkins/issues/20617/' 2>&1
+	curl -v 'http://localhost:8085/rate/submit.php?version=2.536&rating=0&issue=https://github.com/jenkinsci/jenkins/issues/20608' 2>&1
 	curl -v 'http://localhost:8085/rate/result.php' 2>&1

src/rate/submit.php

@@ -11,8 +11,16 @@
     } else {
       $row = array('version' => $_GET['version'], 'voter' => $voter,
                    'rollback' => $_GET['rating'] == -1);
-      $issue = (int)preg_replace('/^(JENKINS|HUDSON)-/i', '', $_GET['issue']);
-      if ($issue > 0) $row['issue'] = $issue;
+      // Remove any fragment from issue URL
+      $issue = preg_replace('/#.*$/', '', $_GET['issue']);
+      // Remove trailing slash
+      $issue = rtrim($issue, '/');
+      if (isset($_GET['issue']) && preg_match('#^https://github\.com/jenkinsci/[a-zA-Z0-9._-]+/issues/(\d+)$#', $issue, $matches)) {
+        $row['issue'] = $issue;
+      } else {
+        $issue = (int)preg_replace('/^(JENKINS|HUDSON)-/i', '', $_GET['issue']);
+        if ($issue > 0) $row['issue'] = $issue;
+      }
       pg_insert($db, 'jenkins_bad', $row);
     }
     pg_close($db);

test/initdb.d/10-schema.sql

@@ -3,7 +3,7 @@ SET client_encoding = 'UTF8';
 CREATE TABLE jenkins_bad (
     version character varying(10) NOT NULL,
     rollback boolean NOT NULL,
-    issue integer,
+    issue text,
     voter character varying(30)
 );