Hosting request for active-git-branches-plugin

[litchicoder]

Repository URL

https://github.com/litchicoder/active-git-branches-plugin

New Repository Name

active-git-branches-plugin

Description

This plugin adds a new parameter type "Active Git Branches" to Jenkins. It allows users to dynamically list and select Git branches from a remote repository based on branch activity (commit time).

GitHub users to have commit permission

@litchicoder
@liujicheng

Jenkins project users to have release permission

litchicoder
liujicheng

Issue tracker

GitHub issues

Automated release via GitHub Actions (recommended)

Yes

[jenkins-cert-app]

Security audit, information and commands

The security team is auditing all the hosting requests, to ensure a better security by default.

This message informs you that a Jenkins Security Scan was triggered on your repository.
It takes ~10 minutes to complete.

Commands

The bot will parse all comments, and it will check if any line start with a command.

Security team only:

• /audit-ok => the audit is complete, the hosting can continue 🎉.
• /audit-skip => the audit is not necessary, the hosting can continue 🎉.
• /audit-findings => the audit reveals some issues that require corrections ✏️.

Anyone:

• /request-security-scan => the findings from the Jenkins Security Scan were corrected, this command will re-scan your repository 🔍.
• /audit-review => the findings from the audit were corrected, this command will ping the security team to review the findings 👀. It's only applicable when the previous audit required changes.

Only one command can be requested per comment.

(automatically generated message, version: 1.35.6)

[litchicoder]

您好，邮件已收到，我会尽快给您回复。谢谢！                                                                                                              刘计城

[github-actions]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• ⛔ Required: Your baseline specified does not meet the minimum Jenkins version required, please update <jenkins.version>2.387.3</jenkins.version> to at least 2.492.3 in your pom.xml. Take a look at the baseline recommendations.
• ⛔ Required: You must specify an <scm> block in your pom.xml. See https://maven.apache.org/pom.html#SCM for more information.
• ⛔ Required: The version in the pom.xml must contain ${changelist} when CD is enabled.
• ⛔ Required: The property changelist must be defined and set to 999999-SNAPSHOT when CD is enabled.
• ⛔ Required: The parent pom version '4.75' should be at least '5.28' or higher.
• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: @litchi, @litchicoder (reports are re-synced hourly, wait to re-check for a bit after logging in)
• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: @litchi, @litchicoder (reports are re-synced hourly, wait to re-check for a bit after logging in)
• ⛔ Required: The 'artifactId' from the pom.xml (active-git-branches-plugin) is incorrect, it should be active-git-branches ('New Repository Name' field with "-plugin" removed)
• ⛔ Required: Please remove the property java.level from the pom.xml. It is already defined via the parent pom.
• ⛔ Required: Please define the property jenkins.baseline and use this property in <jenkins.version>${jenkins.baseline}.3</jenkins.version> and the artifactId of the bom.
• ⛔ Required: Please define the property hpi.strictBundledArtifacts and set it to true. This should help prevent accidental library bundling when adding and updating dependencies.See Bundling third-party libraries.
• ⛔ Required: No files found related to automatically updating the plugin dependencies. Please ensure that you have dependabot, renovate or updatecli configured in the repo. A suitable version for dependabot can be downloaded here
• ⛔ Required: Missing file Jenkinsfile. Please add a Jenkinsfile to your repo so it can be built on ci.jenkins.io. A suitable version can be downloaded here
• ⛔ Required: Missing file .mvn/extensions.xml. This file is required when CD is enabled. A suitable version can be downloaded here
• ⛔ Required: Missing file .mvn/config. This file is required when CD is enabled. Download maven.config and add the line: -Dchangelist.format=%d.v%s
• ⛔ Required: Missing file .github/workflows/jenkins-security-scan.yml. This file helps to keep your plugin conform to security standards defined by the Jenkins project. A suitable version can be downloaded here
• ⛔ Required: Missing file .github/workflows/cd.yaml. This file is required when CD is enabled. A suitable version can be downloaded [here](https://raw.githubusercontent.com/jenkinsci/.github/master/workflow-templates/cd.yaml
• ⛔ Required: Missing file .github/CODEOWNERS. Please add this file containing the line: * @jenkinsci/active-git-branches-plugin-developers

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[jenkins-cert-app]

❌ Jenkins Security Scan failed.
The Security team was notified about this.

[github-actions]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• ⛔ Required: Your baseline specified does not meet the minimum Jenkins version required, please update <jenkins.version>2.387.3</jenkins.version> to at least 2.492.3 in your pom.xml. Take a look at the baseline recommendations.
• ⛔ Required: You must specify an <scm> block in your pom.xml. See https://maven.apache.org/pom.html#SCM for more information.
• ⛔ Required: The version in the pom.xml must contain ${changelist} when CD is enabled.
• ⛔ Required: The property changelist must be defined and set to 999999-SNAPSHOT when CD is enabled.
• ⛔ Required: The parent pom version '4.75' should be at least '5.28' or higher.
• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: @litchicoder, @liujicheng (reports are re-synced hourly, wait to re-check for a bit after logging in)
• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: @litchicoder, @liujicheng (reports are re-synced hourly, wait to re-check for a bit after logging in)
• ⛔ Required: The 'artifactId' from the pom.xml (active-git-branches-plugin) is incorrect, it should be active-git-branches ('New Repository Name' field with "-plugin" removed)
• ⛔ Required: Please remove the property java.level from the pom.xml. It is already defined via the parent pom.
• ⛔ Required: Please define the property jenkins.baseline and use this property in <jenkins.version>${jenkins.baseline}.3</jenkins.version> and the artifactId of the bom.
• ⛔ Required: Please define the property hpi.strictBundledArtifacts and set it to true. This should help prevent accidental library bundling when adding and updating dependencies.See Bundling third-party libraries.
• ⛔ Required: No files found related to automatically updating the plugin dependencies. Please ensure that you have dependabot, renovate or updatecli configured in the repo. A suitable version for dependabot can be downloaded here
• ⛔ Required: Missing file Jenkinsfile. Please add a Jenkinsfile to your repo so it can be built on ci.jenkins.io. A suitable version can be downloaded here
• ⛔ Required: Missing file .mvn/extensions.xml. This file is required when CD is enabled. A suitable version can be downloaded here
• ⛔ Required: Missing file .mvn/config. This file is required when CD is enabled. Download maven.config and add the line: -Dchangelist.format=%d.v%s
• ⛔ Required: Missing file .github/workflows/jenkins-security-scan.yml. This file helps to keep your plugin conform to security standards defined by the Jenkins project. A suitable version can be downloaded here
• ⛔ Required: Missing file .github/workflows/cd.yaml. This file is required when CD is enabled. A suitable version can be downloaded [here](https://raw.githubusercontent.com/jenkinsci/.github/master/workflow-templates/cd.yaml
• ⛔ Required: Missing file .github/CODEOWNERS. Please add this file containing the line: * @jenkinsci/active-git-branches-plugin-developers

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[liujicheng]

您好，邮件已收到，我会尽快给您回复。谢谢！                                                                                                              刘计城

[mawinter69]

• https://github.com/litchicoder/active-git-branches-plugin/blob/bbaa5e1d714fa7d166f53ed688bb1cb7ced6b7d5/src/main/java/io/jenkins/plugins/activegitbranches/ActiveGitBranchesParameterDefinition.java#L443 must be annotated with @POST
• https://github.com/litchicoder/active-git-branches-plugin/blob/bbaa5e1d714fa7d166f53ed688bb1cb7ced6b7d5/src/main/java/io/jenkins/plugins/activegitbranches/ActiveGitBranchesParameterDefinition.java#L478 The method is doing remote calls so it must be annotated with @POST and it requires a permission check
• https://github.com/litchicoder/active-git-branches-plugin/blob/bbaa5e1d714fa7d166f53ed688bb1cb7ced6b7d5/src/main/java/io/jenkins/plugins/activegitbranches/ActiveGitBranchesParameterDefinition.java#L518 The method is doing remote calls so it must be annotated with @POST and it requires a permission check

[mawinter69]

/hosting re-check

[github-actions]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: @litchicoder, @liujicheng (reports are re-synced hourly, wait to re-check for a bit after logging in)
• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: @litchicoder, @liujicheng (reports are re-synced hourly, wait to re-check for a bit after logging in)
• ⛔ Required: Invalid version 17 for jdk. jdk must be one of [21, 25] in the buildPlugin call in the Jenkinsfile.

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[github-actions]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: litchicoder (reports are re-synced hourly, wait to re-check for a bit after logging in)
• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: litchicoder, liujicheng (reports are re-synced hourly, wait to re-check for a bit after logging in)
• ⛔ Required: Invalid version 17 for jdk. jdk must be one of [21, 25] in the buildPlugin call in the Jenkinsfile.

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[mawinter69]

• https://github.com/litchicoder/active-git-branches-plugin/blob/bbaa5e1d714fa7d166f53ed688bb1cb7ced6b7d5/pom.xml#L86 The dependency to structs plugin is not needed
• https://github.com/litchicoder/active-git-branches-plugin/blob/bbaa5e1d714fa7d166f53ed688bb1cb7ced6b7d5/pom.xml#L107 The build section should be removed. It is not needed, the parent pom already sets all relevant things usually.
• https://github.com/litchicoder/active-git-branches-plugin/blob/bbaa5e1d714fa7d166f53ed688bb1cb7ced6b7d5/.mvn/extensions.xml#L5 Please use the latest version 1.13
• https://github.com/litchicoder/active-git-branches-plugin/blob/bbaa5e1d714fa7d166f53ed688bb1cb7ced6b7d5/src/main/java/io/jenkins/plugins/activegitbranches/ActiveGitBranchesParameterDefinition.java#L176 Cloning the repo to list the available branch seems very expensive. With git ls-remote you can query for branches without cloning. I have repos that have pack files of 10GiB and cloning takes several minutes best case.
• https://github.com/litchicoder/active-git-branches-plugin/blob/bbaa5e1d714fa7d166f53ed688bb1cb7ced6b7d5/src/main/resources/io/jenkins/plugins/activegitbranches/ActiveGitBranchesParameterDefinition/index.jelly#L11 (also line 17) that creates an unstyled select dropdown. To get a properly styled select please use

<div class="jenkins-select">
  <select class="jenkins-select__input" ...>
    ...
  </select>
</div>

• In the README.md I think there is no need to include the Requirements and the Installation section. The requirements for the Jenkins version is directly shown on the plugins homepage at plugins.jenkins.io. There you also find installation instructions. The java version is defined by the Jenkins core version and the git plugin will be installed automatically when you install your plugin via the webui. Only when uploading the hpi directly the git plugin would be missing eventually
• The development section should be moved to a separate file. And it needs an update to reflect the latest requirements: Java 17 and maven 3.9.6

[litchicoder]

/hosting re-check