Merge pull request #469 from Maximilien-R/mra/fix-action-unmarshal-json

fix: fix Action JSON serialization/deserialization

Author: jenkins-x-bot

scm/const.go

@@ -141,7 +141,7 @@ func (a Action) String() (s string) {
 	case ActionSubmitted:
 		return "submitted"
 	case ActionDismissed:
-		return "dismisssed"
+		return "dismissed"
 	case ActionAssigned:
 		return "assigned"
 	case ActionUnassigned:
@@ -205,6 +205,14 @@ func (a *Action) UnmarshalJSON(data []byte) error {
 		*a = ActionDismissed
 	case "edited":
 		*a = ActionEdited
+	case "assigned":
+		*a = ActionAssigned
+	case "unassigned":
+		*a = ActionUnassigned
+	case "review_requested":
+		*a = ActionReviewRequested
+	case "review_request_removed":
+		*a = ActionReviewRequestRemoved
 	}
 	return nil
 }

scm/const_test.go

@@ -25,3 +25,24 @@ func TestStateJSON(t *testing.T) {
 		})
 	}
 }
+
+func TestActionJSON(t *testing.T) {
+	for i := ActionCreate; i < ActionCompleted; i++ {
+		in := i
+		t.Run(in.String(), func(t *testing.T) {
+			b, err := json.Marshal(in)
+			if err != nil {
+				t.Fatal(err)
+			}
+
+			var out Action
+			if err := json.Unmarshal(b, &out); err != nil {
+				t.Fatal(err)
+			}
+
+			if in != out {
+				t.Errorf("%s != %s", in, out)
+			}
+		})
+	}
+}