Skip to content

Create JenkinsPipelineUnit - unable to mock getId() called within scr…#561

Open
akashissu wants to merge 1 commit intojenkinsci:masterfrom
akashissu:master
Open

Create JenkinsPipelineUnit - unable to mock getId() called within scr…#561
akashissu wants to merge 1 commit intojenkinsci:masterfrom
akashissu:master

Conversation

@akashissu
Copy link

…ipt block

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Copy link
Contributor

@nre-ableton nre-ableton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any actual fix, just a test case (?). Maybe you forgot to stage some code before committing/pushing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants