Skip to content

Commit 1b57f96

Browse files
authored
Increase timeout on ant plugin tests (#2170)
increase build timeout The test was timing out as the ant build took longer than 2 minutes (the default timeout for waiting for a build to complete in shouldSucceed We now wait for 4 minutes. Whilst we are still using external resources (so this will always have the potential to be flaky, this is actually testing the functionality that Jenkins does download from these external resources). Alternative would be to change the production code so we could overwrite tool installer URLs with some other URL (but then we would not fail if the upstream server changed layout). This is the just good enough quick fix
1 parent 4706294 commit 1b57f96

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

src/test/java/plugins/AntPluginTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ private Build buildHelloWorld(final String name) {
196196
return null;
197197
});
198198

199-
return job.startBuild().shouldSucceed().shouldContainsConsoleOutput("Hello World");
199+
return job.startBuild().waitUntilFinished(240).shouldSucceed().shouldContainsConsoleOutput("Hello World");
200200
}
201201

202202
private void setUpAnt() {

0 commit comments

Comments
 (0)