Skip to content

Commit 319e646

Browse files
authored
Support BiDi in RemoteWebDriver (#1992)
1 parent 43e767b commit 319e646

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

src/main/java/org/jenkinsci/test/acceptance/FallbackConfig.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@
6464
import org.openqa.selenium.firefox.FirefoxDriver;
6565
import org.openqa.selenium.firefox.FirefoxOptions;
6666
import org.openqa.selenium.firefox.GeckoDriverService;
67+
import org.openqa.selenium.remote.Augmenter;
6768
import org.openqa.selenium.remote.CapabilityType;
6869
import org.openqa.selenium.remote.LocalFileDetector;
6970
import org.openqa.selenium.remote.RemoteWebDriver;
@@ -155,7 +156,7 @@ private WebDriver createWebDriver(TestCleaner cleaner, TestName testName) throws
155156
}
156157
}
157158

158-
private RemoteWebDriver buildRemoteWebDriver(Capabilities options) throws MalformedURLException {
159+
private WebDriver buildRemoteWebDriver(Capabilities options) throws MalformedURLException {
159160
String u = System.getenv("REMOTE_WEBDRIVER_URL");
160161
if (StringUtils.isBlank(u)) {
161162
throw new Error("remote-webdriver type browsers require REMOTE_WEBDRIVER_URL to be set");
@@ -164,7 +165,7 @@ private RemoteWebDriver buildRemoteWebDriver(Capabilities options) throws Malfor
164165
new URL(u), // http://192.168.99.100:4444/wd/hub
165166
options);
166167
driver.setFileDetector(new LocalFileDetector());
167-
return driver;
168+
return new Augmenter().augment(driver);
168169
}
169170

170171
private String getBrowser() {
@@ -264,7 +265,7 @@ public String toString() {
264265
RemoteWebDriver remoteWebDriver =
265266
new RemoteWebDriver(new URL("http://127.0.0.1:" + controlPort + "/wd/hub"), capabilities);
266267
cleaner.addTask(cleanContainer);
267-
return remoteWebDriver;
268+
return new Augmenter().augment(remoteWebDriver);
268269
} catch (RuntimeException e) {
269270
cleanContainer.close();
270271
throw e;

0 commit comments

Comments
 (0)