fix and simplify checking if a plugin is checked to be installed

jtnord · jtnord · commit 3dc792d617fe · 2025-10-24T18:08:38.000+01:00
diff --git a/src/main/java/org/jenkinsci/test/acceptance/po/WizardCustomizeJenkins.java b/src/main/java/org/jenkinsci/test/acceptance/po/WizardCustomizeJenkins.java
@@ -125,13 +125,7 @@ public void selectSuggested() {
     }
 
     private boolean isSelected(String pluginKey) {
-        return driver
-                .findElements(by.xpath(
-                        "//div[contains(@class, 'plugins-for-category')]/div[contains(@class, 'plugin') and contains(@class, 'selected') and contains(@class, '%s')]",
-                        pluginKey))
-                .stream()
-                .findFirst()
-                .isPresent();
+        return driver.findElement(by.id("chk-" + pluginKey)).isSelected();
     }
 
     private List<WebElement> getSelected() {

Original file line number	Diff line number	Diff line change
`@@ -125,13 +125,7 @@ public void selectSuggested() {`
`125`	`125`	`}`
`126`	`126`
`127`	`127`	`private boolean isSelected(String pluginKey) {`
`128`		`- return driver`
`129`		`- .findElements(by.xpath(`
`130`		`- "//div[contains(@class, 'plugins-for-category')]/div[contains(@class, 'plugin') and contains(@class, 'selected') and contains(@class, '%s')]",`
`131`		`- pluginKey))`
`132`		`- .stream()`
`133`		`- .findFirst()`
`134`		`- .isPresent();`
	`128`	`+ return driver.findElement(by.id("chk-" + pluginKey)).isSelected();`
`135`	`129`	`}`
`136`	`130`
`137`	`131`	`private List<WebElement> getSelected() {`