Add LlvmLinkerParser for LLVM lld linker error parsing (#1245)

- Add LlvmLinkerParser class for parsing ld.lld error messages
- Support versioned linkers (ld.lld-15, etc.)
- Handle error/warning/note severity levels
- Integrate with ClangDescriptor using composite pattern
- Add comprehensive unit and integration tests

Resolves JENKINS-76141
Co-authored-by: Ullrich Hafner <[email protected]>

Author: sgscheffler

src/main/java/edu/hm/hafner/analysis/parser/LlvmLinkerParser.java

@@ -0,0 +1,61 @@
+package edu.hm.hafner.analysis.parser;
+
+import java.io.Serial;
+import java.util.Optional;
+import java.util.regex.Matcher;
+
+import edu.hm.hafner.analysis.Issue;
+import edu.hm.hafner.analysis.IssueBuilder;
+import edu.hm.hafner.analysis.LookaheadParser;
+import edu.hm.hafner.analysis.Severity;
+import edu.hm.hafner.util.LookaheadStream;
+
+/**
+ * A parser for LLVM lld linker warnings and errors.
+ *
+ * @author Steven Scheffler
+ */
+public class LlvmLinkerParser extends LookaheadParser {
+    @Serial
+    private static final long serialVersionUID = 1L;
+
+    // Capture optional path + program (handles /foo/bar/ld.lld, C:\foo\ld.lld-15.exe, etc.)
+    // Named groups: linker, severity, message
+    private static final String LLD_LINKER_PATTERN = 
+            "^(?<linker>.*[/\\\\]?ld\\.lld(?:-\\d+)?(?:\\.exe)?):\\s*(?<severity>error|warning|note):\\s*(?<message>.*)$";
+
+    /**
+     * Creates a new instance of {@link LlvmLinkerParser}.
+     */
+    public LlvmLinkerParser() {
+        super(LLD_LINKER_PATTERN);
+    }
+
+    @Override
+    protected Optional<Issue> createIssue(final Matcher matcher, final LookaheadStream lookahead,
+            final IssueBuilder builder) {
+        final String linkerPath = matcher.group("linker");
+        final String severity   = matcher.group("severity");
+        final String message    = matcher.group("message");
+
+        // Strip any path prefix and prepend "/" to prevent relative path resolution
+        final String fileName = "/" + linkerPath.replaceFirst("^.*[/\\\\]", "");
+
+        return builder.setFileName(fileName)
+                .setLineStart(0)
+                .setColumnStart(0)
+                .setCategory("Linker")
+                .setMessage(message.trim())
+                .setSeverity(mapPriority(severity))
+                .buildOptional();
+    }
+
+    private Severity mapPriority(final String severity) {
+        return switch (severity) {
+            case "error" -> Severity.WARNING_HIGH;
+            case "warning" -> Severity.WARNING_NORMAL;
+            case "note" -> Severity.WARNING_LOW;
+            default -> Severity.WARNING_NORMAL;
+        };
+    }
+}

src/main/java/edu/hm/hafner/analysis/registry/ClangDescriptor.java

@@ -1,23 +1,27 @@
 package edu.hm.hafner.analysis.registry;
 
+import java.util.Collection;
+
 import edu.hm.hafner.analysis.IssueParser;
 import edu.hm.hafner.analysis.parser.ClangParser;
+import edu.hm.hafner.analysis.parser.LlvmLinkerParser;
 
 /**
- * A descriptor for the Clang parser.
+ * A descriptor for the Clang parser (compiler + linker).
  *
  * @author Lorenz Munsch
+ * @author Steven Scheffler
  */
-class ClangDescriptor extends ParserDescriptor {
+class ClangDescriptor extends CompositeParserDescriptor {
     private static final String ID = "clang";
-    private static final String NAME = "Clang";
+    private static final String NAME = "Clang (LLVM based)";
 
     ClangDescriptor() {
         super(ID, NAME);
     }
 
     @Override
-    public IssueParser create(final Option... options) {
-        return new ClangParser();
+    protected Collection<? extends IssueParser> createParsers() {
+        return asList(new ClangParser(), new LlvmLinkerParser());
     }
-}
+}

src/test/java/edu/hm/hafner/analysis/parser/LlvmLinkerParserTest.java

@@ -0,0 +1,100 @@
+package edu.hm.hafner.analysis.parser;
+
+import java.util.Iterator;
+
+import org.junit.jupiter.api.Test;
+
+import edu.hm.hafner.analysis.Issue;
+import edu.hm.hafner.analysis.Report;
+import edu.hm.hafner.analysis.Severity;
+import edu.hm.hafner.analysis.assertions.SoftAssertions;
+import edu.hm.hafner.analysis.registry.AbstractParserTest;
+
+import static edu.hm.hafner.analysis.assertions.Assertions.*;
+
+/**
+ * Tests the class {@link LlvmLinkerParser}.
+ *
+ * @author Steven Scheffler
+ */
+class LlvmLinkerParserTest extends AbstractParserTest {
+    LlvmLinkerParserTest() {
+        super("llvm-linker.log");
+    }
+
+    @Override
+    protected LlvmLinkerParser createParser() {
+        return new LlvmLinkerParser();
+    }
+
+    @Override
+    protected void assertThatIssuesArePresent(final Report report, final SoftAssertions softly) {
+        softly.assertThat(report).hasSize(4);
+
+        Iterator<Issue> iterator = report.iterator();
+
+        softly.assertThat(iterator.next())
+                .hasLineStart(0)
+                .hasColumnStart(0)
+                .hasMessage("cannot open xyz: No such file or directory")
+                .hasFileName("/ld.lld")
+                .hasCategory("Linker")
+                .hasSeverity(Severity.WARNING_HIGH);
+
+        softly.assertThat(iterator.next())
+                .hasLineStart(0)
+                .hasColumnStart(0)
+                .hasMessage("undefined symbol: lld::elf::demangle(llvm::StringRef)")
+                .hasFileName("/ld.lld-15")
+                .hasCategory("Linker")
+                .hasSeverity(Severity.WARNING_HIGH);
+
+        softly.assertThat(iterator.next())
+                .hasLineStart(0)
+                .hasColumnStart(0)
+                .hasMessage("duplicate symbol found")
+                .hasFileName("/ld.lld")
+                .hasCategory("Linker")
+                .hasSeverity(Severity.WARNING_NORMAL);
+
+        softly.assertThat(iterator.next())
+                .hasLineStart(0)
+                .hasColumnStart(0)
+                .hasMessage("creating a DT_TEXTREL in a shared object")
+                .hasFileName("/ld.lld")
+                .hasCategory("Linker")
+                .hasSeverity(Severity.WARNING_LOW);
+    }
+
+    @Test
+    void shouldParseVersionedLld() {
+        var warnings = parse("versioned-lld.log");
+        assertThat(warnings).hasSize(3);
+
+        try (var softly = new SoftAssertions()) {
+            softly.assertThat(warnings.get(0))
+                    .hasFileName("/ld.lld-15")
+                    .hasMessage("cannot find -lmylib");
+        }
+    }
+
+    @Test
+    void shouldIgnoreNonLldLines() {
+        var warnings = parse("mixed-output.log");
+        assertThat(warnings).hasSize(2);
+        assertThat(warnings.stream()).allSatisfy(issue -> assertThat(issue).hasFileName("/ld.lld"));
+    }
+
+    @Test
+    void issue76141() {
+        var warnings = parse("issue76141.log");
+        assertThat(warnings).hasSize(1);
+
+        try (var softly = new SoftAssertions()) {
+            softly.assertThat(warnings.get(0))
+                    .hasMessage("cannot open xyz: No such file or directory")
+                    .hasFileName("/ld.lld-15")
+                    .hasSeverity(Severity.WARNING_HIGH);
+        }
+    }
+}

src/test/java/edu/hm/hafner/analysis/registry/ParsersTest.java

@@ -449,6 +449,12 @@ void shouldFindAllClangIssues() {
         findIssuesOfTool(9, "clang", "apple-llvm-clang.txt");
     }
 
+    /** Runs the Clang parser on mixed compiler and linker errors. */
+    @Test
+    void shouldFindAllClangAndLldIssues() {
+        findIssuesOfTool(4, "clang", "mixed-clang-lld-errors.log");
+    }
+
     /** Runs the Coolflux parser on an output file that contains 1 issues. */
     @Test
     void shouldFindAllCoolfluxIssues() {

src/test/resources/edu/hm/hafner/analysis/parser/issue76141.log

@@ -0,0 +1 @@
+ld.lld-15: error: cannot open xyz: No such file or directory

src/test/resources/edu/hm/hafner/analysis/parser/llvm-linker.log

@@ -0,0 +1,4 @@
+ld.lld: error: cannot open xyz: No such file or directory
+ld.lld-15: error: undefined symbol: lld::elf::demangle(llvm::StringRef)
+ld.lld: warning: duplicate symbol found
+ld.lld: note: creating a DT_TEXTREL in a shared object

src/test/resources/edu/hm/hafner/analysis/parser/mixed-clang-lld-errors.log

@@ -0,0 +1,4 @@
+main.cpp:42:10: error: use of undeclared identifier 'foo'
+main.cpp:15:5: warning: unused variable 'x' [-Wunused-variable]
+ld.lld: error: cannot open libbar.so: No such file or directory
+ld.lld: warning: creating a DT_TEXTREL in a shared object

src/test/resources/edu/hm/hafner/analysis/parser/mixed-output.log

@@ -0,0 +1,7 @@
+make: Entering directory '/path/to/project'
+clang++ -c main.cpp
+main.cpp:42:10: error: undeclared identifier 'foo'
+ld.lld: error: cannot open libbar.so: No such file or directory
+make: *** [app] Error 1
+ld.lld: warning: creating a DT_TEXTREL in a shared object
+make: Leaving directory '/path/to/project'

src/test/resources/edu/hm/hafner/analysis/parser/versioned-lld.log

@@ -0,0 +1,3 @@
+ld.lld-15: error: cannot find -lmylib
+ld.lld-18: warning: symbol 'foo' has undefined behavior
+ld.lld: error: section overlap detected