no UNKNOWN status for save image

Author: NorseGaud

src/main/java/com/veertu/plugin/anka/AbstractAnkaSlave.java

@@ -38,7 +38,6 @@ public AnkaMgmtCloud getCloud() {
     protected boolean taskExecuted;
     protected boolean saveImageSent;
     protected boolean hadProblemsInBuild = false;
-    protected boolean hadUnknownBuildOutcome = false;
 
     public String getJobNameAndNumber() {
         return jobNameAndNumber;
@@ -117,7 +116,7 @@ public void terminate() throws IOException {
                 LOGGER.log(Level.INFO, AnkaLog.prefix("Node {0} Instance {1} is in state {2}"), new Object[]{getNodeName(), instanceId, vm.getSessionState()});
                 SaveImageParameters saveImageParams = template.getSaveImageParameters();
                 if (taskExecuted && saveImageParams != null && this.template.getSaveImageParameters().getSaveImage()
-                        && saveImageParams.getSaveImage() && !hadProblemsInBuild && !hadUnknownBuildOutcome) {
+                        && saveImageParams.getSaveImage() && !hadProblemsInBuild) {
                     LOGGER.log(Level.INFO, AnkaLog.prefix("Node {0} Instance {1}, saving image"), new Object[]{getNodeName(), instanceId});
 
                     synchronized (this) {
@@ -202,10 +201,6 @@ public void setHadErrorsOnBuild(boolean value) {
         this.hadProblemsInBuild = value;
     }
 
-    public void setHadUnknownBuildOutcome(boolean value) {
-        this.hadUnknownBuildOutcome = value;
-    }
-
     public void setDescription(String jobAndNumber) {
         StringBuilder description = new StringBuilder();
         description.append(String.format("master image: %s,\n job name and build number: %s,\n",
@@ -305,7 +300,7 @@ public boolean isSchedulingOrPulling() {
     public void taskCompleted(Executor executor, Queue.Task task, long durationMS) {
         this.setTaskExecuted(true);
         SaveImageParameters saveImageParams = template.getSaveImageParameters();
-        if (!hadProblemsInBuild && !hadUnknownBuildOutcome && saveImageParams != null
+        if (!hadProblemsInBuild && saveImageParams != null
                 && this.template.getSaveImageParameters().getSaveImage() &&
                 saveImageParams.getSaveImage()) {
             AnkaMgmtCloud.markFuture(cloud, this);

src/main/java/com/veertu/plugin/anka/AnkaCloudComputer.java

@@ -117,7 +117,6 @@ public void taskAccepted(Executor executor, Queue.Task task) {
         super.taskAccepted(executor, task);
         this.run = null;
         this.acceptedRunIdentity = null;
-        this.slave.setHadUnknownBuildOutcome(false);
         if (task instanceof ExecutorStepExecution.PlaceholderTask) {
             this.run = ((ExecutorStepExecution.PlaceholderTask) task).run();
             if (this.run != null ){
@@ -301,7 +300,6 @@ private Result resolveResult(Run<?, ?> completedRun) {
 
     private void applyBuildOutcome(BuildOutcome buildOutcome) {
         this.slave.setHadErrorsOnBuild(shouldMarkBuildAsErrorForKeepAlive(buildOutcome));
-        this.slave.setHadUnknownBuildOutcome(buildOutcome == BuildOutcome.UNKNOWN);
     }
 
     static BuildOutcome resolveBuildOutcome(Result result) {