Skip to content

Commit 74e888e

Browse files
authored
Merge pull request #663 from jglick/null-prefix
Tolerate null `S3BlobStoreConfig.prefix`
2 parents 2567c4c + ec3621a commit 74e888e

2 files changed

Lines changed: 5 additions & 2 deletions

File tree

src/main/java/io/jenkins/plugins/artifact_manager_jclouds/s3/S3BlobStore.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@
5858
import com.google.common.base.Supplier;
5959

6060
import hudson.Extension;
61+
import hudson.Util;
6162
import io.jenkins.plugins.artifact_manager_jclouds.BlobStoreProvider;
6263
import io.jenkins.plugins.artifact_manager_jclouds.BlobStoreProviderDescriptor;
6364
import io.jenkins.plugins.aws.global_configuration.CredentialsAwsGlobalConfiguration;
@@ -91,7 +92,7 @@ public S3BlobStore() {
9192

9293
@Override
9394
public String getPrefix() {
94-
return getConfiguration().getPrefix();
95+
return Util.fixNull(getConfiguration().getPrefix());
9596
}
9697

9798
@Override

src/main/java/io/jenkins/plugins/artifact_manager_jclouds/s3/S3BlobStoreConfig.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
import org.kohsuke.stapler.interceptor.RequirePOST;
3838

3939
import com.google.common.annotations.VisibleForTesting;
40+
import edu.umd.cs.findbugs.annotations.CheckForNull;
4041

4142
import edu.umd.cs.findbugs.annotations.NonNull;
4243
import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
@@ -174,13 +175,14 @@ public void setContainer(String container) {
174175
save();
175176
}
176177

178+
@CheckForNull
177179
public String getPrefix() {
178180
return prefix;
179181
}
180182

181183
@DataBoundSetter
182184
public void setPrefix(String prefix){
183-
this.prefix = prefix;
185+
this.prefix = Util.fixEmptyAndTrim(prefix);
184186
checkValue(doCheckPrefix(prefix));
185187
save();
186188
}

0 commit comments

Comments
 (0)