Fix includes for badges and summary in experimental views (#351)

* Fix include pages for badges and summaries

* Only create detail and tab if there is something to display

Author: strangelookingnerd

src/main/java/com/jenkinsci/plugins/badge/detail/BadgeDetail.java

@@ -72,7 +72,12 @@ public Class<Run> type() {
         @NonNull
         @Override
         public List<? extends Detail> createFor(@NonNull Run target) {
-            return List.of(new BadgeDetail(target));
+            BadgeDetail detail = new BadgeDetail(target);
+            if (detail.getActions().isEmpty()) {
+                return List.of();
+            } else {
+                return List.of(detail);
+            }
         }
     }
 }

src/main/java/com/jenkinsci/plugins/badge/tab/SummaryTab.java

@@ -28,7 +28,6 @@
 import hudson.Extension;
 import hudson.model.Run;
 import java.util.Collection;
-import java.util.Collections;
 import java.util.List;
 import jenkins.model.Tab;
 import jenkins.model.TransientActionFactory;
@@ -77,7 +76,12 @@ public Class<Run> type() {
         @NonNull
         @Override
         public Collection<SummaryTab> createFor(@NonNull Run target) {
-            return Collections.singleton(new SummaryTab(target));
+            SummaryTab tab = new SummaryTab(target);
+            if (tab.getActions().isEmpty()) {
+                return List.of();
+            } else {
+                return List.of(tab);
+            }
         }
     }
 }

src/main/resources/com/jenkinsci/plugins/badge/detail/BadgeDetail/detail.jelly

@@ -26,6 +26,6 @@ THE SOFTWARE.
 <?jelly escape-by-default='true'?>
 <j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler">
   <j:forEach var="action" items="${it.actions}">
-    <st:include page="../../action/BadgeAction/badge.jelly" it="${action}"/>
+    <st:include page="/com/jenkinsci/plugins/badge/action/BadgeAction/badge.jelly" it="${action}" />
   </j:forEach>
 </j:jelly>

src/main/resources/com/jenkinsci/plugins/badge/tab/SummaryTab/widget.jelly

@@ -29,7 +29,7 @@ THE SOFTWARE.
     <div>
       <table>
         <j:forEach var="action" items="${it.actions}">
-          <st:include page="../../action/BadgeSummaryAction/summary-entry.jelly" it="${action}" optional="true"/>
+          <st:include page="/com/jenkinsci/plugins/badge/action/BadgeSummaryAction/summary-entry.jelly" it="${action}" />
         </j:forEach>
       </table>
     </div>