diff --git a/acceptance-tests/runner/runtime/src/main/java/io/jenkins/blueocean/BlueOceanWinstoneController.java b/acceptance-tests/runner/runtime/src/main/java/io/jenkins/blueocean/BlueOceanWinstoneController.java index 71669cefc5c..603b08ff6fe 100644 --- a/acceptance-tests/runner/runtime/src/main/java/io/jenkins/blueocean/BlueOceanWinstoneController.java +++ b/acceptance-tests/runner/runtime/src/main/java/io/jenkins/blueocean/BlueOceanWinstoneController.java @@ -26,7 +26,7 @@ import com.cloudbees.sdk.extensibility.Extension; import com.google.common.base.Splitter; import com.google.inject.Injector; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.jenkinsci.test.acceptance.controller.JenkinsController; import org.jenkinsci.test.acceptance.controller.LocalController; import org.jenkinsci.utils.process.CommandBuilder; diff --git a/acceptance-tests/src/test/java/io/blueocean/ath/offline/pipeline/DownstreamLinkTest.java b/acceptance-tests/src/test/java/io/blueocean/ath/offline/pipeline/DownstreamLinkTest.java index b4e431f6a73..8456a51260a 100644 --- a/acceptance-tests/src/test/java/io/blueocean/ath/offline/pipeline/DownstreamLinkTest.java +++ b/acceptance-tests/src/test/java/io/blueocean/ath/offline/pipeline/DownstreamLinkTest.java @@ -16,7 +16,7 @@ import java.util.List; import org.apache.commons.io.IOUtils; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.junit.Ignore; import org.junit.Rule; import org.junit.Test; diff --git a/acceptance-tests/src/test/java/io/jenkins/blueocean/util/HttpRequest.java b/acceptance-tests/src/test/java/io/jenkins/blueocean/util/HttpRequest.java index 9bca23a5e29..c3717a6b89f 100644 --- a/acceptance-tests/src/test/java/io/jenkins/blueocean/util/HttpRequest.java +++ b/acceptance-tests/src/test/java/io/jenkins/blueocean/util/HttpRequest.java @@ -2,7 +2,7 @@ import com.damnhandy.uri.template.UriTemplate; import io.jenkins.blueocean.commons.JsonConverter; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.apache.http.HttpResponse; import org.apache.http.client.HttpResponseException; import org.apache.http.client.fluent.Content; diff --git a/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/AbstractBitbucketScm.java b/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/AbstractBitbucketScm.java index 46e949fd4da..ef0fcd94500 100644 --- a/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/AbstractBitbucketScm.java +++ b/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/AbstractBitbucketScm.java @@ -17,7 +17,7 @@ import io.jenkins.blueocean.rest.model.Container; import io.jenkins.blueocean.rest.pageable.PagedResponse; import net.sf.json.JSONObject; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.kohsuke.accmod.Restricted; import org.kohsuke.accmod.restrictions.NoExternalUse; import org.kohsuke.stapler.HttpResponse; diff --git a/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/AbstractBitbucketScmContentProvider.java b/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/AbstractBitbucketScmContentProvider.java index 97b10e8fe9d..c3791738bfa 100644 --- a/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/AbstractBitbucketScmContentProvider.java +++ b/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/AbstractBitbucketScmContentProvider.java @@ -23,7 +23,7 @@ import jenkins.scm.api.SCMSource; import net.sf.json.JSONObject; import org.apache.commons.io.IOUtils; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.kohsuke.stapler.Stapler; import org.kohsuke.stapler.StaplerRequest2; diff --git a/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/BitbucketCredentialUtils.java b/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/BitbucketCredentialUtils.java index a7f6607397c..b4524b2baaa 100644 --- a/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/BitbucketCredentialUtils.java +++ b/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/BitbucketCredentialUtils.java @@ -3,7 +3,7 @@ import io.jenkins.blueocean.blueocean_bitbucket_pipeline.cloud.BitbucketCloudScm; import io.jenkins.blueocean.blueocean_bitbucket_pipeline.server.BitbucketServerScm; import io.jenkins.blueocean.commons.DigestUtils; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; /** * @author cliffmeyers diff --git a/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/BitbucketPipelineCreateRequest.java b/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/BitbucketPipelineCreateRequest.java index ae1d164fae4..72b3bbb3b3b 100644 --- a/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/BitbucketPipelineCreateRequest.java +++ b/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/BitbucketPipelineCreateRequest.java @@ -28,7 +28,7 @@ import jenkins.scm.api.SCMSource; import jenkins.scm.api.SCMSourceOwner; import jenkins.scm.api.mixin.ChangeRequestCheckoutStrategy; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.kohsuke.stapler.DataBoundConstructor; import org.slf4j.Logger; import org.slf4j.LoggerFactory; diff --git a/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/BitbucketRepositoryContainer.java b/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/BitbucketRepositoryContainer.java index b670360a33a..e1d12892456 100644 --- a/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/BitbucketRepositoryContainer.java +++ b/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/BitbucketRepositoryContainer.java @@ -9,7 +9,7 @@ import io.jenkins.blueocean.rest.impl.pipeline.scm.ScmRepositories; import io.jenkins.blueocean.rest.impl.pipeline.scm.ScmRepository; import io.jenkins.blueocean.rest.impl.pipeline.scm.ScmRepositoryContainer; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.kohsuke.stapler.Stapler; import org.kohsuke.stapler.StaplerRequest2; import org.kohsuke.stapler.export.Exported; diff --git a/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/HttpRequest.java b/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/HttpRequest.java index 1460aa0e11d..1a7f288e1fe 100644 --- a/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/HttpRequest.java +++ b/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/HttpRequest.java @@ -7,7 +7,7 @@ import hudson.util.Secret; import io.jenkins.blueocean.commons.ServiceException; import jenkins.model.Jenkins; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.apache.http.HttpEntity; import org.apache.http.HttpHost; import org.apache.http.client.HttpClient; diff --git a/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/HttpResponse.java b/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/HttpResponse.java index bb0c20e80a1..4e935874be6 100644 --- a/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/HttpResponse.java +++ b/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/HttpResponse.java @@ -5,7 +5,7 @@ import net.sf.json.JSONArray; import net.sf.json.JSONObject; import org.apache.commons.io.IOUtils; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.apache.http.HttpEntity; import org.apache.http.util.EntityUtils; import org.kohsuke.accmod.Restricted; diff --git a/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/cloud/BitbucketCloudApi.java b/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/cloud/BitbucketCloudApi.java index 274e1ab8493..bfa59ccdf99 100644 --- a/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/cloud/BitbucketCloudApi.java +++ b/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/cloud/BitbucketCloudApi.java @@ -21,7 +21,7 @@ import io.jenkins.blueocean.commons.ServiceException; import io.jenkins.blueocean.rest.pageable.PagedResponse; import org.apache.commons.io.IOUtils; -import org.apache.commons.lang.NotImplementedException; +import org.apache.commons.lang3.NotImplementedException; import org.apache.http.HttpEntity; import org.apache.http.entity.mime.MultipartEntityBuilder; @@ -38,7 +38,7 @@ import java.util.logging.Logger; import static io.jenkins.blueocean.commons.JsonConverter.om; -import static org.apache.commons.lang.StringUtils.isNotBlank; +import static org.apache.commons.lang3.StringUtils.isNotBlank; /** * @author Vivek Pandey diff --git a/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/cloud/model/BbCloudTeam.java b/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/cloud/model/BbCloudTeam.java index 18df5161270..e55389b92e0 100644 --- a/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/cloud/model/BbCloudTeam.java +++ b/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/cloud/model/BbCloudTeam.java @@ -3,7 +3,7 @@ import com.fasterxml.jackson.annotation.JsonCreator; import com.fasterxml.jackson.annotation.JsonProperty; import io.jenkins.blueocean.blueocean_bitbucket_pipeline.model.BbOrg; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import edu.umd.cs.findbugs.annotations.NonNull; import java.util.Map; diff --git a/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/server/BitbucketServerApi.java b/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/server/BitbucketServerApi.java index 27f7dc875c8..d14ded24259 100644 --- a/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/server/BitbucketServerApi.java +++ b/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/server/BitbucketServerApi.java @@ -34,7 +34,7 @@ import edu.umd.cs.findbugs.annotations.CheckForNull; import edu.umd.cs.findbugs.annotations.NonNull; import edu.umd.cs.findbugs.annotations.Nullable; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.apache.http.HttpEntity; import org.apache.http.client.utils.URIBuilder; import org.apache.http.entity.ByteArrayEntity; @@ -205,7 +205,7 @@ BbSaveContentResponse saveContent(@NonNull String projectKey, if(StringUtils.isNotBlank(sourceBranch)){ builder.addTextBody("sourceBranch", sourceBranch); } - if(org.apache.commons.lang.StringUtils.isNotBlank(commitId)){ + if(org.apache.commons.lang3.StringUtils.isNotBlank(commitId)){ builder.addTextBody("sourceCommitId", commitId); } HttpEntity entity = builder.build(); diff --git a/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/server/BitbucketServerEndpoint.java b/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/server/BitbucketServerEndpoint.java index a20a388fd33..999074fcd5b 100644 --- a/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/server/BitbucketServerEndpoint.java +++ b/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/server/BitbucketServerEndpoint.java @@ -8,7 +8,7 @@ import io.jenkins.blueocean.rest.Reachable; import io.jenkins.blueocean.rest.hal.Link; import io.jenkins.blueocean.rest.impl.pipeline.scm.ScmServerEndpoint; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.kohsuke.stapler.HttpResponse; import org.kohsuke.stapler.StaplerRequest2; import org.kohsuke.stapler.StaplerResponse2; diff --git a/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/server/BitbucketServerEndpointContainer.java b/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/server/BitbucketServerEndpointContainer.java index 78ff1132d56..a98ff2245e2 100644 --- a/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/server/BitbucketServerEndpointContainer.java +++ b/blueocean-bitbucket-pipeline/src/main/java/io/jenkins/blueocean/blueocean_bitbucket_pipeline/server/BitbucketServerEndpointContainer.java @@ -16,7 +16,7 @@ import io.jenkins.blueocean.rest.impl.pipeline.scm.ScmServerEndpointContainer; import jenkins.model.Jenkins; import net.sf.json.JSONObject; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.slf4j.Logger; import org.slf4j.LoggerFactory; diff --git a/blueocean-commons/pom.xml b/blueocean-commons/pom.xml index e3be8ac2779..ee24e13ee80 100644 --- a/blueocean-commons/pom.xml +++ b/blueocean-commons/pom.xml @@ -23,6 +23,10 @@ io.jenkins.plugins commons-lang3-api + + io.jenkins.plugins + commons-text-api + diff --git a/blueocean-commons/src/main/java/io/jenkins/blueocean/commons/stapler/export/JSONDataWriter.java b/blueocean-commons/src/main/java/io/jenkins/blueocean/commons/stapler/export/JSONDataWriter.java index 713c59272b8..5609e86a752 100644 --- a/blueocean-commons/src/main/java/io/jenkins/blueocean/commons/stapler/export/JSONDataWriter.java +++ b/blueocean-commons/src/main/java/io/jenkins/blueocean/commons/stapler/export/JSONDataWriter.java @@ -25,7 +25,7 @@ import com.fasterxml.jackson.core.io.JsonStringEncoder; import edu.umd.cs.findbugs.annotations.NonNull; -import org.apache.commons.lang.StringEscapeUtils; +import org.apache.commons.text.StringEscapeUtils; import java.io.IOException; import java.io.Writer; @@ -112,7 +112,7 @@ public void value(String v) throws IOException { buf.append('\"'); // TODO: remove when JENKINS-45099 has been fixed correctly in upstream stapler if (config.isHtmlEncode()) { - jsonEncoder.quoteAsString(StringEscapeUtils.escapeHtml(v), buf); + jsonEncoder.quoteAsString(StringEscapeUtils.escapeHtml4(v), buf); } else { jsonEncoder.quoteAsString(v, buf); } diff --git a/blueocean-events/src/main/java/io/jenkins/blueocean/events/BlueMessageEnricher.java b/blueocean-events/src/main/java/io/jenkins/blueocean/events/BlueMessageEnricher.java index 243479cdef6..77eb7e5c82a 100644 --- a/blueocean-events/src/main/java/io/jenkins/blueocean/events/BlueMessageEnricher.java +++ b/blueocean-events/src/main/java/io/jenkins/blueocean/events/BlueMessageEnricher.java @@ -35,7 +35,7 @@ import io.jenkins.blueocean.service.embedded.rest.AbstractPipelineImpl; import io.jenkins.blueocean.service.embedded.rest.QueueUtil; import jenkins.model.Jenkins; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.jenkinsci.plugins.pubsub.EventProps; import org.jenkinsci.plugins.pubsub.Events; import org.jenkinsci.plugins.pubsub.JobChannelMessage; diff --git a/blueocean-git-pipeline/src/main/java/io/jenkins/blueocean/blueocean_git_pipeline/GitPipelineCreateRequest.java b/blueocean-git-pipeline/src/main/java/io/jenkins/blueocean/blueocean_git_pipeline/GitPipelineCreateRequest.java index 9a47918b259..cf43f2ca285 100644 --- a/blueocean-git-pipeline/src/main/java/io/jenkins/blueocean/blueocean_git_pipeline/GitPipelineCreateRequest.java +++ b/blueocean-git-pipeline/src/main/java/io/jenkins/blueocean/blueocean_git_pipeline/GitPipelineCreateRequest.java @@ -14,7 +14,7 @@ import jenkins.plugins.git.traits.LocalBranchTrait; import jenkins.scm.api.SCMSource; import jenkins.scm.api.trait.SCMSourceTrait; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.kohsuke.stapler.DataBoundConstructor; import edu.umd.cs.findbugs.annotations.NonNull; diff --git a/blueocean-git-pipeline/src/main/java/io/jenkins/blueocean/blueocean_git_pipeline/GitReadSaveService.java b/blueocean-git-pipeline/src/main/java/io/jenkins/blueocean/blueocean_git_pipeline/GitReadSaveService.java index 51f937cfe20..7b59316a25e 100644 --- a/blueocean-git-pipeline/src/main/java/io/jenkins/blueocean/blueocean_git_pipeline/GitReadSaveService.java +++ b/blueocean-git-pipeline/src/main/java/io/jenkins/blueocean/blueocean_git_pipeline/GitReadSaveService.java @@ -56,7 +56,7 @@ import jenkins.scm.api.SCMSource; import net.sf.json.JSONObject; import org.apache.commons.io.IOUtils; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.apache.commons.lang3.ObjectUtils; import org.kohsuke.stapler.StaplerRequest2; import org.slf4j.Logger; diff --git a/blueocean-git-pipeline/src/main/java/io/jenkins/blueocean/blueocean_git_pipeline/GitUtils.java b/blueocean-git-pipeline/src/main/java/io/jenkins/blueocean/blueocean_git_pipeline/GitUtils.java index 78c920a4c67..2c515f6a92a 100644 --- a/blueocean-git-pipeline/src/main/java/io/jenkins/blueocean/blueocean_git_pipeline/GitUtils.java +++ b/blueocean-git-pipeline/src/main/java/io/jenkins/blueocean/blueocean_git_pipeline/GitUtils.java @@ -18,7 +18,7 @@ import io.jenkins.blueocean.commons.ServiceException; import io.jenkins.blueocean.credential.CredentialsUtils; import io.jenkins.blueocean.rest.impl.pipeline.credential.BlueOceanDomainRequirement; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.eclipse.jgit.api.CheckoutCommand; import org.eclipse.jgit.api.FetchCommand; import org.eclipse.jgit.api.MergeCommand; diff --git a/blueocean-git-pipeline/src/main/java/io/jenkins/blueocean/ssh/UserPublicKeyRoute.java b/blueocean-git-pipeline/src/main/java/io/jenkins/blueocean/ssh/UserPublicKeyRoute.java index 77165dfcfdf..6a54776ea81 100644 --- a/blueocean-git-pipeline/src/main/java/io/jenkins/blueocean/ssh/UserPublicKeyRoute.java +++ b/blueocean-git-pipeline/src/main/java/io/jenkins/blueocean/ssh/UserPublicKeyRoute.java @@ -6,7 +6,7 @@ import io.jenkins.blueocean.commons.stapler.TreeResponse; import io.jenkins.blueocean.rest.UserRoute; import io.jenkins.blueocean.rest.model.BlueUser; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.kohsuke.stapler.WebMethod; import org.kohsuke.stapler.verb.DELETE; import org.kohsuke.stapler.verb.GET; diff --git a/blueocean-github-pipeline/src/main/java/io/jenkins/blueocean/blueocean_github_pipeline/GithubCredentialUtils.java b/blueocean-github-pipeline/src/main/java/io/jenkins/blueocean/blueocean_github_pipeline/GithubCredentialUtils.java index 464ebb6c878..30ee42a3a54 100644 --- a/blueocean-github-pipeline/src/main/java/io/jenkins/blueocean/blueocean_github_pipeline/GithubCredentialUtils.java +++ b/blueocean-github-pipeline/src/main/java/io/jenkins/blueocean/blueocean_github_pipeline/GithubCredentialUtils.java @@ -1,7 +1,7 @@ package io.jenkins.blueocean.blueocean_github_pipeline; import io.jenkins.blueocean.commons.DigestUtils; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; /** * @author cliffmeyers diff --git a/blueocean-github-pipeline/src/main/java/io/jenkins/blueocean/blueocean_github_pipeline/GithubScmContentProvider.java b/blueocean-github-pipeline/src/main/java/io/jenkins/blueocean/blueocean_github_pipeline/GithubScmContentProvider.java index ec488f163b2..02ceec4f636 100644 --- a/blueocean-github-pipeline/src/main/java/io/jenkins/blueocean/blueocean_github_pipeline/GithubScmContentProvider.java +++ b/blueocean-github-pipeline/src/main/java/io/jenkins/blueocean/blueocean_github_pipeline/GithubScmContentProvider.java @@ -18,7 +18,7 @@ import jenkins.scm.api.SCMSource; import net.sf.json.JSONObject; import org.apache.commons.io.IOUtils; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.jenkinsci.plugins.github_branch_source.GitHubSCMNavigator; import org.jenkinsci.plugins.github_branch_source.GitHubSCMSource; import org.kohsuke.stapler.Stapler; diff --git a/blueocean-github-pipeline/src/test/java/io/jenkins/blueocean/blueocean_github_pipeline/GithubTestUtils.java b/blueocean-github-pipeline/src/test/java/io/jenkins/blueocean/blueocean_github_pipeline/GithubTestUtils.java index 53a12096c09..b8bd7a9ec88 100644 --- a/blueocean-github-pipeline/src/test/java/io/jenkins/blueocean/blueocean_github_pipeline/GithubTestUtils.java +++ b/blueocean-github-pipeline/src/test/java/io/jenkins/blueocean/blueocean_github_pipeline/GithubTestUtils.java @@ -1,7 +1,7 @@ package io.jenkins.blueocean.blueocean_github_pipeline; import io.jenkins.blueocean.commons.MapsHelper; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import java.util.Map; diff --git a/blueocean-jwt/src/main/java/io/jenkins/blueocean/auth/jwt/impl/JwtAuthenticationFilter.java b/blueocean-jwt/src/main/java/io/jenkins/blueocean/auth/jwt/impl/JwtAuthenticationFilter.java index 1ef343dd4fb..7f039d617cc 100644 --- a/blueocean-jwt/src/main/java/io/jenkins/blueocean/auth/jwt/impl/JwtAuthenticationFilter.java +++ b/blueocean-jwt/src/main/java/io/jenkins/blueocean/auth/jwt/impl/JwtAuthenticationFilter.java @@ -6,7 +6,7 @@ import hudson.security.ACLContext; import hudson.util.PluginServletFilter; import io.jenkins.blueocean.auth.jwt.JwtTokenVerifier; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.kohsuke.stapler.Stapler; import org.springframework.security.core.Authentication; diff --git a/blueocean-pipeline-api-impl/src/main/java/io/jenkins/blueocean/rest/impl/pipeline/MultibranchPipelineRunContainer.java b/blueocean-pipeline-api-impl/src/main/java/io/jenkins/blueocean/rest/impl/pipeline/MultibranchPipelineRunContainer.java index a588e6f6b13..0f6a3b403b7 100644 --- a/blueocean-pipeline-api-impl/src/main/java/io/jenkins/blueocean/rest/impl/pipeline/MultibranchPipelineRunContainer.java +++ b/blueocean-pipeline-api-impl/src/main/java/io/jenkins/blueocean/rest/impl/pipeline/MultibranchPipelineRunContainer.java @@ -11,7 +11,7 @@ import io.jenkins.blueocean.rest.model.BlueRun; import io.jenkins.blueocean.rest.model.BlueRunContainer; import io.jenkins.blueocean.service.embedded.rest.QueueItemImpl; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.kohsuke.stapler.Stapler; import org.kohsuke.stapler.StaplerRequest2; diff --git a/blueocean-pipeline-api-impl/src/main/java/io/jenkins/blueocean/rest/impl/pipeline/scm/AbstractScmContentProvider.java b/blueocean-pipeline-api-impl/src/main/java/io/jenkins/blueocean/rest/impl/pipeline/scm/AbstractScmContentProvider.java index 2c418c5bf77..d2ebc645f08 100644 --- a/blueocean-pipeline-api-impl/src/main/java/io/jenkins/blueocean/rest/impl/pipeline/scm/AbstractScmContentProvider.java +++ b/blueocean-pipeline-api-impl/src/main/java/io/jenkins/blueocean/rest/impl/pipeline/scm/AbstractScmContentProvider.java @@ -6,7 +6,7 @@ import io.jenkins.blueocean.commons.ServiceException; import io.jenkins.blueocean.rest.impl.pipeline.ScmContentProvider; import jenkins.branch.MultiBranchProject; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.kohsuke.stapler.StaplerRequest2; import edu.umd.cs.findbugs.annotations.NonNull; diff --git a/blueocean-pipeline-api-impl/src/test/java/io/jenkins/blueocean/rest/impl/pipeline/MultiBranchTest.java b/blueocean-pipeline-api-impl/src/test/java/io/jenkins/blueocean/rest/impl/pipeline/MultiBranchTest.java index 168117f90e7..e95774b9180 100644 --- a/blueocean-pipeline-api-impl/src/test/java/io/jenkins/blueocean/rest/impl/pipeline/MultiBranchTest.java +++ b/blueocean-pipeline-api-impl/src/test/java/io/jenkins/blueocean/rest/impl/pipeline/MultiBranchTest.java @@ -21,7 +21,7 @@ import jenkins.plugins.git.GitSCMSource; import jenkins.plugins.git.GitSampleRepoRule; import jenkins.scm.api.SCMSource; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.hamcrest.collection.IsArrayContainingInAnyOrder; import org.jenkinsci.plugins.scriptsecurity.scripts.ScriptApproval; import org.jenkinsci.plugins.workflow.job.WorkflowJob; diff --git a/blueocean-pipeline-api-impl/src/test/java/io/jenkins/blueocean/rest/impl/pipeline/PipelineBaseTest.java b/blueocean-pipeline-api-impl/src/test/java/io/jenkins/blueocean/rest/impl/pipeline/PipelineBaseTest.java index 3fa6bead95b..2cb818c3021 100644 --- a/blueocean-pipeline-api-impl/src/test/java/io/jenkins/blueocean/rest/impl/pipeline/PipelineBaseTest.java +++ b/blueocean-pipeline-api-impl/src/test/java/io/jenkins/blueocean/rest/impl/pipeline/PipelineBaseTest.java @@ -19,7 +19,7 @@ import org.acegisecurity.providers.UsernamePasswordAuthenticationToken; import org.acegisecurity.userdetails.UserDetails; import org.apache.commons.io.IOUtils; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.jenkinsci.plugins.workflow.actions.ThreadNameAction; import org.jenkinsci.plugins.workflow.cps.CpsFlowDefinition; import org.jenkinsci.plugins.workflow.graph.FlowNode; diff --git a/blueocean-pipeline-scm-api/src/main/java/io/jenkins/blueocean/credential/CredentialsUtils.java b/blueocean-pipeline-scm-api/src/main/java/io/jenkins/blueocean/credential/CredentialsUtils.java index 9d5f1ab54a9..0eecd29f7b9 100644 --- a/blueocean-pipeline-scm-api/src/main/java/io/jenkins/blueocean/credential/CredentialsUtils.java +++ b/blueocean-pipeline-scm-api/src/main/java/io/jenkins/blueocean/credential/CredentialsUtils.java @@ -15,7 +15,7 @@ import hudson.model.User; import io.jenkins.blueocean.commons.ServiceException; import jenkins.model.Jenkins; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import edu.umd.cs.findbugs.annotations.CheckForNull; import edu.umd.cs.findbugs.annotations.NonNull; diff --git a/blueocean-pipeline-scm-api/src/main/java/io/jenkins/blueocean/scm/api/AbstractMultiBranchCreateRequest.java b/blueocean-pipeline-scm-api/src/main/java/io/jenkins/blueocean/scm/api/AbstractMultiBranchCreateRequest.java index 72f35ede8fd..8452f2679df 100644 --- a/blueocean-pipeline-scm-api/src/main/java/io/jenkins/blueocean/scm/api/AbstractMultiBranchCreateRequest.java +++ b/blueocean-pipeline-scm-api/src/main/java/io/jenkins/blueocean/scm/api/AbstractMultiBranchCreateRequest.java @@ -33,7 +33,7 @@ import jenkins.scm.api.SCMSource; import jenkins.scm.api.SCMSourceCriteria; import jenkins.scm.api.SCMSourceEvent; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.jenkinsci.plugins.pubsub.MessageException; import org.jenkinsci.plugins.pubsub.PubsubBus; import org.jenkinsci.plugins.pubsub.SimpleMessage; diff --git a/blueocean-rest-impl/src/main/java/io/jenkins/blueocean/service/embedded/OrganizationFactoryImpl.java b/blueocean-rest-impl/src/main/java/io/jenkins/blueocean/service/embedded/OrganizationFactoryImpl.java index 721c62a7bbe..9a40d738a61 100644 --- a/blueocean-rest-impl/src/main/java/io/jenkins/blueocean/service/embedded/OrganizationFactoryImpl.java +++ b/blueocean-rest-impl/src/main/java/io/jenkins/blueocean/service/embedded/OrganizationFactoryImpl.java @@ -7,11 +7,10 @@ import io.jenkins.blueocean.service.embedded.rest.OrganizationImpl; import jenkins.model.Jenkins; import jenkins.model.ModifiableTopLevelItemGroup; -import org.apache.commons.lang.StringUtils; +import jenkins.util.SystemProperties; import java.util.Collection; import java.util.Collections; -import java.util.logging.Level; import java.util.logging.Logger; /** @@ -22,8 +21,7 @@ */ @Extension(ordinal=-100) // low ordinal to ensure this comes in the very last public class OrganizationFactoryImpl extends OrganizationFactory { - private static final String ORGANIZATION_NAME = StringUtils.defaultIfBlank( - System.getProperty("BLUE_ORGANIZATION_NAME"),"jenkins"); + private static final String ORGANIZATION_NAME = SystemProperties.getString("BLUE_ORGANIZATION_NAME","jenkins"); private static final String ROOT_FOLDER_NAME = System.getProperty("BLUE_ORGANIZATION_ROOT_FOLDER"); diff --git a/blueocean-rest-impl/src/main/java/io/jenkins/blueocean/service/embedded/analytics/AbstractAnalytics.java b/blueocean-rest-impl/src/main/java/io/jenkins/blueocean/service/embedded/analytics/AbstractAnalytics.java index 25f0790692b..4765ab38aac 100644 --- a/blueocean-rest-impl/src/main/java/io/jenkins/blueocean/service/embedded/analytics/AbstractAnalytics.java +++ b/blueocean-rest-impl/src/main/java/io/jenkins/blueocean/service/embedded/analytics/AbstractAnalytics.java @@ -7,7 +7,7 @@ import io.jenkins.blueocean.analytics.Analytics; import io.jenkins.blueocean.commons.DigestUtils; import io.jenkins.blueocean.commons.ServiceException; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.kohsuke.accmod.Restricted; import org.kohsuke.accmod.restrictions.NoExternalUse; import org.kohsuke.stapler.Stapler; diff --git a/blueocean-rest-impl/src/main/java/io/jenkins/blueocean/service/embedded/rest/AbstractRunImpl.java b/blueocean-rest-impl/src/main/java/io/jenkins/blueocean/service/embedded/rest/AbstractRunImpl.java index 3e2e3f19a19..df4701ab0d2 100644 --- a/blueocean-rest-impl/src/main/java/io/jenkins/blueocean/service/embedded/rest/AbstractRunImpl.java +++ b/blueocean-rest-impl/src/main/java/io/jenkins/blueocean/service/embedded/rest/AbstractRunImpl.java @@ -10,7 +10,7 @@ import com.github.benmanes.caffeine.cache.Cache; import com.github.benmanes.caffeine.cache.Caffeine; -import org.apache.commons.lang.BooleanUtils; +import org.apache.commons.lang3.BooleanUtils; import org.kohsuke.stapler.QueryParameter; import org.kohsuke.stapler.export.Exported; import org.slf4j.Logger; diff --git a/blueocean-rest-impl/src/main/java/io/jenkins/blueocean/service/embedded/rest/ActionProxiesImpl.java b/blueocean-rest-impl/src/main/java/io/jenkins/blueocean/service/embedded/rest/ActionProxiesImpl.java index 16b5746edd5..067f9048059 100644 --- a/blueocean-rest-impl/src/main/java/io/jenkins/blueocean/service/embedded/rest/ActionProxiesImpl.java +++ b/blueocean-rest-impl/src/main/java/io/jenkins/blueocean/service/embedded/rest/ActionProxiesImpl.java @@ -4,7 +4,7 @@ import io.jenkins.blueocean.rest.Reachable; import io.jenkins.blueocean.rest.hal.Link; import io.jenkins.blueocean.rest.model.BlueActionProxy; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.kohsuke.stapler.Stapler; import org.kohsuke.stapler.export.ExportedBean; import org.slf4j.Logger; diff --git a/blueocean-rest-impl/src/main/java/io/jenkins/blueocean/service/embedded/rest/BlueTestResultContainerImpl.java b/blueocean-rest-impl/src/main/java/io/jenkins/blueocean/service/embedded/rest/BlueTestResultContainerImpl.java index 7b92f527e51..a8bd5fdf770 100644 --- a/blueocean-rest-impl/src/main/java/io/jenkins/blueocean/service/embedded/rest/BlueTestResultContainerImpl.java +++ b/blueocean-rest-impl/src/main/java/io/jenkins/blueocean/service/embedded/rest/BlueTestResultContainerImpl.java @@ -13,7 +13,7 @@ import io.jenkins.blueocean.rest.model.BlueTestResult.State; import io.jenkins.blueocean.rest.model.BlueTestResult.Status; import io.jenkins.blueocean.rest.model.BlueTestResultContainer; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.kohsuke.stapler.Stapler; import org.kohsuke.stapler.StaplerRequest2; @@ -21,7 +21,7 @@ import java.util.function.Predicate; import java.util.stream.StreamSupport; -import static org.apache.commons.lang.StringUtils.isEmpty; +import static org.apache.commons.lang3.StringUtils.isEmpty; public class BlueTestResultContainerImpl extends BlueTestResultContainer { protected final Run run; diff --git a/blueocean-rest-impl/src/main/java/io/jenkins/blueocean/service/embedded/rest/FavoriteContainerImpl.java b/blueocean-rest-impl/src/main/java/io/jenkins/blueocean/service/embedded/rest/FavoriteContainerImpl.java index 49a81adf54e..d564299d0e8 100644 --- a/blueocean-rest-impl/src/main/java/io/jenkins/blueocean/service/embedded/rest/FavoriteContainerImpl.java +++ b/blueocean-rest-impl/src/main/java/io/jenkins/blueocean/service/embedded/rest/FavoriteContainerImpl.java @@ -15,7 +15,7 @@ import java.util.List; import jakarta.servlet.http.HttpServletResponse; import jenkins.model.Jenkins; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.kohsuke.stapler.Stapler; import org.kohsuke.stapler.StaplerRequest2; import org.kohsuke.stapler.StaplerResponse2; diff --git a/blueocean-rest-impl/src/main/java/io/jenkins/blueocean/service/embedded/rest/UserImpl.java b/blueocean-rest-impl/src/main/java/io/jenkins/blueocean/service/embedded/rest/UserImpl.java index 688ad8c8d0a..a05d3b7f8c2 100644 --- a/blueocean-rest-impl/src/main/java/io/jenkins/blueocean/service/embedded/rest/UserImpl.java +++ b/blueocean-rest-impl/src/main/java/io/jenkins/blueocean/service/embedded/rest/UserImpl.java @@ -23,7 +23,7 @@ import jenkins.model.Jenkins; import jenkins.model.ModifiableTopLevelItemGroup; import org.springframework.security.core.Authentication; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import java.util.Collections; import java.util.Map; diff --git a/blueocean-rest-impl/src/main/java/io/jenkins/blueocean/service/embedded/rest/junit/BlueJUnitTestResult.java b/blueocean-rest-impl/src/main/java/io/jenkins/blueocean/service/embedded/rest/junit/BlueJUnitTestResult.java index a14852b948a..cb5de5b82ea 100644 --- a/blueocean-rest-impl/src/main/java/io/jenkins/blueocean/service/embedded/rest/junit/BlueJUnitTestResult.java +++ b/blueocean-rest-impl/src/main/java/io/jenkins/blueocean/service/embedded/rest/junit/BlueJUnitTestResult.java @@ -9,7 +9,7 @@ import io.jenkins.blueocean.rest.factory.BlueTestResultFactory; import io.jenkins.blueocean.rest.hal.Link; import io.jenkins.blueocean.rest.model.BlueTestResult; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.kohsuke.accmod.Restricted; import org.kohsuke.accmod.restrictions.NoExternalUse; @@ -17,7 +17,7 @@ import java.util.List; import java.util.stream.Collectors; -import static org.apache.commons.lang.StringUtils.isEmpty; +import static org.apache.commons.lang3.StringUtils.isEmpty; /** * TODO: move to junit plugin diff --git a/blueocean-rest-impl/src/test/java/io/jenkins/blueocean/service/embedded/rest/UserImplPermissionTest.java b/blueocean-rest-impl/src/test/java/io/jenkins/blueocean/service/embedded/rest/UserImplPermissionTest.java index 62d4e97db1e..dc77d39f38c 100644 --- a/blueocean-rest-impl/src/test/java/io/jenkins/blueocean/service/embedded/rest/UserImplPermissionTest.java +++ b/blueocean-rest-impl/src/test/java/io/jenkins/blueocean/service/embedded/rest/UserImplPermissionTest.java @@ -40,7 +40,7 @@ import org.springframework.security.access.AccessDeniedException; import org.springframework.security.core.Authentication; import org.springframework.security.core.GrantedAuthority; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.junit.After; import org.junit.Before; import org.junit.Test; diff --git a/blueocean-rest-impl/src/test/java/io/jenkins/blueocean/util/HttpRequest.java b/blueocean-rest-impl/src/test/java/io/jenkins/blueocean/util/HttpRequest.java index c909e924ace..e3befb6bc3f 100644 --- a/blueocean-rest-impl/src/test/java/io/jenkins/blueocean/util/HttpRequest.java +++ b/blueocean-rest-impl/src/test/java/io/jenkins/blueocean/util/HttpRequest.java @@ -2,7 +2,7 @@ import com.damnhandy.uri.template.UriTemplate; import io.jenkins.blueocean.commons.JsonConverter; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.apache.http.HttpResponse; import org.apache.http.client.HttpResponseException; import org.apache.http.client.fluent.Content; diff --git a/blueocean-rest/pom.xml b/blueocean-rest/pom.xml index b5d9fae22a3..8f368a497bb 100644 --- a/blueocean-rest/pom.xml +++ b/blueocean-rest/pom.xml @@ -28,14 +28,8 @@ + org.apache.maven.plugins maven-enforcer-plugin - - - de.skuzzle.enforcer - restrict-imports-enforcer-rule - 0.7.0 - - check-no-jenkins-imports @@ -46,7 +40,7 @@ - + ** jenkins.** @@ -60,13 +54,22 @@ hudson.security.csrf.CrumbExclusion hudson.util.AdaptedIterator hudson.Util + static hudson.Util.rawEncode + hudson.model.Action + hudson.model.Item + hudson.model.ItemGroup + hudson.model.Job + hudson.model.ModelObject + hudson.model.RootAction + hudson.model.Run + hudson.model.TopLevelItem + hudson.scm.ChangeLogSet + jenkins.model.Jenkins + jenkins.model.ModifiableTopLevelItemGroup - - io.jenkins.blueocean.rest.factory.** - - + - + io.jenkins.blueocean.rest.factory.** jenkins.** @@ -89,8 +92,8 @@ hudson.model.Job hudson.scm.ChangeLogSet - - + + io.jenkins.blueocean.rest.analytics.** jenkins.** @@ -101,7 +104,7 @@ hudson.ExtensionPoint hudson.ExtensionList - + diff --git a/blueocean-web/src/main/java/io/jenkins/blueocean/BlueOceanUI.java b/blueocean-web/src/main/java/io/jenkins/blueocean/BlueOceanUI.java index a1f263f5189..81ee311901c 100644 --- a/blueocean-web/src/main/java/io/jenkins/blueocean/BlueOceanUI.java +++ b/blueocean-web/src/main/java/io/jenkins/blueocean/BlueOceanUI.java @@ -5,7 +5,7 @@ import hudson.security.csrf.CrumbIssuer; import io.jenkins.blueocean.dev.RunBundleWatches; import jenkins.model.Jenkins; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.kohsuke.stapler.Stapler; import org.kohsuke.stapler.StaplerRequest2; import org.slf4j.Logger; diff --git a/blueocean-web/src/main/java/io/jenkins/blueocean/dev/RunBundleWatches.java b/blueocean-web/src/main/java/io/jenkins/blueocean/dev/RunBundleWatches.java index a853e35ac12..ee05b1b2caf 100644 --- a/blueocean-web/src/main/java/io/jenkins/blueocean/dev/RunBundleWatches.java +++ b/blueocean-web/src/main/java/io/jenkins/blueocean/dev/RunBundleWatches.java @@ -7,7 +7,7 @@ import jenkins.model.Jenkins; import net.sf.json.JSONObject; import org.apache.commons.io.FileUtils; -import org.apache.commons.lang.SystemUtils; +import org.apache.commons.lang3.SystemUtils; import java.io.BufferedReader; import java.io.File; diff --git a/blueocean/src/main/java/io/jenkins/blueocean/plugin/diagnosis/BlueOceanCredentialsMonitor.java b/blueocean/src/main/java/io/jenkins/blueocean/plugin/diagnosis/BlueOceanCredentialsMonitor.java index 4cdca7fb3f4..1ae25adea4b 100644 --- a/blueocean/src/main/java/io/jenkins/blueocean/plugin/diagnosis/BlueOceanCredentialsMonitor.java +++ b/blueocean/src/main/java/io/jenkins/blueocean/plugin/diagnosis/BlueOceanCredentialsMonitor.java @@ -20,7 +20,7 @@ import jenkins.scm.api.SCMSource; import jenkins.util.SystemProperties; import jenkins.util.Timer; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.jenkinsci.Symbol; import org.jenkinsci.plugins.workflow.multibranch.WorkflowMultiBranchProject; import org.kohsuke.accmod.Restricted; diff --git a/pom.xml b/pom.xml index 08c4b2cea64..64ed157a7b1 100644 --- a/pom.xml +++ b/pom.xml @@ -191,11 +191,11 @@ commons-codec provided - - commons-lang - commons-lang - provided - + + + + + org.mockito mockito-core @@ -523,10 +523,22 @@ ${access-modifier-checker.failOnError} + + org.apache.maven.plugins + maven-enforcer-plugin + + + de.skuzzle.enforcer + restrict-imports-enforcer-rule + 3.0.0 + + + + org.apache.maven.plugins maven-enforcer-plugin @@ -539,12 +551,28 @@ org.apache.commons:commons-lang3 + commons-lang:commons-lang false + + check-commons-lang + process-sources + + enforce + + + + + Use commons-lang 2 + org.apache.commons.lang.** + + + +