Migrate from Commons Lang 2 to Commons Lang 3 (#542)

Author: basil

pom.xml

@@ -101,6 +101,10 @@
       <groupId>io.jenkins.plugins</groupId>
       <artifactId>caffeine-api</artifactId>
     </dependency>
+    <dependency>
+      <groupId>io.jenkins.plugins</groupId>
+      <artifactId>commons-lang3-api</artifactId>
+    </dependency>
     <dependency>
       <groupId>io.jenkins.plugins</groupId>
       <artifactId>ionicons-api</artifactId>

src/main/java/jenkins/branch/BranchEventCause.java

@@ -32,7 +32,7 @@
 import hudson.model.Run;
 import java.util.Date;
 import jenkins.scm.api.SCMEvent;
-import org.apache.commons.lang.StringUtils;
+import org.apache.commons.lang3.StringUtils;
 import org.kohsuke.accmod.Restricted;
 import org.kohsuke.accmod.restrictions.DoNotUse;
 

src/main/java/jenkins/branch/DescriptionColumn.java

@@ -36,7 +36,7 @@
 import java.io.IOException;
 import jenkins.model.Jenkins;
 import jenkins.scm.api.metadata.ObjectMetadataAction;
-import org.apache.commons.lang.StringUtils;
+import org.apache.commons.lang3.StringUtils;
 import org.kohsuke.accmod.Restricted;
 import org.kohsuke.accmod.restrictions.NoExternalUse;
 import org.kohsuke.stapler.DataBoundConstructor;

src/main/java/jenkins/branch/ItemColumn.java

@@ -38,7 +38,7 @@
 import hudson.views.ListViewColumnDescriptor;
 import jenkins.scm.api.metadata.ObjectMetadataAction;
 import jenkins.scm.api.metadata.PrimaryInstanceMetadataAction;
-import org.apache.commons.lang.StringUtils;
+import org.apache.commons.lang3.StringUtils;
 import org.kohsuke.accmod.Restricted;
 import org.kohsuke.accmod.restrictions.NoExternalUse;
 import org.kohsuke.stapler.DataBoundConstructor;

src/main/java/jenkins/branch/MultiBranchProject.java

@@ -107,7 +107,7 @@
 import jenkins.util.SystemProperties;
 import net.sf.json.JSONObject;
 import org.apache.commons.io.FileUtils;
-import org.apache.commons.lang.StringUtils;
+import org.apache.commons.lang3.StringUtils;
 import org.jenkins.ui.icon.IconSpec;
 import org.kohsuke.accmod.Restricted;
 import org.kohsuke.accmod.restrictions.NoExternalUse;

src/main/java/jenkins/branch/MultiBranchProjectDisplayNamingStrategy.java

@@ -29,7 +29,7 @@
 import org.jvnet.localizer.Localizable;
 
 import static java.lang.String.format;
-import static org.apache.commons.lang.StringUtils.isBlank;
+import static org.apache.commons.lang3.StringUtils.isBlank;
 
 /**
  * Possible Display naming strategies.

src/main/java/jenkins/branch/NameMangler.java

@@ -27,7 +27,7 @@
 import java.security.MessageDigest;
 import java.security.NoSuchAlgorithmException;
 import java.util.Locale;
-import org.apache.commons.lang.StringUtils;
+import org.apache.commons.lang3.StringUtils;
 
 /**
  * Mangles names that are not nice so that they are safe to use on filesystem.

src/main/java/jenkins/branch/NamedExceptionsBranchPropertyStrategy.java

@@ -30,7 +30,7 @@
 import hudson.model.AbstractDescribableImpl;
 import hudson.model.Descriptor;
 import jenkins.scm.api.SCMHead;
-import org.apache.commons.lang.StringUtils;
+import org.apache.commons.lang3.StringUtils;
 import org.apache.tools.ant.types.selectors.SelectorUtils;
 import org.jenkinsci.Symbol;
 import org.kohsuke.stapler.DataBoundConstructor;

src/main/java/jenkins/branch/OrganizationFolder.java

@@ -95,7 +95,7 @@
 
 import java.nio.charset.StandardCharsets;
 import org.apache.commons.io.FileUtils;
-import org.apache.commons.lang.StringUtils;
+import org.apache.commons.lang3.StringUtils;
 import org.jenkins.ui.icon.Icon;
 import org.jenkins.ui.icon.IconSet;
 import org.jenkins.ui.icon.IconSpec;

src/main/java/jenkins/branch/WorkspaceLocatorImpl.java

@@ -84,7 +84,7 @@
 import jenkins.util.ErrorLoggingExecutorService;
 import jenkins.util.SystemProperties;
 import org.apache.commons.codec.binary.Base32;
-import org.apache.commons.lang.StringUtils;
+import org.apache.commons.lang3.StringUtils;
 import org.kohsuke.accmod.Restricted;
 import org.kohsuke.accmod.restrictions.NoExternalUse;