Remove ChildNameGenerator#recordLegacyName (#534)

Author: basil

pom.xml

@@ -69,8 +69,8 @@
     <changelist>999999-SNAPSHOT</changelist>
     <gitHubRepo>jenkinsci/${project.artifactId}-plugin</gitHubRepo>
     <!-- https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/ -->
-    <jenkins.baseline>2.479</jenkins.baseline>
-    <jenkins.version>${jenkins.baseline}.3</jenkins.version>
+    <jenkins.baseline>2.504</jenkins.baseline>
+    <jenkins.version>${jenkins.baseline}.1</jenkins.version>
 
     <hpi.compatibleSinceVersion>2.0.0</hpi.compatibleSinceVersion>
     <no-test-jar>false</no-test-jar>
@@ -85,6 +85,12 @@
         <type>pom</type>
         <scope>import</scope>
       </dependency>
+      <!-- TODO remove when in BOM -->
+      <dependency>
+        <groupId>org.jenkins-ci.plugins</groupId>
+        <artifactId>cloudbees-folder</artifactId>
+        <version>6.1034.v4159e5986617</version>
+      </dependency>
     </dependencies>
   </dependencyManagement>
   <dependencies>

src/main/java/jenkins/branch/MultiBranchProjectDescriptor.java

@@ -34,7 +34,6 @@
 import hudson.model.Run;
 import hudson.model.TopLevelItem;
 import hudson.model.TopLevelItemDescriptor;
-import java.io.IOException;
 import java.lang.reflect.ParameterizedType;
 import java.lang.reflect.Type;
 import java.util.ArrayList;
@@ -263,12 +262,5 @@ public String itemNameFromLegacy(@NonNull MultiBranchProject<P, R> parent, @NonN
         public String dirNameFromLegacy(@NonNull MultiBranchProject<P, R> parent, @NonNull String legacyDirName) {
             return NameMangler.apply(NameEncoder.decode(legacyDirName));
         }
-
-        // TODO remove after it is removed in cloudbees-folder
-        public void recordLegacyName(MultiBranchProject<P, R> parent, P item, String legacyDirName) throws IOException {
-            // no-op because we already tracked the name in Branch.getName()
-        }
-
     }
-
 }

src/main/java/jenkins/branch/OrganizationFolder.java

@@ -884,12 +884,6 @@ public String itemNameFromLegacy(@NonNull OrganizationFolder parent, @NonNull St
         public String dirNameFromLegacy(@NonNull OrganizationFolder parent, @NonNull String legacyDirName) {
             return NameMangler.apply(NameEncoder.decode(legacyDirName));
         }
-
-        // TODO remove after it is removed in cloudbees-folder
-        public void recordLegacyName(OrganizationFolder parent, MultiBranchProject<?, ?> item, String legacyDirName)
-                throws IOException {
-            item.addProperty(new ProjectNameProperty(legacyDirName));
-        }
     }
 
     /**