Remove ChildNameGenerator#recordLegacyName (#514)

Author: basil

src/main/java/com/cloudbees/hudson/plugins/folder/AbstractFolderDescriptor.java

@@ -237,10 +237,5 @@ public String itemNameFromLegacy(@NonNull AbstractFolder<I> parent, @NonNull Str
         public String dirNameFromLegacy(@NonNull AbstractFolder<I> parent, @NonNull String legacyDirName) {
             return legacyDirName;
         }
-
-        @Override
-        public void recordLegacyName(AbstractFolder<I> parent, I item, String legacyDirName) {
-            // no-op
-        }
     }
 }

src/main/java/com/cloudbees/hudson/plugins/folder/ChildNameGenerator.java

@@ -254,18 +254,6 @@ final File ensureItemDirectory(@NonNull P parent, @NonNull I item, @NonNull File
     @NonNull
     public abstract String dirNameFromLegacy(@NonNull P parent, @NonNull String legacyDirName);
 
-    /**
-     * Record the ideal name inferred in the item when it was missing and has been inferred from the legacy directory
-     * name.
-     *
-     * @param parent the parent.
-     * @param item the item.
-     * @param legacyDirName the name of the directory that the item was loaded from.
-     * @throws IOException if the ideal name could not be attached to the item.
-     * @deprecated removed without replacement
-     */
-    public abstract void recordLegacyName(P parent, I item, String legacyDirName) throws IOException;
-
     /**
      * Traces the creation of a new {@link Item} in a folder. Use
      * {@link ChildNameGenerator#beforeCreateItem(AbstractFolder, String, String)} to get the instance.

src/test/java/com/cloudbees/hudson/plugins/folder/ChildNameGeneratorAltTest.java

@@ -587,11 +587,6 @@ public String dirNameFromLegacy(@NonNull F parent,
                                         @NonNull String legacyDirName) {
             return mangle(Normalizer.normalize(legacyDirName, Normalizer.Form.NFD));
         }
-
-        @Override
-        public void recordLegacyName(F parent, J item, String legacyDirName) throws IOException {
-            item.addProperty(new NameProperty(Normalizer.normalize(legacyDirName, Normalizer.Form.NFD)));
-        }
     }
 
 

src/test/java/com/cloudbees/hudson/plugins/folder/ChildNameGeneratorRecTest.java

@@ -488,11 +488,6 @@ public String dirNameFromLegacy(@NonNull F parent,
                                         @NonNull String legacyDirName) {
             return mangle(rawDecode(legacyDirName));
         }
-
-        @Override
-        public void recordLegacyName(F parent, J item, String legacyDirName) throws IOException {
-            item.addProperty(new NameProperty(rawDecode(legacyDirName)));
-        }
     }
 
     /**

src/test/java/com/cloudbees/hudson/plugins/folder/ChildNameGeneratorTest.java

@@ -602,11 +602,6 @@ public String dirNameFromLegacy(@NonNull F parent,
                                         @NonNull String legacyDirName) {
             return mangle(legacyDirName);
         }
-
-        @Override
-        public void recordLegacyName(F parent, J item, String legacyDirName) throws IOException {
-            item.addProperty(new NameProperty(legacyDirName));
-        }
     }
 
     static CharSequence asJavaString(String rawString) {