Use commons-lang3-api (#458)

Author: strangelookingnerd

pom.xml

@@ -61,6 +61,10 @@
   </dependencyManagement>
 
   <dependencies>
+    <dependency>
+      <groupId>io.jenkins.plugins</groupId>
+      <artifactId>commons-lang3-api</artifactId>
+    </dependency>
     <dependency>
       <groupId>io.jenkins.plugins</groupId>
       <artifactId>emoji-symbols-api</artifactId>
@@ -86,16 +90,6 @@
       <artifactId>apache-httpcomponents-client-5-api</artifactId>
       <scope>test</scope>
     </dependency>
-    <dependency>
-      <groupId>io.jenkins.plugins</groupId>
-      <artifactId>commons-lang3-api</artifactId>
-      <scope>test</scope>
-    </dependency>
-    <dependency>
-      <groupId>io.jenkins.plugins</groupId>
-      <artifactId>commons-text-api</artifactId>
-      <scope>test</scope>
-    </dependency>
     <dependency>
       <groupId>org.jenkins-ci.plugins</groupId>
       <artifactId>branch-api</artifactId>

src/main/java/jenkins/plugins/foldericon/CustomFolderIcon.java

@@ -22,7 +22,7 @@
 import java.util.stream.Collectors;
 import jenkins.model.Jenkins;
 import org.apache.commons.fileupload2.core.FileItem;
-import org.apache.commons.lang.StringUtils;
+import org.apache.commons.lang3.StringUtils;
 import org.kohsuke.stapler.AncestorInPath;
 import org.kohsuke.stapler.DataBoundConstructor;
 import org.kohsuke.stapler.HttpResponse;

src/main/java/jenkins/plugins/foldericon/CustomFolderIconConfiguration.java

@@ -15,7 +15,7 @@
 import jenkins.model.GlobalConfigurationCategory;
 import jenkins.model.Jenkins;
 import org.apache.commons.io.FileUtils;
-import org.apache.commons.lang.StringUtils;
+import org.apache.commons.lang3.StringUtils;
 import org.kohsuke.stapler.HttpResponse;
 import org.kohsuke.stapler.HttpResponses;
 import org.kohsuke.stapler.StaplerRequest2;

src/main/java/jenkins/plugins/foldericon/EmojiFolderIcon.java

@@ -7,7 +7,7 @@
 import hudson.Extension;
 import io.jenkins.plugins.emoji.symbols.Emojis;
 import jenkins.model.Jenkins;
-import org.apache.commons.lang.StringUtils;
+import org.apache.commons.lang3.StringUtils;
 import org.kohsuke.stapler.DataBoundConstructor;
 
 /**

src/main/java/jenkins/plugins/foldericon/FontAwesomeFolderIcon.java

@@ -7,7 +7,7 @@
 import hudson.Extension;
 import io.jenkins.plugins.fontawesome.FontAwesomeIcons;
 import jenkins.model.Jenkins;
-import org.apache.commons.lang.StringUtils;
+import org.apache.commons.lang3.StringUtils;
 import org.kohsuke.stapler.DataBoundConstructor;
 
 /**

src/main/java/jenkins/plugins/foldericon/IoniconFolderIcon.java

@@ -7,7 +7,7 @@
 import hudson.Extension;
 import io.jenkins.plugins.ionicons.Ionicons;
 import jenkins.model.Jenkins;
-import org.apache.commons.lang.StringUtils;
+import org.apache.commons.lang3.StringUtils;
 import org.kohsuke.stapler.DataBoundConstructor;
 
 /**

src/main/java/jenkins/plugins/foldericon/OpenSourceFolderIcon.java

@@ -7,7 +7,7 @@
 import hudson.Extension;
 import io.jenkins.plugins.oss.symbols.OpenSourceSymbols;
 import jenkins.model.Jenkins;
-import org.apache.commons.lang.StringUtils;
+import org.apache.commons.lang3.StringUtils;
 import org.kohsuke.stapler.DataBoundConstructor;
 
 /**

src/main/java/jenkins/plugins/foldericon/UrlFolderIcon.java

@@ -8,7 +8,7 @@
 import hudson.model.Item;
 import hudson.util.FormValidation;
 import jenkins.model.Jenkins;
-import org.apache.commons.lang.StringUtils;
+import org.apache.commons.lang3.StringUtils;
 import org.kohsuke.stapler.AncestorInPath;
 import org.kohsuke.stapler.DataBoundConstructor;
 import org.kohsuke.stapler.QueryParameter;

src/test/java/jenkins/plugins/foldericon/BuildStatusFolderIconTest.java

@@ -17,7 +17,7 @@
 import jenkins.plugins.foldericon.BuildStatusFolderIcon.DescriptorImpl;
 import jenkins.plugins.foldericon.utils.DelayBuilder;
 import jenkins.plugins.foldericon.utils.ResultBuilder;
-import org.apache.commons.lang.StringUtils;
+import org.apache.commons.lang3.StringUtils;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import org.jvnet.hudson.test.JenkinsRule;

src/test/java/jenkins/plugins/foldericon/CustomFolderIconConfigurationTest.java

@@ -18,7 +18,7 @@
 import jenkins.model.GlobalConfigurationCategory;
 import jenkins.model.Jenkins;
 import org.apache.commons.io.FileUtils;
-import org.apache.commons.lang.StringUtils;
+import org.apache.commons.lang3.StringUtils;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import org.jvnet.hudson.test.JenkinsRule;