Skip to content

Commit 8faea21

Browse files
[JENKINS-74060][JENKINS-74061][JENKINS-74062] Remove legacy checkUrl validation (#109)
1 parent ea877db commit 8faea21

File tree

3 files changed

+11
-7
lines changed

3 files changed

+11
-7
lines changed

src/main/resources/hudson/scm/CVSSCM/global.jelly

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ THE SOFTWARE.
6767
<f:repeatable field="authentication">
6868
<local:blockWrapper>
6969
<f:entry field="cvsRoot" title="${%CVS Root}">
70-
<f:textbox name="cvsAuthentication.cvsRoot" checkUrl="'descriptorByName/CVSSCM/checkAuthenticationCvsRoot?value='+escape(this.value)" />
70+
<f:textbox name="cvsAuthentication.cvsRoot" checkUrl="descriptorByName/CVSSCM/checkAuthenticationCvsRoot" checkDependsOn="" />
7171
</f:entry>
7272
<f:entry field="username" title="${%Username}">
7373
<f:textbox name="cvsAuthentication.username" />

src/main/resources/hudson/scm/cvstagging/CvsTagAction/tagForm.jelly

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,10 @@ THE SOFTWARE.
3838
<table>
3939
<f:block>
4040
${%Choose the CVS tag name for this build}:
41-
<f:textbox name="name" value="jenkins-${it.build.number}"
42-
checkUrl="'checkTag?value='+encodeURIComponent(this.value)"/> <br />
41+
<f:entry>
42+
<f:textbox name="name" value="jenkins-${it.build.number}"
43+
checkUrl="checkTag" checkDependsOn=""/>
44+
</f:entry>
4345
${%Create tag as branch} <f:checkbox name="createBranch" /> <br />
4446
${%Move tag if it already exists} <f:checkbox name="moveTag" />
4547
</f:block>
@@ -50,7 +52,7 @@ THE SOFTWARE.
5052
<j:forEach var="up" items="${upstream}">
5153
<f:entry title="${up.key.name} #${up.value}">
5254
<f:textbox name="upstream.${up.key.name}" value="hudson-${up.value}"
53-
checkUrl="'checkTag?value='+encodeURIComponent(this.value)"/>
55+
checkUrl="checkTag" checkDependsOn=""/>
5456
</f:entry>
5557
<f:entry title="${%Create tag as branch}">
5658
<f:checkbox name="upstream-createBranch.${up.key.name}" />

src/main/resources/hudson/scm/cvstagging/LegacyTagAction/tagForm.jelly

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,10 @@ THE SOFTWARE.
5252
<local:blockWrapper>
5353
<f:block>
5454
${%Choose the CVS tag name for this build}:
55-
<f:textbox name="name" value="hudson-${it.build.number}"
56-
checkUrl="'checkTag?value='+encodeURIComponent(this.value)"/>
55+
<f:entry>
56+
<f:textbox name="name" value="hudson-${it.build.number}"
57+
checkUrl="checkTag" checkDependsOn=""/>
58+
</f:entry>
5759
</f:block>
5860

5961
<j:set var="upstream" value="${it.build.transitiveUpstreamBuilds}" />
@@ -62,7 +64,7 @@ THE SOFTWARE.
6264
<j:forEach var="up" items="${upstream}">
6365
<f:entry title="${up.key.fullDisplayName} #${up.value}">
6466
<f:textbox name="upstream.${up.key.fullName}" value="hudson-${up.value}"
65-
checkUrl="'checkTag?value='+encodeURIComponent(this.value)"/>
67+
checkUrl="checkTag" checkDependsOn=""/>
6668
</f:entry>
6769
</j:forEach>
6870
</f:optionalBlock>

0 commit comments

Comments
 (0)