Install git-lfs config to system rather than global (#1109) (#1111)

The upstream install script installs the config globally (scoped to the
user).  It is run as root, thus installed to `/root/.gitconfig` and
unavailable to the jenkins user.  Installing to the system, as distro
packages do, makes the config available to any user (i.e. jenkins).

The script currently has no way to change the scope or to opt out of the
 installation.  The global config could be safely removed to save a few
bytes, but opting for a slightly shorter Dockerfile instead.

Author: rrjjvv

alpine/Dockerfile

@@ -94,6 +94,7 @@ RUN arch=$(uname -m | sed -e 's/x86_64/amd64/g' -e 's/aarch64/arm64/g') \
   && curl -L -s -o git-lfs.tgz "https://github.com/git-lfs/git-lfs/releases/download/v${GIT_LFS_VERSION}/git-lfs-linux-${arch}-v${GIT_LFS_VERSION}.tar.gz" \
   && tar xzf git-lfs.tgz \
   && bash git-lfs-*/install.sh \
+  && git lfs install --skip-repo --system \
   && rm -rf git-lfs*
 
 ENV JAVA_HOME=/opt/java/openjdk

debian/Dockerfile

@@ -104,6 +104,7 @@ RUN arch=$(uname -m | sed -e 's/x86_64/amd64/g' -e 's/aarch64/arm64/g' -e 's/arm
   && curl -L -s -o git-lfs.tgz "https://github.com/git-lfs/git-lfs/releases/download/v${GIT_LFS_VERSION}/git-lfs-linux-${arch}-v${GIT_LFS_VERSION}.tar.gz" \
   && tar xzf git-lfs.tgz \
   && bash git-lfs-*/install.sh \
+  && git lfs install --skip-repo --system \
   && rm -rf git-lfs*
 
 ENV LANG=C.UTF-8

rhel/ubi9/Dockerfile

@@ -68,6 +68,7 @@ RUN arch=$(uname -m | sed -e 's/x86_64/amd64/g' -e 's/aarch64/arm64/g') \
   && curl -L -s -o git-lfs.tgz "https://github.com/git-lfs/git-lfs/releases/download/v${GIT_LFS_VERSION}/git-lfs-linux-${arch}-v${GIT_LFS_VERSION}.tar.gz" \
   && tar xzf git-lfs.tgz \
   && bash git-lfs-*/install.sh \
+  && git lfs install --skip-repo --system \
   && rm -rf git-lfs*
 
 ENV LANG=C.UTF-8

tests/tests_agent.bats

@@ -65,6 +65,7 @@ GIT_LFS_VERSION='3.7.1'
   assert_success
   run docker exec "${cid}" git lfs env
   assert_output --partial "${GIT_LFS_VERSION}"
+  refute_output --regexp 'git config filter\.lfs\.\w+ = ""'
 
   run docker exec "${cid}" sh -c "printenv | grep AGENT_WORKDIR"
   assert_equal "${output}" "AGENT_WORKDIR=/home/jenkins/agent"