chore: remove unused TOOLS_WINDOWS_VERSION (#2169)

Author: lemeurherve

build-windows.yaml

@@ -11,7 +11,6 @@ services:
         WAR_SHA: ${WAR_SHA}
         JENKINS_VERSION: ${JENKINS_VERSION}
         WAR_URL: ${WAR_URL}
-        TOOLS_WINDOWS_VERSION: ${TOOLS_WINDOWS_VERSION}
         WINDOWS_VERSION: ${WINDOWS_VERSION}
       tags:
         - ${DOCKERHUB_ORGANISATION}/${DOCKERHUB_REPO}:${JENKINS_VERSION}-jdk17-hotspot-${WINDOWS_FLAVOR}-${WINDOWS_VERSION}
@@ -27,7 +26,6 @@ services:
         WAR_SHA: ${WAR_SHA}
         JENKINS_VERSION: ${JENKINS_VERSION}
         WAR_URL: ${WAR_URL}
-        TOOLS_WINDOWS_VERSION: ${TOOLS_WINDOWS_VERSION}
         WINDOWS_VERSION: ${WINDOWS_VERSION}
       tags:
         - ${DOCKERHUB_ORGANISATION}/${DOCKERHUB_REPO}:${JENKINS_VERSION}-jdk21-hotspot-${WINDOWS_FLAVOR}-${WINDOWS_VERSION}
@@ -45,7 +43,6 @@ services:
         WAR_SHA: ${WAR_SHA}
         JENKINS_VERSION: ${JENKINS_VERSION}
         WAR_URL: ${WAR_URL}
-        TOOLS_WINDOWS_VERSION: ${TOOLS_WINDOWS_VERSION}
         WINDOWS_VERSION: ${WINDOWS_VERSION}
       tags:
         - ${DOCKERHUB_ORGANISATION}/${DOCKERHUB_REPO}:${JENKINS_VERSION}-jdk25-hotspot-${WINDOWS_FLAVOR}-${WINDOWS_VERSION}

make.ps1

@@ -51,11 +51,6 @@ if([String]::IsNullOrWhiteSpace($env:WAR_URL)) {
 $items = $ImageType.Split('-')
 $env:WINDOWS_FLAVOR = $items[0]
 $env:WINDOWS_VERSION = $items[1]
-$env:TOOLS_WINDOWS_VERSION = $items[1]
-if ($items[1] -eq 'ltsc2019') {
-    # There are no eclipse-temurin:*-ltsc2019 or mcr.microsoft.com/powershell:*-ltsc2019 docker images unfortunately, only "1809" ones
-    $env:TOOLS_WINDOWS_VERSION = '1809'
-}
 
 # Retrieve the sha256 corresponding to the war file
 $warShaURL = '{0}.sha256' -f $env:WAR_URL

windows/windowsservercore/hotspot/Dockerfile

@@ -3,7 +3,6 @@
 
 ARG JAVA_VERSION=17.0.17_10
 ARG WINDOWS_VERSION=ltsc2019
-ARG TOOLS_WINDOWS_VERSION=1809
 
 FROM mcr.microsoft.com/windows/servercore:"${WINDOWS_VERSION}" AS jre-build