Skip to content

Commit 020e072

Browse files
authored
Fix acceptance tests bny reverting capitalization change (#1647)
The Jenkins acceptance test harness uses the display name to locate UI components and test them. It locates those components by display name. The tests in the acceptance test harness are especially valuable now while we are preparing for the Spring Security 6.x upgrade. It is better to retain the previous capitalization and preserve Jenkins acceptance test harness results rather than need to spread the capitalization change into the acceptance test harness and related components. Added TODO item to fix the capitalization in both the git plugin and the acceptance test harness in a future release.
1 parent fea4aad commit 020e072

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

src/main/java/hudson/plugins/git/extensions/impl/SparseCheckoutPaths.java

+7-1
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,13 @@ public void determineSupportForJGit(GitSCM scm, @NonNull UnsupportedCommand cmd)
5757
public static class DescriptorImpl extends GitSCMExtensionDescriptor {
5858
@Override
5959
public String getDisplayName() {
60-
return "Sparse checkout paths";
60+
/* TODO Fix capitalization error here and in Jenkins acceptance test harness.
61+
*
62+
* https://github.com/jenkinsci/acceptance-test-harness/pull/1685#issuecomment-2310075738
63+
* Acceptance test harness for Git SCM should find components by class instead of by
64+
* display name. Otherwise changes to display name need to be made in ATH and the plugin.
65+
*/
66+
return "Sparse Checkout paths";
6167
}
6268
}
6369

0 commit comments

Comments
 (0)