Skip to content

Commit d7d4f71

Browse files
Bump io.jenkins.tools.bom:bom-2.440.x from 3387.v0f2773fa_3200 to 3413.v0d896b_76a_30d (#1661)
1 parent c2a3fad commit d7d4f71

9 files changed

+40
-19
lines changed

pom.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@
8181
<dependency>
8282
<groupId>io.jenkins.tools.bom</groupId>
8383
<artifactId>bom-${jenkins.baseline}.x</artifactId>
84-
<version>3387.v0f2773fa_3200</version>
84+
<version>3413.v0d896b_76a_30d</version>
8585
<type>pom</type>
8686
<scope>import</scope>
8787
</dependency>

src/test/java/hudson/plugins/git/CredentialsUserRemoteConfigTest.java

+3-2
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import com.cloudbees.plugins.credentials.common.StandardCredentials;
55
import com.cloudbees.plugins.credentials.domains.Domain;
66
import com.cloudbees.plugins.credentials.impl.UsernamePasswordCredentialsImpl;
7+
import hudson.model.Descriptor.FormException;
78
import java.util.ArrayList;
89
import java.util.Arrays;
910
import java.util.Collections;
@@ -347,7 +348,7 @@ public void checkoutWithNoCredentialsSpecified() throws Exception {
347348
r.waitForMessage("No credentials specified", b);
348349
}
349350

350-
private StandardCredentials createCredential(CredentialsScope scope, String id) {
351-
return new UsernamePasswordCredentialsImpl(scope, id, "desc: " + id, "username", "password");
351+
private StandardCredentials createCredential(CredentialsScope scope, String id) throws FormException {
352+
return new UsernamePasswordCredentialsImpl(scope, id, "desc: " + id, "username", "password-longer-than-14");
352353
}
353354
}

src/test/java/hudson/plugins/git/FIPSModeUrlCheckTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ public void testUserRemoteConfigCheck() throws Throwable {
133133
SystemCredentialsProvider.getInstance()
134134
.getCredentials()
135135
.add(new UsernamePasswordCredentialsImpl(
136-
CredentialsScope.GLOBAL, "mycreds", null, "jenkins", "s3cr3t"));
136+
CredentialsScope.GLOBAL, "mycreds", null, "jenkins", "s3cr3t-at-least-14-chars"));
137137
SystemCredentialsProvider.getInstance().save();
138138
FreeStyleProject p = r.createProject(FreeStyleProject.class, "mbp");
139139
UserRemoteConfig.DescriptorImpl descriptor =

src/test/java/hudson/plugins/git/GitSCMTest.java

+23-5
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,25 @@
1313
import hudson.FilePath;
1414
import hudson.Functions;
1515
import hudson.Launcher;
16-
import hudson.model.*;
16+
import hudson.model.AbstractBuild;
17+
import hudson.model.Action;
18+
import hudson.model.Cause;
19+
import hudson.model.Descriptor;
20+
import hudson.model.Descriptor.FormException;
21+
import hudson.model.EnvironmentContributingAction;
22+
import hudson.model.EnvironmentContributor;
23+
import hudson.model.Fingerprint;
24+
import hudson.model.FreeStyleBuild;
25+
import hudson.model.FreeStyleProject;
26+
import hudson.model.ParameterValue;
27+
import hudson.model.ParametersAction;
28+
import hudson.model.ParametersDefinitionProperty;
29+
import hudson.model.Result;
30+
import hudson.model.Run;
31+
import hudson.model.StringParameterDefinition;
32+
import hudson.model.StringParameterValue;
33+
import hudson.model.TaskListener;
34+
import hudson.model.User;
1735
import hudson.plugins.git.GitSCM.DescriptorImpl;
1836
import hudson.plugins.git.browser.GithubWeb;
1937
import hudson.plugins.git.extensions.GitSCMExtension;
@@ -158,9 +176,9 @@ public void waitForJenkinsIdle() throws Exception {
158176
}
159177
}
160178

161-
private StandardCredentials getInvalidCredential() {
179+
private StandardCredentials getInvalidCredential() throws FormException {
162180
String username = "bad-user";
163-
String password = "bad-password";
181+
String password = "bad-password-but-long-enough";
164182
CredentialsScope scope = CredentialsScope.GLOBAL;
165183
String id = "username-" + username + "-password-" + password;
166184
return new UsernamePasswordCredentialsImpl(scope, id, "desc: " + id, username, password);
@@ -2945,7 +2963,7 @@ private boolean isWindows() {
29452963
return java.io.File.pathSeparatorChar==';';
29462964
}
29472965

2948-
private StandardCredentials createCredential(CredentialsScope scope, String id) {
2949-
return new UsernamePasswordCredentialsImpl(scope, id, "desc: " + id, "username", "password");
2966+
private StandardCredentials createCredential(CredentialsScope scope, String id) throws FormException {
2967+
return new UsernamePasswordCredentialsImpl(scope, id, "desc: " + id, "username", "password-needs-to-be-14");
29502968
}
29512969
}

src/test/java/hudson/plugins/git/GitStepTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ public void roundtrip() throws Exception {
123123
@Test
124124
public void roundtrip_withcredentials() throws Exception {
125125
assumeTrue("Test class max time " + MAX_SECONDS_FOR_THESE_TESTS + " exceeded", isTimeAvailable());
126-
IdCredentials c = new UsernamePasswordCredentialsImpl(CredentialsScope.GLOBAL, null, null, "user", "pass");
126+
IdCredentials c = new UsernamePasswordCredentialsImpl(CredentialsScope.GLOBAL, null, null, "user", "password-needs-to-be-14");
127127
CredentialsProvider.lookupStores(r.jenkins).iterator().next()
128128
.addCredentials(Domain.global(), c);
129129
GitStep step = new GitStep("[email protected]:jenkinsci/workflow-plugin.git");

src/test/java/hudson/plugins/git/UserRemoteConfigTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public class UserRemoteConfigTest {
2929
@Issue("JENKINS-38048")
3030
@Test
3131
public void credentialsDropdown() throws Exception {
32-
SystemCredentialsProvider.getInstance().getCredentials().add(new UsernamePasswordCredentialsImpl(CredentialsScope.GLOBAL, "mycreds", null, "jenkins", "s3cr3t"));
32+
SystemCredentialsProvider.getInstance().getCredentials().add(new UsernamePasswordCredentialsImpl(CredentialsScope.GLOBAL, "mycreds", null, "jenkins", "s3cr3t-that-needs-to-be-long"));
3333
SystemCredentialsProvider.getInstance().save();
3434
FreeStyleProject p1 = r.createFreeStyleProject("p1");
3535
FreeStyleProject p2 = r.createFreeStyleProject("p2");

src/test/java/jenkins/plugins/git/AbstractGitSCMSourceTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -340,7 +340,7 @@ public void retrieveTags_folderScopedCredentials() throws Exception {
340340
assert folderStore != null;
341341
String fCredentialsId = "fcreds";
342342
StandardCredentials fCredentials = new UsernamePasswordCredentialsImpl(CredentialsScope.GLOBAL,
343-
fCredentialsId, "fcreds", "user", "password");
343+
fCredentialsId, "fcreds", "user", "password-longer-than-14");
344344
folderStore.addCredentials(Domain.global(), fCredentials);
345345
folderStore.save();
346346
WorkflowJob p = f.createProject(WorkflowJob.class, "wjob");

src/test/java/jenkins/plugins/git/GitToolChooserTest.java

+3-2
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
import com.cloudbees.plugins.credentials.impl.UsernamePasswordCredentialsImpl;
77
import hudson.FilePath;
88
import hudson.model.*;
9+
import hudson.model.Descriptor.FormException;
910
import hudson.model.labels.LabelAtom;
1011
import hudson.plugins.git.GitTool;
1112
import hudson.slaves.DumbSlave;
@@ -809,8 +810,8 @@ private void failAProject(GitSampleRepoRule sampleRepo) throws Exception {
809810
r.waitForMessage("Couldn't find any revision to build", b);
810811
}
811812

812-
private StandardCredentials createCredential(CredentialsScope scope, String id) {
813-
return new UsernamePasswordCredentialsImpl(scope, id, "desc: " + id, "username", "password");
813+
private StandardCredentials createCredential(CredentialsScope scope, String id) throws FormException {
814+
return new UsernamePasswordCredentialsImpl(scope, id, "desc: " + id, "username", "password-longer-than-14");
814815
}
815816

816817
/** inline ${@link hudson.Functions#isWindows()} to prevent a transient remote classloader issue */

src/test/java/jenkins/plugins/git/GitUsernamePasswordBindingTest.java

+6-5
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import hudson.EnvVars;
99
import hudson.FilePath;
1010

11+
import hudson.model.Descriptor.FormException;
1112
import hudson.model.FreeStyleBuild;
1213
import hudson.model.FreeStyleProject;
1314
import hudson.model.Item;
@@ -113,12 +114,12 @@ private boolean isTimeAvailable() {
113114
"randomName",
114115
};
115116
private static String[] passwords = {
116-
"&Ampersand&",
117+
"&Ampersand-long-enough&",
117118
"He said \"Hello\", then left.",
118-
"default=@#(*^!",
119+
"default=@#(*^!-long-enough",
119120
"has_a_trailing_quote=@#(*^!'",
120-
"here's-a-quote",
121-
"special%%_342@**",
121+
"here's-a-quote-long-enough",
122+
"special%%_342@**-long-enough",
122123
"%interior-single-quote%_786'@**",
123124
};
124125
private static GitTool[] gitTools = {
@@ -142,7 +143,7 @@ public GitUsernamePasswordBindingTest(String username, String password, GitTool
142143
}
143144

144145
@Before
145-
public void basicSetup() throws IOException {
146+
public void basicSetup() throws FormException, IOException {
146147
//File init
147148
rootDir = tempFolder.getRoot();
148149
rootFilePath = new FilePath(rootDir.getAbsoluteFile());

0 commit comments

Comments
 (0)