Added tests for GiteeCreatePullRequestPublisher.java and small bug fix (#141)

Author: Puffy1215

src/main/java/com/gitee/jenkins/publisher/GiteeCreatePullRequestPublisher.java

@@ -20,6 +20,7 @@
 import hudson.model.AbstractBuild;
 import hudson.model.AbstractProject;
 import hudson.model.BuildListener;
+import hudson.model.Result;
 import hudson.tasks.BuildStepDescriptor;
 import hudson.tasks.BuildStepMonitor;
 import hudson.tasks.Notifier;
@@ -112,9 +113,12 @@ public boolean perform(AbstractBuild<?, ?> build, Launcher launcher, BuildListen
         if (addDatetime) {
             pullRequestTitle = LocalDateTime.now().toString() + title;
         }
-        client.createPullRequest(owner, repo, pullRequestTitle, base, head);
 
-        LOGGER.log(Level.INFO, "Pull request {0} generated, {1} -> {2}", LoggerUtil.toArray(title, head, base));
+        if (build.getResult() == Result.SUCCESS) {
+            client.createPullRequest(owner, repo, pullRequestTitle, base, head);
+            LOGGER.log(Level.INFO, "Pull request {0} generated, {1} -> {2}", LoggerUtil.toArray(title, head, base));
+        }
+        
         return true;
     }
 

src/test/java/com/gitee/jenkins/publisher/GiteeCreatePullRequestPublisherTest.java

@@ -0,0 +1,94 @@
+package com.gitee.jenkins.publisher;
+
+import static com.gitee.jenkins.publisher.TestUtility.GITEE_CONNECTION_V5;
+import static com.gitee.jenkins.publisher.TestUtility.OWNER_PATH;
+import static com.gitee.jenkins.publisher.TestUtility.REPO_PATH;
+import static com.gitee.jenkins.publisher.TestUtility.setupGiteeConnections;
+import static com.gitee.jenkins.publisher.TestUtility.verifyMatrixAggregatable;
+import static org.mockserver.model.HttpRequest.request;
+import static org.mockserver.model.HttpResponse.response;
+import static com.gitee.jenkins.publisher.TestUtility.mockSimpleBuild;
+import java.io.IOException;
+import java.nio.charset.Charset;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.jvnet.hudson.test.JenkinsRule;
+import org.jvnet.hudson.test.junit.jupiter.WithJenkins;
+import org.mockserver.client.MockServerClient;
+import org.mockserver.junit.jupiter.MockServerExtension;
+import org.mockserver.model.HttpRequest;
+
+import hudson.model.BuildListener;
+import hudson.model.Result;
+import hudson.model.StreamBuildListener;
+
+@WithJenkins
+@ExtendWith(MockServerExtension.class)
+public class GiteeCreatePullRequestPublisherTest {
+    private static JenkinsRule jenkins;
+
+    private static MockServerClient mockServerClient;
+    private BuildListener listener;
+
+    @BeforeAll
+    static void setUp(JenkinsRule rule, MockServerClient client) throws Exception {
+        jenkins = rule;
+        mockServerClient = client;
+        setupGiteeConnections(jenkins, client);
+    }
+
+    @BeforeEach
+    void setUp() {
+        listener = new StreamBuildListener(jenkins.createTaskListener().getLogger(), Charset.defaultCharset());
+    }
+
+    @AfterEach
+    void tearDown() {
+        mockServerClient.reset();
+    }
+
+    @Test
+    void matrixAggregatable() throws Exception {
+        verifyMatrixAggregatable(GiteeMessagePublisher.class, listener);
+    }
+
+    @Test
+    void success() throws InterruptedException, IOException {
+        HttpRequest createPullRequestStatus = prepareCreatePullRequest("v5");
+        mockServerClient.when(createPullRequestStatus).respond(response().withStatusCode(200));
+
+        GiteeCreatePullRequestPublisher p = new GiteeCreatePullRequestPublisher();
+        p.setRepo(REPO_PATH);
+        p.setOwner(OWNER_PATH);
+        p.setBase("base");
+        p.setHead("head");
+        p.setTitle("title");
+
+        p.perform(mockSimpleBuild(GITEE_CONNECTION_V5, Result.SUCCESS), null, listener);
+        mockServerClient.verify(createPullRequestStatus);
+    }
+
+    @Test
+    void failed() throws InterruptedException, IOException {
+        GiteeCreatePullRequestPublisher p = new GiteeCreatePullRequestPublisher();
+        p.setRepo(REPO_PATH);
+        p.setOwner(OWNER_PATH);
+        p.setBase("base");
+        p.setHead("head");
+        p.setTitle("title");
+
+        p.perform(mockSimpleBuild(GITEE_CONNECTION_V5, Result.FAILURE), null, listener);
+        mockServerClient.verifyZeroInteractions();
+    }
+
+    private HttpRequest prepareCreatePullRequest(String apiLevel) {
+        return request()
+                .withPath(String.format("/gitee/api/%s/repos/%s/%s/pulls", apiLevel, OWNER_PATH, REPO_PATH))
+                .withMethod("POST")
+                .withHeader("PRIVATE-TOKEN", "secret");
+    }
+
+}

src/test/java/com/gitee/jenkins/publisher/TestUtility.java

@@ -48,6 +48,7 @@ final class TestUtility {
     static final String GITEE_CONNECTION_V5 = "GiteeV5";
     static final String BUILD_URL = "/build/123";
     static final String REPO_PATH = "testPath";
+    static final String OWNER_PATH = "testUser";
     static final String PULL_COMMIT_SHA = "eKJ3wuqJT98Kc8TCcBK7oggLR1E9Bty7eqSHfSLT";
     static final int BUILD_NUMBER = 1;
     static final int PROJECT_ID = 3;