Merge pull request #894 from lprimak/fix-casc-default-permissions

bugfix: regression in default permissions strategy initialization in …

Author: jeromepochat

src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubAppCredentials.java

@@ -21,6 +21,7 @@
 import hudson.util.ListBoxModel;
 import hudson.util.Secret;
 import java.io.IOException;
+import java.io.Serial;
 import java.io.Serializable;
 import java.security.GeneralSecurityException;
 import java.time.Duration;
@@ -596,13 +597,16 @@ long getTokenStaleEpochSeconds() {
         }
     }
 
-    private Object readResolve() {
+    @Serial
+    Object readResolve() {
         cachedCredentials = new ConcurrentHashMap<>();
-        if (repositoryAccessStrategy == null || defaultPermissionsStrategy == null) {
+        if (repositoryAccessStrategy == null) {
             setRepositoryAccessStrategy(new AccessSpecifiedRepositories(owner, List.of()));
-            setDefaultPermissionsStrategy(DefaultPermissionsStrategy.INHERIT_ALL);
             MigrationAdminMonitor.addMigratedCredentialId(getId());
         }
+        if (defaultPermissionsStrategy == null) {
+            setDefaultPermissionsStrategy(DefaultPermissionsStrategy.INHERIT_ALL);
+        }
         owner = null;
         context = new GitHubAppUsageContext();
         return this;