Skip to content

Commit 8aed3a6

Browse files
committed
Merging #724 (from Git; API seems to be down at the moment)
2 parents 3f1889a + 9e45152 commit 8aed3a6

File tree

3 files changed

+14
-7
lines changed

3 files changed

+14
-7
lines changed

.mvn/extensions.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@
22
<extension>
33
<groupId>io.jenkins.tools.incrementals</groupId>
44
<artifactId>git-changelist-maven-extension</artifactId>
5-
<version>1.6</version>
5+
<version>1.7</version>
66
</extension>
77
</extensions>

pom.xml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<parent>
55
<groupId>org.jenkins-ci.plugins</groupId>
66
<artifactId>plugin</artifactId>
7-
<version>4.67</version>
7+
<version>4.72</version>
88
<relativePath />
99
</parent>
1010

@@ -43,7 +43,7 @@
4343
<dependency>
4444
<groupId>io.jenkins.tools.bom</groupId>
4545
<artifactId>bom-2.387.x</artifactId>
46-
<version>2163.v2d916d90c305</version>
46+
<version>2378.v3e03930028f2</version>
4747
<type>pom</type>
4848
<scope>import</scope>
4949
</dependency>
@@ -66,8 +66,6 @@
6666
<dependency>
6767
<groupId>io.jenkins.plugins</groupId>
6868
<artifactId>okhttp-api</artifactId>
69-
<!--Remove once this version is in the bom-->
70-
<version>4.10.0-136.v1d8ce1b_1db_72</version>
7169
</dependency>
7270
<dependency>
7371
<groupId>org.jenkins-ci.plugins</groupId>

src/test/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest.java

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,15 @@ public void given__configuredInstance__when__uninstantiating__then__deprecatedFi
7575
} else {
7676
trust = "TrustPermission";
7777
}
78+
String originTrait;
79+
String forkTrait;
80+
if (r.jenkins.getPlugin("cloudbees-bitbucket-branch-source") != null) {
81+
originTrait = "org.jenkinsci.plugins.github_branch_source.OriginPullRequestDiscoveryTrait";
82+
forkTrait = "org.jenkinsci.plugins.github_branch_source.ForkPullRequestDiscoveryTrait";
83+
} else {
84+
originTrait = "OriginPullRequestDiscoveryTrait";
85+
forkTrait = "ForkPullRequestDiscoveryTrait";
86+
}
7887
assertThat(
7988
DescribableModel.uninstantiate2_(recreated).toString(),
8089
is("@github("
@@ -84,8 +93,8 @@ public void given__configuredInstance__when__uninstantiating__then__deprecatedFi
8493
+ "repository=repo,"
8594
+ "traits=["
8695
+ "@gitHubBranchDiscovery$org.jenkinsci.plugins.github_branch_source.BranchDiscoveryTrait(strategyId=1), "
87-
+ "@gitHubPullRequestDiscovery$OriginPullRequestDiscoveryTrait(strategyId=1), "
88-
+ "@gitHubForkDiscovery$ForkPullRequestDiscoveryTrait("
96+
+ "@gitHubPullRequestDiscovery$" + originTrait + "(strategyId=1), "
97+
+ "@gitHubForkDiscovery$" + forkTrait + "("
8998
+ "strategyId=2,"
9099
+ "trust=@gitHubTrustPermissions$"
91100
+ trust

0 commit comments

Comments
 (0)