[JENKINS-76235] Fix 500 error when saving organization folder with credentials using an invalid owner (#909)

Author: apuig

src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java

@@ -1716,7 +1716,7 @@ public void afterSave(@NonNull SCMNavigatorOwner owner) {
             } finally {
                 Connector.release(hub);
             }
-        } catch (IOException e) {
+        } catch (Exception e) {
             DescriptorImpl.LOGGER.log(Level.WARNING, e.getMessage(), e);
         }
     }

src/test/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTest.java

@@ -25,9 +25,13 @@
 
 package org.jenkinsci.plugins.github_branch_source;
 
+import static com.github.tomakehurst.wiremock.client.WireMock.aResponse;
+import static com.github.tomakehurst.wiremock.client.WireMock.get;
+import static com.github.tomakehurst.wiremock.client.WireMock.urlEqualTo;
 import static org.hamcrest.MatcherAssert.assertThat;
 import static org.hamcrest.Matchers.*;
 import static org.junit.Assert.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
 
 import com.cloudbees.plugins.credentials.Credentials;
 import com.cloudbees.plugins.credentials.CredentialsScope;
@@ -67,6 +71,7 @@
 import org.hamcrest.Matchers;
 import org.junit.Before;
 import org.junit.Test;
+import org.jvnet.hudson.test.Issue;
 import org.jvnet.hudson.test.MockAuthorizationStrategy;
 import org.jvnet.hudson.test.MockFolder;
 import org.mockito.Mock;
@@ -576,6 +581,30 @@ public void doFillScanCredentials() throws Exception {
         }
     }
 
+    @Issue("JENKINS-76235")
+    @Test
+    public void afterSaveWithGitHubAppOwnerMismatch() {
+        // Given GitHub App credentials
+        githubApi.stubFor(get(urlEqualTo("/app"))
+                .willReturn(aResponse()
+                        .withHeader("Content-Type", "application/json")
+                        .withBody("{\"id\":54321,\"name\":\"test-app\"}")));
+        githubApi.stubFor(get(urlEqualTo("/app/installations"))
+                .willReturn(aResponse()
+                        .withHeader("Content-Type", "application/json")
+                        .withBody("[{\"id\":654321,\"account\":{\"login\":\"corp\"},\"app_id\":54321}]")));
+        GitHubAppCredentials appCredentials = GitHubApp.createCredentials("test-app-creds");
+        appCredentials.setApiUri(githubApi.baseUrl());
+        // And using a owner that doesn't have the application installed
+        appCredentials.setOwner("org-or-user-without-app");
+        setCredentials(Collections.singletonList(appCredentials));
+
+        // When creating a SCMNavigator and calling afterSave
+        navigator = navigatorForRepoOwner("corp", appCredentials.getId());
+        assertDoesNotThrow(() -> navigator.afterSave(Mockito.mock(SCMNavigatorOwner.class)));
+        // Then no exception
+    }
+
     private SCMSourceObserver getObserver(Collection<String> names) {
         return new SCMSourceObserver() {
             @NonNull