Skip to content

Commit 1bd91c3

Browse files
committed
do attempt to shade dependencies.
Was introduced in 49dc7bc but this is a waste of space. as the shade runs after the hpi package all that happens is that the classess get copied into the root of the HPI. classes are never loaded from here and there is a copy in WEB-INF\lib\gcp-client-xxx.jar that is used, and this has been working for a while. whilst there may also be a gcp-client in other places that this plugin has dependencies to I saw no gcp-client in google-oath-credentials wheich would be the only logical place. Additionally if it where not broken before this fix it would remain not broken after this fix.
1 parent 7ebc656 commit 1bd91c3

File tree

1 file changed

+0
-21
lines changed

1 file changed

+0
-21
lines changed

pom.xml

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -409,27 +409,6 @@
409409
</formats>
410410
</configuration>
411411
</plugin>
412-
<plugin>
413-
<groupId>org.apache.maven.plugins</groupId>
414-
<artifactId>maven-shade-plugin</artifactId>
415-
<version>3.5.1</version>
416-
<executions>
417-
<execution>
418-
<goals>
419-
<goal>shade</goal>
420-
</goals>
421-
<phase>package</phase>
422-
<configuration>
423-
<shadedGroupFilter>com.google.cloud.graphite</shadedGroupFilter>
424-
<promoteTransitiveDependencies>true</promoteTransitiveDependencies>
425-
<createDependencyReducedPom>false</createDependencyReducedPom>
426-
<transformers>
427-
<transformer implementation="org.apache.maven.plugins.shade.resource.ApacheLicenseResourceTransformer" />
428-
</transformers>
429-
</configuration>
430-
</execution>
431-
</executions>
432-
</plugin>
433412
</plugins>
434413
</build>
435414

0 commit comments

Comments
 (0)