Skip to content

Commit 499d02f

Browse files
authored
fix: add ingress.resourceRootUrl to ingress' spec.tls.hosts (#1588)
1 parent 7bb72ef commit 499d02f

File tree

4 files changed

+21
-3
lines changed

4 files changed

+21
-3
lines changed

charts/jenkins/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,10 @@ Use the following links to reference issues, PRs, and commits prior to v2.6.0.
1212
The changelog until v1.5.7 was auto-generated based on git commits.
1313
Those entries include a reference to the git commit to be able to get more details.
1414

15+
## 5.8.128
16+
17+
Add `ingress.resourceRootUrl` to ingress' `spec.tls.hosts`
18+
1519
## 5.8.127
1620

1721
Update `jenkins/inbound-agent` to version `3355.v388858a_47b_33-6`

charts/jenkins/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ apiVersion: v2
22
name: jenkins
33
type: application
44
home: https://www.jenkins.io/
5-
version: 5.8.127
5+
version: 5.8.128
66
appVersion: 2.541.1
77
description: >
88
Jenkins - Build great things at any scale! As the leading open source automation server, Jenkins provides over 2000 plugins to support building, deploying and automating any project.

charts/jenkins/templates/jenkins-controller-ingress.yaml

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,15 @@ spec:
6666
{{- end }}
6767
{{- if .Values.controller.ingress.tls }}
6868
tls:
69-
{{ tpl (toYaml .Values.controller.ingress.tls ) . | indent 4 }}
70-
{{- end -}}
69+
{{- range .Values.controller.ingress.tls }}
70+
- hosts:
71+
{{- range .hosts }}
72+
- {{ tpl . $ | quote }}
73+
{{- end }}
74+
{{- if $.Values.controller.ingress.resourceRootUrl }}
75+
- {{ tpl $.Values.controller.ingress.resourceRootUrl $ | quote }}
76+
{{- end }}
77+
secretName: {{ .secretName | quote }}
78+
{{- end }}
79+
{{- end }}
7180
{{- end }}

charts/jenkins/unittests/jenkins-controller-ingress-DRY-test.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,17 +10,22 @@ tests:
1010
template: jenkins-controller-ingress.yaml
1111
set:
1212
global.jenkinsHostname: "jenkins.example.com"
13+
global.resourceRootUrlHostname: "assets.jenkins.example.com"
1314
controller.ingress:
1415
enabled: true
1516
hostName: "{{ .Values.global.jenkinsHostname }}"
1617
resourceRootUrl: "{{ .Values.global.jenkinsHostname }}"
1718
tls:
1819
- hosts:
1920
- "{{ .Values.global.jenkinsHostname }}"
21+
- "{{ .Values.global.resourceRootUrlHostname }}"
2022
asserts:
2123
- equal:
2224
path: spec.rules[0].host
2325
value: "jenkins.example.com"
2426
- equal:
2527
path: spec.tls[0].hosts[0]
2628
value: "jenkins.example.com"
29+
- equal:
30+
path: spec.tls[0].hosts[1]
31+
value: "assets.jenkins.example.com"

0 commit comments

Comments
 (0)