Merge pull request #123 from basil/spotbugs

Remove unnecessary SpotBugs exclusions

Author: jimklimov

src/main/java/hudson/plugins/im/bot/SnackCommand.java

@@ -1,7 +1,5 @@
 package hudson.plugins.im.bot;
 
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
-
 import hudson.Extension;
 import hudson.plugins.im.Sender;
 import hudson.plugins.im.tools.MessageHelper;
@@ -42,7 +40,6 @@ public Collection<String> getCommandNames() {
     // a single Random object than to keep allocating new ones
     private static final Random ran = new Random();
 
-    @SuppressFBWarnings("DMI_RANDOM_USED_ONLY_ONCE") // See also https://github.com/spotbugs/spotbugs/issues/1539
     @Override
     protected String getReply(Bot bot, Sender sender, String[] args) {
         String snack = null;

src/main/java/hudson/plugins/im/build_notify/PrintFailingTestsBuildToChatNotifier.java

@@ -1,7 +1,5 @@
 package hudson.plugins.im.build_notify;
 
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
-
 import hudson.Extension;
 import hudson.model.Run;
 import hudson.model.TaskListener;
@@ -73,8 +71,6 @@ private CharSequence getFailedTestsReport(Run<?, ?> build) {
         List<CaseResult> failedTests = testResultAction.getFailedTests();
 
         Collections.sort(failedTests, new Comparator<CaseResult>() {
-            @SuppressFBWarnings(value = "SIC_INNER_SHOULD_BE_STATIC_ANON",
-                justification = "Maybe fix this inefficiency later, does not seem fatal")
             @Override
             public int compare(CaseResult o1, CaseResult o2) {
                 if (o1.getAge() < o2.getAge()) {

src/main/java/hudson/plugins/im/tools/MessageHelper.java

@@ -1,7 +1,5 @@
 package hudson.plugins.im.tools;
 
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
-
 import hudson.Util;
 import hudson.model.Hudson;
 import hudson.model.Run;