Skip to content

Commit 00770c4

Browse files
committed
fix test
1 parent a5bb0fd commit 00770c4

File tree

3 files changed

+3
-1
lines changed

3 files changed

+3
-1
lines changed

core/src/main/resources/hudson/model/BooleanParameterValue/value.jelly

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ THE SOFTWARE.
2828
xmlns:i="jelly:fmt" xmlns:p="/lib/hudson/project">
2929
<j:set var="escapeEntryTitleAndDescription" value="false"/>
3030
<f:entry description="${it.formattedDescription}">
31+
<j:set var="readOnlyMode" value="true"/>
3132
<f:checkbox title="${h.escape(it.name)}" name="value" checked="${it.value}"/>
3233
</f:entry>
3334
</j:jelly>

core/src/main/resources/hudson/model/StringParameterValue/value.jelly

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ THE SOFTWARE.
2828
xmlns:i="jelly:fmt" xmlns:p="/lib/hudson/project">
2929
<j:set var="escapeEntryTitleAndDescription" value="false"/>
3030
<f:entry title="${h.escape(it.name)}" description="${it.formattedDescription}">
31+
<j:set var="readOnlyMode" value="true"/>
3132
<f:textbox name="value" value="${it.value}"/>
3233
</f:entry>
3334
</j:jelly>

test/src/test/java/hudson/model/ParametersTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,7 @@ void xss() throws Exception {
267267
assertAll(
268268
() -> assertThat("parameters page should escape param name", text2, containsString("&lt;param name&gt;")),
269269
() -> assertThat("parameters page should not leave param name unescaped", text2, not(containsString("<param name>"))),
270-
() -> assertThat("parameters page should escape param value", text2, containsString("&lt;param value&gt;")),
270+
() -> assertThat("parameters page should escape param value", text2, containsString("&lt;param value>")),
271271
() -> assertThat("parameters page should not leave param value unescaped", text2, not(containsString("<param value>"))),
272272
() -> assertThat("parameters page should mark up param description", text2, containsString("<b>[</b>param description<b>]</b>")),
273273
() -> assertThat("parameters page should not leave param description unescaped", text2, not(containsString("<param description>")))

0 commit comments

Comments
 (0)