AdministrativeMonitorsDecorator cleanup; ManageJenkinsAction.getBadge optimization (#10855)

Author: jglick

core/src/main/java/hudson/diagnosis/ReverseProxySetupMonitor.java

@@ -66,6 +66,11 @@ public boolean isActivated() {
         return true;
     }
 
+    @Override
+    public boolean isActivationFake() {
+        return true;
+    }
+
     @Restricted(DoNotUse.class) // WebOnly
     @RestrictedSince("2.235")
     public HttpResponse doTest(StaplerRequest2 request, @QueryParameter boolean testWithContext) {

core/src/main/java/hudson/model/AdministrativeMonitor.java

@@ -160,6 +160,11 @@ public boolean isEnabled() {
      */
     public abstract boolean isActivated();
 
+    @Restricted(NoExternalUse.class)
+    public boolean isActivationFake() {
+        return false;
+    }
+
     /**
      * Returns true if this monitor is security related.
      *
@@ -186,8 +191,7 @@ public void doDisable(StaplerRequest2 req, StaplerResponse2 rsp) throws IOExcept
      * By default {@link Jenkins#ADMINISTER}, but {@link Jenkins#SYSTEM_READ} or {@link Jenkins#MANAGE} are also supported.
      * <p>
      *     Changing this permission check to return {@link Jenkins#SYSTEM_READ} will make the active
-     *     administrative monitor appear on {@code manage.jelly} and on the globally visible
-     *     {@link jenkins.management.AdministrativeMonitorsDecorator} to users without Administer permission.
+     *     administrative monitor appear on {@link ManageJenkinsAction} to users without Administer permission.
      *     {@link #doDisable(StaplerRequest2, StaplerResponse2)} will still always require Administer permission.
      * </p>
      * <p>

core/src/main/java/hudson/model/ManageJenkinsAction.java

@@ -26,11 +26,11 @@
 
 import hudson.Extension;
 import hudson.Util;
+import hudson.util.HudsonIsLoading;
+import hudson.util.HudsonIsRestarting;
 import java.io.IOException;
-import java.util.Collection;
-import java.util.Collections;
-import java.util.Optional;
-import jenkins.management.AdministrativeMonitorsDecorator;
+import java.util.logging.Level;
+import java.util.logging.Logger;
 import jenkins.management.Badge;
 import jenkins.model.Jenkins;
 import jenkins.model.ModelObjectWithContextMenu;
@@ -50,6 +50,9 @@
  */
 @Extension(ordinal = 998) @Symbol("manageJenkins")
 public class ManageJenkinsAction implements RootAction, StaplerFallback, ModelObjectWithContextMenu {
+
+    private static final Logger LOGGER = Logger.getLogger(ManageJenkinsAction.class.getName());
+
     @Override
     public String getIconFileName() {
         if (Jenkins.get().hasAnyPermission(Jenkins.MANAGE, Jenkins.SYSTEM_READ))
@@ -98,28 +101,36 @@ public void addContextMenuItem(ContextMenu menu, String url, String icon, String
         menu.add("manage/" + url, icon, iconXml, text, post, requiresConfirmation, badge, message);
     }
 
+    /** Unlike {@link Jenkins#getActiveAdministrativeMonitors} this checks for activation lazily. */
     @Override
     public Badge getBadge() {
-        Jenkins jenkins = Jenkins.get();
-        AdministrativeMonitorsDecorator decorator = jenkins.getExtensionList(PageDecorator.class)
-                .get(AdministrativeMonitorsDecorator.class);
-
-        if (decorator == null) {
+        if (!(AdministrativeMonitor.hasPermissionToDisplay())) {
             return null;
         }
 
-        Collection<AdministrativeMonitor> activeAdministrativeMonitors = Optional.ofNullable(decorator.getMonitorsToDisplay()).orElse(Collections.emptyList());
-        boolean anySecurity = activeAdministrativeMonitors.stream().anyMatch(AdministrativeMonitor::isSecurity);
-
-        if (activeAdministrativeMonitors.isEmpty()) {
+        var app = Jenkins.get().getServletContext().getAttribute("app");
+        if (app instanceof HudsonIsLoading || app instanceof HudsonIsRestarting) {
             return null;
         }
 
-        int size = activeAdministrativeMonitors.size();
-        String tooltip = size > 1 ? Messages.ManageJenkinsAction_notifications(size) : Messages.ManageJenkinsAction_notification(size);
+        if (Jenkins.get().administrativeMonitors.stream().anyMatch(m -> m.isSecurity() && isActive(m))) {
+            return new Badge("1+", Messages.ManageJenkinsAction_notifications(),
+                    Badge.Severity.DANGER);
+        } else if (Jenkins.get().administrativeMonitors.stream().anyMatch(m -> !m.isSecurity() && isActive(m))) {
+            return new Badge("1+", Messages.ManageJenkinsAction_notifications(),
+                    Badge.Severity.WARNING);
+        } else {
+            return null;
+        }
+    }
 
-        return new Badge(String.valueOf(size),
-                tooltip,
-                anySecurity ? Badge.Severity.DANGER : Badge.Severity.WARNING);
+    private static boolean isActive(AdministrativeMonitor m) {
+        try {
+            return !m.isActivationFake() && m.hasRequiredPermission() && m.isEnabled() && m.isActivated();
+        } catch (Throwable x) {
+            LOGGER.log(Level.WARNING, null, x);
+            return false;
+        }
     }
+
 }

core/src/main/java/jenkins/diagnostics/URICheckEncodingMonitor.java

@@ -31,6 +31,11 @@ public boolean isActivated() {
         return true;
     }
 
+    @Override
+    public boolean isActivationFake() {
+        return true;
+    }
+
     @Override
     public String getDisplayName() {
         return Messages.URICheckEncodingMonitor_DisplayName();

core/src/main/java/jenkins/management/AdministrativeMonitorsApi.java

@@ -66,7 +66,6 @@ public class Badge {
      *
      * @param text  The text to be shown in the badge.
      *      Keep it short, ideally just a number. More than 6 or 7 characters do not look good. Avoid spaces as they will lead to line breaks.
-     *      as this might lead to line breaks.
      * @param tooltip  The tooltip to show for the badge.
      *      Do not include html tags.
      * @param severity  The severity of the badge (danger, warning, info)

core/src/main/java/jenkins/management/AdministrativeMonitorsApiData.java

@@ -199,8 +199,7 @@ LabelExpression.LabelLink=<a href="{0}{2}">Label {1}</a> matches {3,choice,0#no
 LabelExpression.NoMatch=No agent/cloud matches this label expression.
 LabelExpression.NoMatch_DidYouMean=No agent/cloud matches this label expression. Did you mean ‘{1}’ instead of ‘{0}’?
 ManageJenkinsAction.DisplayName=Manage Jenkins
-ManageJenkinsAction.notification={0} notification
-ManageJenkinsAction.notifications={0} notifications
+ManageJenkinsAction.notifications=One or more notifications
 MultiStageTimeSeries.EMPTY_STRING=
 ParametersDefinitionProperty.BuildButtonText=Build
 Queue.AllNodesOffline=All nodes of label ‘{0}’ are offline

core/src/main/java/jenkins/management/AdministrativeMonitorsDecorator.java

@@ -66,5 +66,3 @@ ShutdownLink.Description=Stops executing new builds, so that the system can be e
 ShutdownLink.ShuttingDownInProgressDescription=Jenkins is currently shutting down. New builds are not executing.
 ShutdownLink.ShutDownReason_title=Reason
 ShutdownLink.ShutDownReason_update=Update reason
-
-AdministrativeMonitorsDecorator.DisplayName=Administrative Monitors Notifier