Simplify JS + hopefully fix test

Author: janfaracik

src/main/js/add-item.js

@@ -139,26 +139,17 @@ document.addEventListener("DOMContentLoaded", () => {
       desc.className = "jenkins-choice-list__item__description";
       desc.innerHTML = checkForLink(elem.description);
 
-      function select(e) {
-        e.preventDefault();
+      function select() {
         cleanCopyFromOption();
         cleanItemSelection();
-
-        radio.checked = true;
-
         setFieldValidationStatus("items", true);
+
         if (getFieldValidationStatus("name")) {
           refreshSubmitButtonState();
         }
       }
 
-      item.addEventListener("click", select);
-      item.addEventListener("keydown", function (evt) {
-        if (evt.code === "Space" || evt.code === "Enter") {
-          this.click();
-          evt.stopPropagation();
-        }
-      });
+      radio.addEventListener("change", select);
 
       return item;
     }

test/src/test/java/hudson/model/ViewTest.java

@@ -844,7 +844,8 @@ void newJob_xssPreventedInId() throws Exception {
 
         HtmlPage page = wc.goTo("view/all/newJob");
 
-        Object result = page.executeJavaScript("Array.from(document.querySelectorAll('.jenkins-choice-list__item__label')).filter(el => el.innerText.indexOf('" + customizableTLID.customDisplayName + "') !== -1)[0].parentElement.parentElement").getJavaScriptResult();
+        Object result = page.executeJavaScript("Array.from(document.querySelectorAll('.jenkins-choice-list__item__label'))" +
+                ".filter(el => el.innerText.indexOf('" + customizableTLID.customDisplayName + "') !== -1)[0].parentElement.parentElement").getJavaScriptResult();
         assertThat(result, instanceOf(HTMLElement.class));
         HTMLElement resultElement = (HTMLElement) result;
         assertThat(resultElement.getAttribute("onclick"), nullValue());