Remove /exception endpoint (#10326)

Author: krisstern

core/src/main/java/jenkins/model/Jenkins.java

@@ -4478,15 +4478,6 @@ public void doGc(StaplerResponse2 rsp) throws IOException {
         rsp.getWriter().println("GCed");
     }
 
-    /**
-     * End point that intentionally throws an exception to test the error behaviour.
-     * @since 1.467
-     */
-    @StaplerDispatchable
-    public void doException() {
-        throw new RuntimeException();
-    }
-
     @Override
     public ContextMenu doContextMenu(StaplerRequest2 request, StaplerResponse2 response) throws IOException, JellyException {
         ContextMenu menu = new ContextMenu().from(this, request, response);

test/src/test/java/jenkins/security/StackTraceSuppressionTest.java

@@ -29,7 +29,9 @@
 import static org.hamcrest.Matchers.not;
 
 import hudson.model.FreeStyleProject;
+import hudson.model.InvisibleAction;
 import hudson.model.ItemGroup;
+import hudson.model.RootAction;
 import hudson.model.TopLevelItemDescriptor;
 import hudson.model.User;
 import java.io.IOException;
@@ -41,6 +43,8 @@
 import org.junit.Test;
 import org.jvnet.hudson.test.JenkinsRule;
 import org.jvnet.hudson.test.MockAuthorizationStrategy;
+import org.jvnet.hudson.test.TestExtension;
+import org.kohsuke.stapler.WebMethod;
 import org.xml.sax.SAXException;
 
 public class StackTraceSuppressionTest {
@@ -129,19 +133,15 @@ public void exceptionShowsTrace() throws Exception {
 
     @Test
     public void exceptionEndpoint() throws Exception {
-        /* This test is based upon a testing endpoint that really shouldn't exist in production code.
-           If Jenkins is improved to eliminate this endpoint, this test may erroneously fail. */
         String relativePath = "exception";
-        String detailString = "Jenkins.doException";
+        String detailString = "ExceptionAction.doException";
         checkSuppressedStack(relativePath, detailString);
     }
 
     @Test
     public void exceptionEndpointShowsTrace() throws Exception {
-        /* This test is based upon a testing endpoint that really shouldn't exist in production code.
-           If Jenkins is improved to eliminate this endpoint, this test may erroneously fail. */
         String relativePath = "exception";
-        String detailString = "Jenkins.doException";
+        String detailString = "ExceptionAction.doException";
         checkDisplayedStackTrace(relativePath, detailString);
     }
 
@@ -188,4 +188,18 @@ private void checkDisplayedStackTrace(String relativePath, String detailString)
         assertThat(content, containsString(detailString));
     }
 
+    /* Replacement for historical Jenkins#doException URL */
+    @TestExtension
+    public static class ExceptionAction extends InvisibleAction implements RootAction {
+        @WebMethod(name = "")
+        public void doException() {
+            throw new RuntimeException();
+        }
+
+        @Override
+        public String getUrlName() {
+            return "exception";
+        }
+    }
+
 }