Skip to content

Commit 1f19e41

Browse files
authored
Merge branch 'master' into SECURITY-771/Fix-test-logic
2 parents 7586855 + 0cdf05e commit 1f19e41

File tree

14 files changed

+1107
-1049
lines changed

14 files changed

+1107
-1049
lines changed

ath.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ set -o xtrace
66
cd "$(dirname "$0")"
77

88
# https://github.com/jenkinsci/acceptance-test-harness/releases
9-
export ATH_VERSION=6512.v7b_8c43086a_6f
9+
export ATH_VERSION=6518.v018e9d499cf2
1010

1111
if [[ $# -eq 0 ]]; then
1212
export JDK=21

core/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -651,7 +651,7 @@ THE SOFTWARE.
651651
<!-- Version specified in grandparent POM -->
652652
<configuration>
653653
<!-- Make sure to keep the directives in test/pom.xml and war/pom.xml in sync with these. -->
654-
<argLine>@{jacocoSurefireArgs} --add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.io=ALL-UNNAMED --add-opens java.base/java.util=ALL-UNNAMED -javaagent:${org.mockito:mockito-core:jar}</argLine>
654+
<argLine>@{jacocoSurefireArgs} --add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.io=ALL-UNNAMED --add-opens java.base/java.util=ALL-UNNAMED -javaagent:"${org.mockito:mockito-core:jar}"</argLine>
655655
<reuseForks>false</reuseForks>
656656
</configuration>
657657
</plugin>

core/src/main/java/hudson/model/Build.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@
8383
*
8484
* @author Kohsuke Kawaguchi
8585
*/
86-
public abstract class Build<P extends Project<P, B>, B extends Build<P, B>>
86+
public abstract class Build<P extends Project<P, B>, B extends Build<P, B>>
8787
extends AbstractBuild<P, B> {
8888

8989
/**

core/src/main/java/hudson/model/BuildableItem.java

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,4 +57,14 @@ default boolean scheduleBuild(int quietPeriod) {
5757
}
5858

5959
boolean scheduleBuild(int quietPeriod, Cause c);
60+
61+
/**
62+
* Whether the item is buildable.
63+
*
64+
* @return true, if the item can be built.
65+
* @since TODO
66+
*/
67+
default boolean isBuildable() {
68+
return true;
69+
}
6070
}

core/src/main/java/jenkins/model/ParameterizedJobMixIn.java

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@
4040
import hudson.model.Cause;
4141
import hudson.model.CauseAction;
4242
import hudson.model.Item;
43+
import hudson.model.ItemGroup;
4344
import hudson.model.Items;
4445
import hudson.model.Job;
4546
import hudson.model.ParameterDefinition;
@@ -562,8 +563,17 @@ default RunT createExecutable() throws IOException {
562563
return null;
563564
}
564565

566+
@Override
565567
default boolean isBuildable() {
566-
return !isDisabled() && !((Job) this).isHoldOffBuildUntilSave();
568+
if (isDisabled() || ((Job) this).isHoldOffBuildUntilSave()) {
569+
return false;
570+
}
571+
// If parent is disabled, child jobs (e.g., branch jobs) should not be buildable
572+
ItemGroup<? extends Item> parentGroup = ((Job) this).getParent();
573+
if (parentGroup instanceof BuildableItem bi) {
574+
return bi.isBuildable();
575+
}
576+
return true;
567577
}
568578

569579
@Extension

core/src/main/resources/hudson/model/DirectoryBrowserSupport/dir.jelly

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,9 @@ THE SOFTWARE.
3434
<!-- parent path -->
3535
<div class="parentPath">
3636
<form>
37-
<a href="${topPath}">${it.owner.name}</a> /
37+
<a href="${topPath}">
38+
${it.owner.displayName}
39+
</a> /
3840
<j:forEach var="p" items="${parentPath}">
3941
<a href="${p.href}">${p.title}</a>
4042
/

core/src/main/resources/hudson/views/BuildButtonColumn/icon.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ Behaviour.specify(
1414
method: "post",
1515
headers: crumb.wrap({}),
1616
}).then((rsp) => {
17-
if (rsp.ok) {
17+
if (rsp.status === 201) {
1818
notificationBar.show(message, notificationBar.SUCCESS);
1919
} else {
2020
notificationBar.show(failure, notificationBar.ERROR);

core/src/main/resources/lib/hudson/project/configurable/configurable.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
method: "post",
1111
headers: crumb.wrap({}),
1212
}).then((rsp) => {
13-
if (rsp.ok) {
13+
if (rsp.status === 201) {
1414
notificationBar.show(success, notificationBar.SUCCESS);
1515
} else {
1616
notificationBar.show(failure, notificationBar.ERROR);

package.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@
2323
"lint": "yarn lint:js && yarn lint:css"
2424
},
2525
"devDependencies": {
26-
"@babel/cli": "7.28.3",
27-
"@babel/core": "7.28.5",
28-
"@babel/preset-env": "7.28.5",
26+
"@babel/cli": "7.28.6",
27+
"@babel/core": "7.28.6",
28+
"@babel/preset-env": "7.28.6",
2929
"@eslint/js": "9.39.2",
3030
"babel-loader": "10.0.0",
3131
"clean-webpack-plugin": "4.0.0",
@@ -39,15 +39,15 @@
3939
"mini-css-extract-plugin": "2.9.4",
4040
"postcss": "8.5.6",
4141
"postcss-loader": "8.2.0",
42-
"postcss-preset-env": "10.6.0",
42+
"postcss-preset-env": "11.1.1",
4343
"postcss-scss": "4.0.9",
44-
"prettier": "3.7.4",
44+
"prettier": "3.8.0",
4545
"sass": "1.97.2",
4646
"sass-loader": "16.0.6",
4747
"style-loader": "4.0.0",
48-
"stylelint": "16.26.1",
48+
"stylelint": "17.0.0",
4949
"stylelint-checkstyle-reporter": "1.1.1",
50-
"stylelint-config-standard-scss": "16.0.0",
50+
"stylelint-config-standard-scss": "17.0.0",
5151
"webpack": "5.104.1",
5252
"webpack-cli": "6.0.1",
5353
"webpack-remove-empty-scripts": "1.1.1"

pom.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,9 +73,9 @@ THE SOFTWARE.
7373
</issueManagement>
7474

7575
<properties>
76-
<revision>2.547</revision>
76+
<revision>2.548</revision>
7777
<changelist>-SNAPSHOT</changelist>
78-
<project.build.outputTimestamp>2026-01-13T06:41:44Z</project.build.outputTimestamp>
78+
<project.build.outputTimestamp>2026-01-20T06:41:48Z</project.build.outputTimestamp>
7979

8080
<!-- configuration for patch tracker plugin -->
8181
<project.patchManagement.system>github</project.patchManagement.system>
@@ -99,7 +99,7 @@ THE SOFTWARE.
9999
<ban-junit4-imports.skip>false</ban-junit4-imports.skip>
100100
<!-- Make sure to keep the jetty-ee9-maven-plugin version in war/pom.xml in sync with the Jetty release in Winstone: -->
101101
<winstone.version>8.1029.vd3071f6b_5988</winstone.version>
102-
<node.version>24.12.0</node.version>
102+
<node.version>24.13.0</node.version>
103103
</properties>
104104

105105
<!--

0 commit comments

Comments
 (0)