Skip to content

Commit 205849e

Browse files
authored
Skip spotless in release:prepare (#11285)
The weekly release of Jenkins 2.536 failed its initial build because Maven release plugin 3.2.0 behaves differently than Maven release plugin 3.1.1. For 2.535, we were using Maven release plugin 3.1.1 and it did not require that we skip spotless verification during the `release:prepare` phase. Maven release plugin 3.2.0 requires it. Will allow the temporary change to be reverted from pull request: * jenkins-infra/release#782 Special thanks to @jglick for noting the better way to resolve the issue. Testing done: * Confirmed that builds fail without this change when running `mvn -B -V -ntp release:prepare` * Confirmed that builds pass with this change when running `mvn -B -V -ntp release:prepare`
1 parent 8f1bf5b commit 205849e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -327,7 +327,7 @@ THE SOFTWARE.
327327
<!-- Version specified in parent POM -->
328328
<configuration>
329329
<!-- work around for a bug in javadoc plugin that causes the release to fail. see MRELEASE-271 -->
330-
<preparationGoals>clean install</preparationGoals>
330+
<preparationGoals>-Dspotless.check.skip clean install</preparationGoals>
331331
<goals>-DskipTests -Dspotbugs.skip -Dmaven.checkstyle.skip -Dspotless.check.skip generate-resources javadoc:javadoc deploy</goals>
332332
<pushChanges>false</pushChanges>
333333
<localCheckout>true</localCheckout>

0 commit comments

Comments
 (0)