Remove trivial tooltips from the help link

Before this change, the help link showed a trivial tooltip that
simply repeated the name of the control. Such tooltips distract the user.
Users might even not click the link anymore because they think that the tooltip
already shows the actual help message. Now the additional help text
is available as aria-label only.

Author: uhafner

core/src/main/resources/lib/form/helpLink.jelly

@@ -29,12 +29,12 @@ THE SOFTWARE.
     a spacer if none is available.
 
     The help link is rendered as a table cell with an (?) icon.
-    If the user clicks it, the content of the HTML fragment at the given URL 
+    If the user clicks it, the content of the HTML fragment at the given URL
     is rendered in the area designated as <f:helpArea> by the caller,
     usually in a row beneath the item with help.
-    
+
     The alternative spacer is just an empty table cell.
-    
+
     This tag was introduced to ensure that the space reserved for help items
     is consistent over the UI whether or not help exists.
 
@@ -49,14 +49,14 @@ THE SOFTWARE.
       ]]>
     </st:attribute>
     <st:attribute name="featureName">
-      Name of the feature described by the help text, used for constructing the 
+      Name of the feature described by the help text, used for constructing the
       icon's alt attribute. Optional.
     </st:attribute>
   </st:documentation>
   <j:choose>
     <j:when test="${attrs.url!=null}">
       <j:set var="altText" value="${attrs.featureName != null ? '%Help for feature:' + ' ' + attrs.featureName : '%Help'}" />
-      <a href="#" class="jenkins-help-button" tooltip="${altText}" helpURL="${rootURL}${attrs.url}">
+      <a href="#" class="jenkins-help-button" aria-label="${altText}" helpURL="${rootURL}${attrs.url}">
         <!-- .jenkins-help-button span element is required as it's restyled in CSS -->
         <span>?</span>
       </a>

test/src/test/java/jenkins/security/Security2779Test.java

@@ -28,19 +28,11 @@ void setUp(JenkinsRule rule) {
         j = rule;
     }
 
-    @Test
-    void noXssInHelpLinkPanel() throws Exception {
-        noCrossSiteScriptingInHelp("#link-panel a");
-    }
-
     @Test
     void noXssInHelpIconPanel() throws Exception {
-        noCrossSiteScriptingInHelp("#icon-panel svg");
-    }
-
-    private void noCrossSiteScriptingInHelp(String selector) throws Exception {
-        final AtomicInteger alerts = new AtomicInteger();
-        final JenkinsRule.WebClient webClient = j.createWebClient();
+        var selector = "#icon-panel svg";
+        var alerts = new AtomicInteger();
+        var webClient = j.createWebClient();
         webClient.setAlertHandler((AlertHandler) (p, s) -> alerts.addAndGet(1));
         final HtmlPage page = webClient.goTo(URL_NAME);
         page.executeJavaScript("document.querySelector('" + selector + "')._tippy.show()");