Skip to content

Commit 34da377

Browse files
author
Vincent Potucek
committed
Apply staticanalysis.RemoveUnused
1 parent 3638351 commit 34da377

File tree

3 files changed

+9
-75
lines changed

3 files changed

+9
-75
lines changed

CONTRIBUTING.md

Lines changed: 6 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -95,33 +95,22 @@ which will open the workspace in IntelliJ IDEA using JetBrains Gateway.
9595

9696
### Linting
9797

98-
For linting we use a number of tools.
98+
For linting we use a number of tools:
9999

100-
Backend:
101-
- [checkstyle](https://checkstyle.sourceforge.io/)
102-
- [rewrite](https://github.com/openrewrite/rewrite)
103-
- [spotbugs](https://github.com/spotbugs/spotbugs)
104-
- [spotless](https://github.com/diffplug/spotless)
105-
106-
Frontend:
107-
- [eslint](https://eslint.org/)
108-
- [prettier](https://prettier.io/)
109-
- [stylelint](https://stylelint.io/)
100+
- [checkstyle](https://checkstyle.sourceforge.io/)
101+
- [eslint](https://eslint.org/)
102+
- [prettier](https://prettier.io/)
103+
- [spotless](https://github.com/diffplug/spotless)
104+
- [stylelint](https://stylelint.io/)
110105

111106
These are all configured to run as part of the Maven build, although they will be skipped if you are building with the `quick-build` profile.
112107

113108
To automatically fix backend issues, run:
114109

115-
#### spotless
116110
```sh
117111
mvn spotless:apply
118112
```
119113

120-
#### rewrite
121-
```sh
122-
mvn rewrite:run
123-
```
124-
125114
To view frontend issues, after [optionally adding Node and Yarn to your path](#running-the-yarn-frontend-build), run:
126115

127116
```sh

pom.xml

Lines changed: 3 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -286,10 +286,11 @@ THE SOFTWARE.
286286
</dependencies>
287287
<executions>
288288
<execution>
289+
<id>validate</id>
289290
<goals>
290291
<goal>check</goal>
291292
</goals>
292-
<phase>verify</phase>
293+
<phase>validate</phase>
293294
</execution>
294295
</executions>
295296
</plugin>
@@ -298,52 +299,10 @@ THE SOFTWARE.
298299
<artifactId>jacoco-maven-plugin</artifactId>
299300
<version>0.8.13</version>
300301
</plugin>
301-
<plugin>
302-
<groupId>org.openrewrite.maven</groupId>
303-
<artifactId>rewrite-maven-plugin</artifactId>
304-
<version>6.15.0</version>
305-
<configuration>
306-
<activeRecipes>
307-
<recipe>org.jenkins.openrewrite.DefinitionOfDone</recipe>
308-
</activeRecipes>
309-
<exclusions>
310-
<exclusion>**ApiTokenStats.java</exclusion>
311-
<exclusion>**DownloadFromUrlInstaller.java</exclusion>
312-
<exclusion>**generated-test-sources**</exclusion>
313-
</exclusions>
314-
<exportDatatables>true</exportDatatables>
315-
<failOnDryRunResults>true</failOnDryRunResults>
316-
</configuration>
317-
<dependencies>
318-
<dependency>
319-
<groupId>org.openrewrite.recipe</groupId>
320-
<artifactId>rewrite-static-analysis</artifactId>
321-
<version>2.15.0</version>
322-
</dependency>
323-
<dependency>
324-
<groupId>org.openrewrite.recipe</groupId>
325-
<artifactId>rewrite-third-party</artifactId>
326-
<version>0.24.3</version>
327-
</dependency>
328-
</dependencies>
329-
<executions>
330-
<!--move to CI-->
331-
<execution>
332-
<goals>
333-
<goal>dryRun</goal>
334-
</goals>
335-
<phase>verify</phase>
336-
</execution>
337-
</executions>
338-
</plugin>
339302
</plugins>
340303
</pluginManagement>
341304

342305
<plugins>
343-
<plugin>
344-
<groupId>org.openrewrite.maven</groupId>
345-
<artifactId>rewrite-maven-plugin</artifactId>
346-
</plugin>
347306
<plugin>
348307
<groupId>com.diffplug.spotless</groupId>
349308
<artifactId>spotless-maven-plugin</artifactId>
@@ -369,7 +328,7 @@ THE SOFTWARE.
369328
<configuration>
370329
<!-- work around for a bug in javadoc plugin that causes the release to fail. see MRELEASE-271 -->
371330
<preparationGoals>clean install</preparationGoals>
372-
<goals>-DskipTests -Dspotbugs.skip -Dmaven.checkstyle.skip -Dspotless.check.skip -DrewriteSkip generate-resources javadoc:javadoc deploy</goals>
331+
<goals>-DskipTests -Dspotbugs.skip -Dmaven.checkstyle.skip -Dspotless.check.skip generate-resources javadoc:javadoc deploy</goals>
373332
<pushChanges>false</pushChanges>
374333
<localCheckout>true</localCheckout>
375334
<tagNameFormat>jenkins-@{project.version}</tagNameFormat>

rewrite.yml

Lines changed: 0 additions & 14 deletions
This file was deleted.

0 commit comments

Comments
 (0)