[JENKINS-46257] Use ancestor context for RunParameter autocomplete

Author: Flamki

core/src/main/java/hudson/model/RunParameterDefinition.java

@@ -35,6 +35,7 @@
 import jenkins.model.Jenkins;
 import net.sf.json.JSONObject;
 import org.jenkinsci.Symbol;
+import org.kohsuke.stapler.AncestorInPath;
 import org.kohsuke.stapler.DataBoundConstructor;
 import org.kohsuke.stapler.QueryParameter;
 import org.kohsuke.stapler.Stapler;
@@ -154,8 +155,9 @@ public ParameterDefinition newInstance(StaplerRequest2 req, JSONObject formData)
             return req.bindJSON(RunParameterDefinition.class, formData);
         }
 
-        public AutoCompletionCandidates doAutoCompleteProjectName(@QueryParameter String value) {
-            return AutoCompletionCandidates.ofJobNames(Job.class, value, null, Jenkins.get());
+        public AutoCompletionCandidates doAutoCompleteProjectName(
+                @QueryParameter String value, @AncestorInPath Item self, @AncestorInPath ItemGroup container) {
+            return AutoCompletionCandidates.ofJobNames(Job.class, value, self, container);
         }
 
     }

test/src/test/java/hudson/model/RunParameterDefinitionTest.java

@@ -32,7 +32,9 @@
 import hudson.tasks.BuildStepMonitor;
 import hudson.tasks.Publisher;
 import hudson.util.LogTaskListener;
+import java.util.Arrays;
 import java.util.Set;
+import java.util.TreeSet;
 import java.util.logging.Level;
 import java.util.logging.Logger;
 import org.junit.jupiter.api.BeforeEach;
@@ -95,6 +97,19 @@ void inFolders() throws Exception {
         assertEquals("2", env.get("build_NUMBER"));
     }
 
+    @Issue("JENKINS-46257")
+    @Test
+    void autoCompleteProjectNameInFoldersUsesLocalContext() throws Exception {
+        MockFolder folder = j.createFolder("folder");
+        FreeStyleProject self = folder.createProject(FreeStyleProject.class, "self");
+        folder.createProject(FreeStyleProject.class, "sibling");
+
+        RunParameterDefinition.DescriptorImpl descriptor = j.jenkins.getDescriptorByType(RunParameterDefinition.DescriptorImpl.class);
+        AutoCompletionCandidates candidates = descriptor.doAutoCompleteProjectName("si", self, self.getParent());
+
+        assertContains(candidates, "sibling");
+    }
+
     @Test
     void testNULLFilter() throws Exception {
 
@@ -301,4 +316,8 @@ public Descriptor<Publisher> getDescriptor() {
             return new Descriptor<>(ResultPublisher.class) {};
         }
     }
+
+    private void assertContains(AutoCompletionCandidates candidates, String... values) {
+        assertEquals(new TreeSet<>(Arrays.asList(values)), new TreeSet<>(candidates.getValues()));
+    }
 }