Skip to content

Commit 4ea59ff

Browse files
Merge branch 'master' into Timestamp_issue
2 parents 604e476 + d938a49 commit 4ea59ff

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

ath.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ set -o xtrace
66
cd "$(dirname "$0")"
77

88
# https://github.com/jenkinsci/acceptance-test-harness/releases
9-
export ATH_VERSION=6504.v878e5b_e776d7
9+
export ATH_VERSION=6507.vef7dc6b_6f5c4
1010

1111
if [[ $# -eq 0 ]]; then
1212
export JDK=21

core/src/main/java/jenkins/util/SetContextClassLoader.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@
4141
* unclear, {@link #SetContextClassLoader(ClassLoader)} can be used as a fallback with {@link
4242
* PluginManager.UberClassLoader} as the argument, though this is not as safe since lookups could be
4343
* ambiguous in case two unrelated plugins both bundle the same library. In functional tests, {@code
44-
* RealJenkinsRule.Endpoint} can be used to reference a class loader that has access to the plugins
45-
* defined in the test scenario.
44+
* jenkinsRule.getPluginManager().uberClassLoader} can be used to reference a class loader that has
45+
* access to the plugins defined in the test scenario.
4646
*
4747
* <p>See <a
4848
* href="https://www.jenkins.io/doc/developer/plugin-development/dependencies-and-class-loading/#context-class-loaders">the

core/src/main/resources/hudson/slaves/Cloud/sidepanel.jelly

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,11 @@ THE SOFTWARE.
2727
<l:header />
2828
<l:side-panel>
2929
<l:tasks>
30-
<l:task contextMenu="false" href="." icon="symbol-computer" title="${%Status}"/>
31-
<l:task href="configure" icon="symbol-settings"
30+
<j:set var="url" value="${h.getNearestAncestorUrl(request2,it)}"/>
31+
<l:task contextMenu="false" href="${url}/" icon="symbol-computer" title="${%Status}"/>
32+
<l:task href="${url}/configure" icon="symbol-settings"
3233
title="${app.hasPermission(app.ADMINISTER) ? '%Configure' : '%View Configuration'}"/>
33-
<l:delete permission="${app.ADMINISTER}" title="${%Delete Cloud}" message="${%delete.cloud(it.displayName)}"/>
34+
<l:delete permission="${app.ADMINISTER}" title="${%Delete Cloud}" message="${%delete.cloud(it.displayName)}" urlPrefix="${url}"/>
3435
<t:actions />
3536
</l:tasks>
3637
<j:forEach var="action" items="${it.allActions}">

test/src/test/java/jenkins/util/SetContextClassLoaderTest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
import org.junit.jupiter.api.Test;
77
import org.junit.jupiter.api.extension.RegisterExtension;
88
import org.jvnet.hudson.test.JenkinsRule;
9-
import org.jvnet.hudson.test.RealJenkinsRule;
109
import org.jvnet.hudson.test.junit.jupiter.RealJenkinsExtension;
1110

1211
class SetContextClassLoaderTest {
@@ -20,7 +19,7 @@ void positive() throws Throwable {
2019
}
2120

2221
private static void _positive(JenkinsRule r) throws ClassNotFoundException {
23-
try (SetContextClassLoader sccl = new SetContextClassLoader(RealJenkinsRule.Endpoint.class)) {
22+
try (SetContextClassLoader sccl = new SetContextClassLoader(r.getPluginManager().uberClassLoader)) {
2423
assertEquals("hudson.tasks.Mailer$UserProperty", getUserPropertyClass().getName());
2524
}
2625
}

0 commit comments

Comments
 (0)