Remove trivial tooltips from the help link

Before this change, the help link showed a trivial tooltip that simply repeated
the name of the control. Such tooltips distract the user.
Users might even not click the link anymore because they think that the tooltip
already shows the actual help message.

Author: uhafner

core/src/main/resources/hudson/node_monitors/NodeMonitor/configure.jelly

@@ -3,7 +3,7 @@
   <j:set var="help" value="${descriptor.helpFile}"/>
   <div class="jenkins-form-label help-sibling tr">
     ${descriptor.displayName}
-    <f:helpLink url="${help}" featureName="${descriptor.displayName}"/>
+    <f:helpLink url="${help}"/>
   </div>
   <f:helpArea />
   <div class="optionalBlock-container jenkins-form-item">
@@ -21,4 +21,4 @@
       <st:include page="config.jelly" class="${descriptor.clazz}" optional="true"/>
     </div>
   </div>
-</j:jelly>
+</j:jelly>

core/src/main/resources/jenkins/views/ViewsTabBarUserProperty/config.jelly

@@ -14,7 +14,7 @@
             <j:set var="help" value="${descriptor.helpFile}"/>
             <j:if test="${help != null}">
               <div class="help-sibling jenkins-select-help">
-                <f:helpLink url="${help}" featureName="${descriptor.displayName}"/>
+                <f:helpLink url="${help}"/>
                 <f:helpArea/>
               </div>
             </j:if>

core/src/main/resources/lib/form/dropdownDescriptorSelector.jelly

@@ -67,7 +67,7 @@ THE SOFTWARE.
           <j:set var="help" value="${descriptor.helpFile}"/>
           <j:if test="${help != null}">
             <div class="help-sibling jenkins-select-help">
-              <f:helpLink url="${help}" featureName="${descriptor.displayName}"/>
+              <f:helpLink url="${help}"/>
               <f:helpArea/>
             </div>
           </j:if>

core/src/main/resources/lib/form/dropdownList.jelly

@@ -43,7 +43,7 @@ THE SOFTWARE.
     <div class='jenkins-form-item'>
         <div class="jenkins-form-label help-sibling">
             ${attrs.title}
-            <f:helpLink url="${attrs.help}" featureName="${title}"/>
+            <f:helpLink url="${attrs.help}"/>
         </div>
         <j:if test="${attrs.help!=null}">
             <f:helpArea/>

core/src/main/resources/lib/form/entry.jelly

@@ -78,7 +78,7 @@ THE SOFTWARE.
       <j:when test="${possiblyEscapedTitle!=null}">
         <div class="jenkins-form-label help-sibling">
           <j:out value="${possiblyEscapedTitle}" />
-          <f:helpLink url="${attrs.help}" featureName="${attrs.title}"/>
+          <f:helpLink url="${attrs.help}"/>
         </div>
         <j:if test="${!empty(attrs.description)}">
           <f:description>
@@ -100,7 +100,7 @@ THE SOFTWARE.
           <j:when test="${attrs.help!=null}">
             <div class="setting-main help-sibling" style="display: inline-flex; align-items: center;">
               <d:invokeBody />
-              <f:helpLink url="${attrs.help}" featureName="${attrs.title}"/>
+              <f:helpLink url="${attrs.help}"/>
             </div>
           </j:when>
           <j:otherwise>

core/src/main/resources/lib/form/helpLink.jelly

@@ -29,12 +29,12 @@ THE SOFTWARE.
     a spacer if none is available.
 
     The help link is rendered as a table cell with an (?) icon.
-    If the user clicks it, the content of the HTML fragment at the given URL 
+    If the user clicks it, the content of the HTML fragment at the given URL
     is rendered in the area designated as <f:helpArea> by the caller,
     usually in a row beneath the item with help.
-    
+
     The alternative spacer is just an empty table cell.
-    
+
     This tag was introduced to ensure that the space reserved for help items
     is consistent over the UI whether or not help exists.
 
@@ -49,14 +49,13 @@ THE SOFTWARE.
       ]]>
     </st:attribute>
     <st:attribute name="featureName">
-      Name of the feature described by the help text, used for constructing the 
+      Name of the feature described by the help text, used for constructing the
       icon's alt attribute. Optional.
     </st:attribute>
   </st:documentation>
   <j:choose>
     <j:when test="${attrs.url!=null}">
-      <j:set var="altText" value="${attrs.featureName != null ? '%Help for feature:' + ' ' + attrs.featureName : '%Help'}" />
-      <a href="#" class="jenkins-help-button" tooltip="${altText}" helpURL="${rootURL}${attrs.url}">
+      <a href="#" class="jenkins-help-button" helpURL="${rootURL}${attrs.url}">
         <!-- .jenkins-help-button span element is required as it's restyled in CSS -->
         <span>?</span>
       </a>

core/src/main/resources/lib/form/optionalBlock.jelly

@@ -74,7 +74,7 @@ THE SOFTWARE.
           <div class="jenkins-checkbox-help-wrapper">
             <f:checkbox name="${attrs.name}" class="optional-block-control block-control optional-block-event-item"
                         negative="${attrs.negative}" checked="${attrs.checked}" field="${attrs.field}" title="${title}" />
-            <f:helpLink url="${attrs.help}" featureName="${title}"/>
+            <f:helpLink url="${attrs.help}"/>
           </div>
         </div>
         <j:if test="${attrs.help!=null}">

core/src/main/resources/lib/form/radioBlock.jelly

@@ -72,7 +72,7 @@ THE SOFTWARE.
             ${title}
           </label>
         </div>
-        <f:helpLink url="${help}" featureName="${title}" />
+        <f:helpLink url="${help}"/>
       </div>
     </div>
     <j:if test="${attrs.help!=null}">

test/src/test/resources/jenkins/security/Security2779Test/ViewHolder/index.jelly

@@ -3,7 +3,7 @@
   <l:layout title="help">
     <l:main-panel>
       <div id="link-panel">
-        <f:helpLink featureName="${it.featureName}" url="foo" />
+        <f:helpLink url="foo" />
       </div>
       <div id="icon-panel">
         <l:helpIcon tooltip="${it.featureName}" />