Commit 7025455
committed
Fix false 'Build Scheduled' notification when parent multibranch is disabled
When trying to trigger a build of a branch job in a disabled multibranch
project, the UI showed 'Build Scheduled' even though the build was not
actually scheduled (queue returned null, causing a 302 redirect).
Changes:
- Updated isBuildable() to check if parent ParameterizedJob is disabled
- Changed doBuild() to return 409 CONFLICT when schedule2() returns null
- Fixed JavaScript to only treat HTTP 201 as success (not 302 redirects)
Fixes issue where disabled multibranch parent allows branch builds to
appear scheduled when they are actually rejected.1 parent 1366fa9 commit 7025455
File tree
2 files changed
+16
-3
lines changed- core/src/main
- java/jenkins/model
- resources/lib/hudson/project/configurable
2 files changed
+16
-3
lines changedLines changed: 15 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| 43 | + | |
43 | 44 | | |
44 | 45 | | |
45 | 46 | | |
| |||
231 | 232 | | |
232 | 233 | | |
233 | 234 | | |
234 | | - | |
| 235 | + | |
235 | 236 | | |
236 | 237 | | |
237 | 238 | | |
| |||
563 | 564 | | |
564 | 565 | | |
565 | 566 | | |
566 | | - | |
| 567 | + | |
| 568 | + | |
| 569 | + | |
| 570 | + | |
| 571 | + | |
| 572 | + | |
| 573 | + | |
| 574 | + | |
| 575 | + | |
| 576 | + | |
| 577 | + | |
| 578 | + | |
| 579 | + | |
567 | 580 | | |
568 | 581 | | |
569 | 582 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| |||
0 commit comments