[JENKINS-73804] Replace intimidating rage.svg with friendly shrug.svg on 404 pages

prabhu463 · prabhu463 · commit 733a2fa61ecf · 2026-02-22T17:13:28.000Z
diff --git a/.gitignore b/.gitignore
@@ -77,3 +77,4 @@ node_modules/
 
 # Generated JavaScript Bundles
 war/src/main/webapp/jsbundles/
+apache-maven-3.9.6-bin.tar.gz
diff --git a/core/src/main/java/jenkins/security/ResourceDomainFilter.java b/core/src/main/java/jenkins/security/ResourceDomainFilter.java
@@ -49,8 +49,16 @@
 public class ResourceDomainFilter implements HttpServletFilter {
 
     private static final Logger LOGGER = Logger.getLogger(ResourceDomainFilter.class.getName());
-
-    private static final Set<String> ALLOWED_PATHS = new HashSet<>(Arrays.asList("/" + ResourceDomainRootAction.URL, "/favicon.ico", "/favicon.svg", "/apple-touch-icon.png", "/mask-icon.svg", "/robots.txt", "/images/rage.svg"));
+    private static final Set<String> ALLOWED_PATHS = new HashSet<>(Arrays.asList(
+            "/" + ResourceDomainRootAction.URL,
+            "/favicon.ico",
+            "/favicon.svg",
+            "/apple-touch-icon.png",
+            "/mask-icon.svg",
+            "/robots.txt",
+            "/images/rage.svg",
+            "/images/shrug.svg"
+    ));
     public static final String ERROR_RESPONSE = "Jenkins serves only static files on this domain.";
 
     @Override
diff --git a/core/src/main/resources/jenkins/model/Jenkins/_404.jelly b/core/src/main/resources/jenkins/model/Jenkins/_404.jelly
@@ -34,7 +34,7 @@ THE SOFTWARE.
         <l:header />
         <l:main-panel>
             <h1 style="text-align: center">
-                <img src="${imagesURL}/rage.svg" height="179" width="154"/>
+                <img src="${imagesURL}/shrug.svg" height="179" width="154" alt="${%Page Not Found}"/>
                 <span style="font-size:50px"><st:nbsp/>${%Oops!}</span>
             </h1>
             <div id="error-description" style="text-align: center">
diff --git a/core/src/main/resources/jenkins/model/Jenkins/_404_simple.jelly b/core/src/main/resources/jenkins/model/Jenkins/_404_simple.jelly
@@ -48,8 +48,7 @@ THE SOFTWARE.
             </head>
             <body style="font-family: system-ui, sans-serif">
                 <h1 style="text-align: center">
-                    <img src="${imagesURL}/rage.svg" height="179" width="154" style="vertical-align: middle"/>
-                    <span style="font-size:50px"><st:nbsp/>${%Oops!}</span>
+<img src="${imagesURL}/shrug.svg" height="179" width="154" alt="${%Page Not Found}"/>                    <span style="font-size:50px"><st:nbsp/>${%Oops!}</span>
                 </h1>
                 <div style="text-align: center">
                     <h2>${%title(jakarta.servlet.error.message?:'Not Found')}</h2>
diff --git a/war/src/main/webapp/images/shrug.svg b/war/src/main/webapp/images/shrug.svg

Original file line number	Diff line number	Diff line change
`@@ -77,3 +77,4 @@ node_modules/`
`77`	`77`
`78`	`78`	`# Generated JavaScript Bundles`
`79`	`79`	`war/src/main/webapp/jsbundles/`
	`80`	`+apache-maven-3.9.6-bin.tar.gz`