Skip to content

Commit 8b7aaac

Browse files
committed
Adapt to #23902
1 parent f48c813 commit 8b7aaac

File tree

2 files changed

+17
-12
lines changed

2 files changed

+17
-12
lines changed

core/src/main/resources/jenkins/model/Jenkins/_script.jelly

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,10 @@ THE SOFTWARE.
2727
-->
2828
<?jelly escape-by-default='true'?>
2929
<j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define" xmlns:l="/lib/layout" xmlns:t="/lib/hudson" xmlns:f="/lib/form">
30-
<j:set var="previousIt" value="${it}" />
31-
<j:new var="it" className="jenkins.management.ConsoleLink" />
30+
<j:new var="managementLink" className="jenkins.management.ConsoleLink" />
3231

33-
<l:settings-subpage includeBreadcrumb="true" permission="${app.ADMINISTER}" header="${null}" noDefer="true">
34-
<j:set var="it" value="${previousIt}" />
32+
<l:settings-subpage includeBreadcrumb="true" permission="${app.ADMINISTER}"
33+
header="${null}" noDefer="true" managementLink="${managementLink}">
3534

3635
<t:scriptConsole scripts="${['println(Jenkins.instance.pluginManager.plugins)']}"
3736
layout="none" />

core/src/main/resources/lib/layout/settings-subpage.jelly

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,10 @@ THE SOFTWARE.
2626
<j:jelly xmlns:j="jelly:core" xmlns:l="/lib/layout" xmlns:d="jelly:define" xmlns:st="jelly:stapler" xmlns:f="/lib/form">
2727
<st:documentation>
2828
A reusable container for subpages relating under Manage Jenkins.
29+
<st:attribute name="managementLink" type="hudson.model.ManagementLink" use="optional">
30+
Specifies the object for which page details will be loaded from.
31+
Defaults to the "it" object in the current context.
32+
</st:attribute>
2933
<st:attribute name="permission">
3034
If given, this page is only made available to users who have the specified permission.
3135
(The permission will be checked against the "it" object.)
@@ -55,19 +59,21 @@ THE SOFTWARE.
5559
<j:new className="hudson.model.ManageJenkinsAction" var="manageJenkinsAction" />
5660
<l:userExperimentalFlag var="newManageJenkins" flagClassName="jenkins.model.experimentalflags.NewManageJenkinsUserExperimentalFlag" />
5761

58-
<l:layout title="${it.displayName} - ${manageJenkinsAction.displayName}"
62+
<j:set var="managementLink" value="${attrs.managementLink ?: it}" />
63+
64+
<l:layout title="${managementLink.displayName} - ${manageJenkinsAction.displayName}"
5965
permission="${attrs.permission}"
6066
permissions="${attrs.permissions}"
6167
type="${newManageJenkins ? 'two-column' : 'one-column'}">
6268

6369
<j:if test="${attrs.includeBreadcrumb}">
6470
<!-- Hacky - this will be improved in subsequent PRs -->
6571
<j:choose>
66-
<j:when test="${it.class.name eq 'jenkins.management.ConfigureLink'}">
67-
<f:breadcrumb-config-outline title="${it.displayName}" />
72+
<j:when test="${managementLink.class.name eq 'jenkins.management.ConfigureLink'}">
73+
<f:breadcrumb-config-outline title="${managementLink.displayName}" />
6874
</j:when>
6975
<j:otherwise>
70-
<l:breadcrumb title="${it.displayName}" />
76+
<l:breadcrumb title="${managementLink.displayName}" />
7177
</j:otherwise>
7278
</j:choose>
7379
</j:if>
@@ -103,9 +109,9 @@ THE SOFTWARE.
103109
<div class="app-settings-container">
104110
<div class="app-settings-container__inner">
105111
<j:if test="${!attrs.containsKey('header')}">
106-
<l:app-bar title="${it.displayName}" />
112+
<l:app-bar title="${managementLink.displayName}" />
107113
<div class="jenkins-page-description">
108-
${it.description}
114+
${managementLink.description}
109115
</div>
110116
</j:if>
111117

@@ -140,9 +146,9 @@ THE SOFTWARE.
140146
<j:otherwise>
141147
<l:main-panel>
142148
<j:if test="${!attrs.containsKey('header')}">
143-
<l:app-bar title="${it.displayName}" />
149+
<l:app-bar title="${managementLink.displayName}" />
144150
<div class="jenkins-page-description">
145-
${it.description}
151+
${managementLink.description}
146152
</div>
147153
</j:if>
148154

0 commit comments

Comments
 (0)