mend

Author: meetgoti07

core/src/main/resources/lib/form/link/link.js

@@ -5,18 +5,14 @@ Behaviour.specify("A.post", "link.post", 0, function (element) {
     element.removeAttribute("data-post-href");
   }
 
-  // Use addEventListener for robust event handling (allows multiple listeners, less prone to overwriting)
-  // Check if we already attached a listener (avoid duplicates)
   if (element._postLinkHandlerAttached) {
     return;
   }
 
-  // Remove any existing onclick to avoid conflicts
   if (element.onclick) {
     element.onclick = null;
   }
 
-  // Create handler function
   var postHandler = function (ev) {
     if (ev) {
       ev.preventDefault();
@@ -31,6 +27,6 @@ Behaviour.specify("A.post", "link.post", 0, function (element) {
     return false;
   };
 
-  element.addEventListener("click", postHandler, true); // Use capture phase to ensure we handle it early
-  element._postLinkHandlerAttached = true; // Mark as attached
+  element.addEventListener("click", postHandler, true);
+  element._postLinkHandlerAttached = true;
 });

test/src/test/java/jenkins/model/JenkinsTest.java

@@ -165,7 +165,7 @@ void testPaneToggleCollapsePostSucceeds() throws Exception {
                 assertNotNull(paneId, "Collapse link should have data-post-href");
 
                 HtmlElementUtil.click(collapseLink);
-    
+
                 wc.waitForBackgroundJavaScript(500);
 
                 HtmlPage currentPage = (HtmlPage) wc.getCurrentWindow().getEnclosedPage();

test/src/test/java/lib/form/PostLinkTest.java

@@ -106,30 +106,22 @@ void rapidClicksDoNotCauseRaceCondition() throws Exception {
         HtmlAnchor link = page.getAnchorByText("Rapid Click Test");
         assertNotNull(link, "POST link should be present");
 
-        // Reset counter
         rapidClickAction.reset();
 
         // Click multiple times rapidly to simulate race condition
-        // Note: HtmlUnit may not handle rapid clicks the same way as a real browser,
-        // but this tests that handlers are attached correctly
         for (int i = 0; i < 3; i++) {
             try {
-                // Reload page to get fresh link
                 page = wc.goTo(rapidClickAction.getUrlName());
                 wc.waitForBackgroundJavaScript(500);
                 link = page.getAnchorByText("Rapid Click Test");
                 HtmlElementUtil.click(link);
-                // Small delay
                 Thread.sleep(50);
             } catch (Exception e) {
-                // Ignore navigation exceptions
             }
         }
 
-        // Wait for all requests to complete
         Thread.sleep(500);
 
-        // Verify POST was called (may be called multiple times, but should all be POST)
         assertTrue(rapidClickAction.getCallCount() > 0, "POST action should have been called");
         assertFalse(rapidClickAction.wasGetRequest(), "Should not have any GET requests");
     }