make the MANAGE permission enabled by default (#23873)

* make the MANAGE permission enabled by default

Removed experimental warning for MANAGE permission and enable it by default.

* update tests to accomodate enabling of Overall/Manage

Author: jtnord

core/src/main/java/jenkins/model/Jenkins.java

@@ -5862,15 +5862,12 @@ public boolean shouldShowStackTrace() {
      * are unsafe to make available to users with only this permission,
      * as they could be used to bypass permission enforcement and elevate permissions.</p>
      *
-     * <p>This permission is disabled by default and support for it considered experimental.
-     * Administrators can set the system property {@code jenkins.security.ManagePermission} to enable it.</p>
-     *
      * @since 2.222
      */
     public static final Permission MANAGE = new Permission(PERMISSIONS, "Manage",
             Messages._Jenkins_Manage_Description(),
             ADMINISTER,
-            SystemProperties.getBoolean("jenkins.security.ManagePermission"),
+            true,
             new PermissionScope[]{PermissionScope.JENKINS});
 
     /**

test/src/test/java/hudson/cli/CancelQuietDownCommandTest.java

@@ -64,7 +64,7 @@ void cancelQuietDownShouldFailWithoutAdministerPermission() {
                 .invoke();
         assertThat(result, failedWith(6));
         assertThat(result, hasNoStandardOutput());
-        assertThat(result.stderr(), containsString("ERROR: user is missing the Overall/Administer permission"));
+        assertThat(result.stderr(), containsString("ERROR: user is missing the Overall/Manage permission"));
     }
 
     @Test

test/src/test/java/hudson/cli/QuietDownCommandTest.java

@@ -90,7 +90,7 @@ void quietDownShouldFailWithoutAdministerPermission() {
                 .invoke();
         assertThat(result, failedWith(6));
         assertThat(result, hasNoStandardOutput());
-        assertThat(result.stderr(), containsString("ERROR: " + VIEWER + " is missing the Overall/Administer permission"));
+        assertThat(result.stderr(), containsString("ERROR: " + VIEWER + " is missing the Overall/Manage permission"));
     }
 
     @Test

test/src/test/java/hudson/cli/ReloadConfigurationCommandTest.java

@@ -81,7 +81,7 @@ void reloadConfigurationShouldFailWithoutAdministerPermission() {
 
         assertThat(result, failedWith(6));
         assertThat(result, hasNoStandardOutput());
-        assertThat(result.stderr(), containsString("user is missing the Overall/Administer permission"));
+        assertThat(result.stderr(), containsString("user is missing the Overall/Manage permission"));
     }
 
     @Test

test/src/test/java/hudson/security/ACLTest.java

@@ -136,7 +136,7 @@ void checkAnyPermissionDoesNotShowDisabledPermissionsInError() {
         try (ACLContext ignored = ACL.as2(manager.impersonate2())) {
             Exception e = assertThrows(AccessDeniedException.class,
                     () -> jenkins.getACL().checkAnyPermission(Jenkins.MANAGE, Jenkins.SYSTEM_READ));
-            assertEquals("manager is missing the Overall/Administer permission", e.getMessage());
+            assertEquals("manager is missing a permission, one of Overall/Manage, Overall/Administer is required", e.getMessage());
         }
     }
 

test/src/test/java/jenkins/security/StackTraceSuppressionTest.java

@@ -76,7 +76,7 @@ void authenticationManageException() throws Exception {
         HtmlPage page = wc.goTo("manage");
 
         String content = page.getWebResponse().getContentAsString();
-        assertThat(content, containsString(alice.getId() + " is missing the Overall/Administer permission"));
+        assertThat(content, containsString(alice.getId() + " is missing a permission, one of Overall/Manage, Overall/Administer is required"));
         assertThat(content, not(containsString("Caused by")));
     }